From 35560dec1563ac3521d9e3934c14354e161aa8fd Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Fri, 9 Oct 2026 18:34:11 +0000 Subject: [PATCH] fix(ci): normalize CRLF line endings in checksum verification Strip carriage returns (\r) from checksums.sha256 before passing to sha256sum or shasum in build scripts and GitHub Actions workflows. Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com> --- .github/workflows/Flatpak.yml | 2 +- .github/workflows/Release.yml | 8 ++++---- build_linux.sh | 2 +- build_mac.sh | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/Flatpak.yml b/.github/workflows/Flatpak.yml index 8b4a5ea..d2d9121 100644 --- a/.github/workflows/Flatpak.yml +++ b/.github/workflows/Flatpak.yml @@ -66,7 +66,7 @@ jobs: - name: Clone OpenROM binaries repo run: | git clone --depth 1 https://github.com/M5Devs/OpenROM-bins.git bins - (cd bins && sha256sum -c checksums.sha256) + (cd bins && tr -d '\r' < checksums.sha256 | sha256sum -c -) - name: Set up Flutter uses: subosito/flutter-action@v2 diff --git a/.github/workflows/Release.yml b/.github/workflows/Release.yml index 8fdd73c..5f3f83a 100644 --- a/.github/workflows/Release.yml +++ b/.github/workflows/Release.yml @@ -23,7 +23,7 @@ jobs: shell: bash run: | git clone https://github.com/M5Devs/OpenROM-bins.git bins - (cd bins && sha256sum -c checksums.sha256) + (cd bins && tr -d '\r' < checksums.sha256 | sha256sum -c -) - name: Copy Windows binaries run: | @@ -153,7 +153,7 @@ jobs: - name: Fetch binaries from OpenROM-bins run: | git clone https://github.com/M5Devs/OpenROM-bins.git bins - (cd bins && sha256sum -c checksums.sha256) + (cd bins && tr -d '\r' < checksums.sha256 | sha256sum -c -) mkdir -p assets/linux/x86_64 cp -r bins/linux/x86_64/. assets/linux/x86_64/ chmod +x assets/linux/x86_64/* @@ -277,7 +277,7 @@ jobs: - name: Fetch binaries from OpenROM-bins run: | git clone https://github.com/M5Devs/OpenROM-bins.git bins - (cd bins && sha256sum -c checksums.sha256) + (cd bins && tr -d '\r' < checksums.sha256 | sha256sum -c -) mkdir -p assets/linux/arm64 cp -r bins/linux/arm64/. assets/linux/arm64/ chmod +x assets/linux/arm64/* @@ -384,7 +384,7 @@ jobs: - name: Fetch binaries from OpenROM-bins run: | git clone https://github.com/M5Devs/OpenROM-bins.git bins - (cd bins && (sha256sum -c checksums.sha256 || shasum -a 256 -c checksums.sha256)) + (cd bins && (tr -d '\r' < checksums.sha256 | sha256sum -c - || tr -d '\r' < checksums.sha256 | shasum -a 256 -c -)) mkdir -p assets/macos/arm64 assets/macos/x86_64 cp -r bins/macos/arm64/. assets/macos/arm64/ cp -r bins/macos/x86_64/. assets/macos/x86_64/ diff --git a/build_linux.sh b/build_linux.sh index d2055db..73656b5 100755 --- a/build_linux.sh +++ b/build_linux.sh @@ -3,7 +3,7 @@ set -e if [ -d "bins" ]; then echo "=== Verifying OpenROM-bins checksums ===" - (cd bins && sha256sum -c checksums.sha256) + (cd bins && tr -d '\r' < checksums.sha256 | sha256sum -c -) fi echo "=== Building OpenROM Core (Dart CLI) ===" diff --git a/build_mac.sh b/build_mac.sh index bd40439..6b89840 100755 --- a/build_mac.sh +++ b/build_mac.sh @@ -3,7 +3,7 @@ set -e if [ -d "bins" ]; then echo "=== Verifying OpenROM-bins checksums ===" - (cd bins && (sha256sum -c checksums.sha256 || shasum -a 256 -c checksums.sha256)) + (cd bins && (tr -d '\r' < checksums.sha256 | sha256sum -c - || tr -d '\r' < checksums.sha256 | shasum -a 256 -c -)) fi echo "=== Building OpenROM Core (Dart CLI) ==="