From f1e2a20631e63699d5de0403f09c1bcac13a1ceb Mon Sep 17 00:00:00 2001 From: Roman Inflianskas Date: Mon, 12 Oct 2026 09:21:23 +0000 Subject: [PATCH] ci: run each Windows acceptance self-test in its own step pwsh carries on past a failing native command, and the step's result is the last command's exit code, so the three self-tests in one run: block could hide a failure of the first two. Give each its own step, as the Build and Clippy steps already are. The Linux job runs its block under bash -e, which already stops at the first failure. Follows up the review on #488. Signed-off-by: Roman Inflianskas --- .github/workflows/ci.yml | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d51cbf2f2..68d3ddd0e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -665,13 +665,23 @@ jobs: shell: pwsh run: python .\scripts\smoke_local.py --skip-build - - name: Acceptance harness self-tests + # One command per step: pwsh carries on past a failing native command and + # the step reports only the last command's exit code, so a multi-line + # block would let an early self-test fail unseen. + - name: Acceptance harness self-test (ComfyUI) if: needs.changes.outputs.heavy == 'true' shell: pwsh - run: | - python .\scripts\comfyui_therock_gpu_test.py --self-test - python .\scripts\local_assistant_therock_gpu_test.py --self-test - python .\scripts\vllm_therock_gpu_test.py --self-test + run: python .\scripts\comfyui_therock_gpu_test.py --self-test + + - name: Acceptance harness self-test (local assistant) + if: needs.changes.outputs.heavy == 'true' + shell: pwsh + run: python .\scripts\local_assistant_therock_gpu_test.py --self-test + + - name: Acceptance harness self-test (vLLM) + if: needs.changes.outputs.heavy == 'true' + shell: pwsh + run: python .\scripts\vllm_therock_gpu_test.py --self-test - name: Release readiness self-test if: needs.changes.outputs.heavy == 'true'