From f4a0f05c22bc70db01af8136e1d4c28b5c291c8a Mon Sep 17 00:00:00 2001 From: Sekers <46898253+Sekers@users.noreply.github.com> Date: Thu, 24 Sep 2026 12:00:29 -0500 Subject: [PATCH] Allow live Graph testing in any tenant, reaching only your own accounts The pull request template, CONTRIBUTING.md, and RELEASING.md asked for live Microsoft Graph testing in a test tenant. What matters is that the test reaches nobody who didn't agree to it, and most contributors have no test tenant, so all three now ask for that instead: any tenant the tester is allowed to test in, with messages and files going only to accounts they control. --- .github/pull_request_template.md | 2 +- CONTRIBUTING.md | 5 +++-- RELEASING.md | 4 ++-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index c3b250c..5c72483 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -17,4 +17,4 @@ - [ ] `CHANGELOG.md` has an entry in the right section under `[Unreleased]` (added if missing), or the change is not user-visible - [ ] `.\Tests\Invoke-Tests.ps1` passes - [ ] Contains no real tenant names, email domains, secrets, or configuration files -- [ ] Any live Microsoft Graph testing was done in a test tenant and is described above +- [ ] Any live Microsoft Graph testing is described above, and sent messages and files only to accounts you control diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fdcc96f..62bdbba 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -26,8 +26,9 @@ Thank you for helping improve ScriptMessage. This guide covers the everyday work - **Never commit a real configuration file, secret, or certificate.** Never name a real organization, tenant, or email domain in code, tests, examples, or commit messages; use an RFC 2606 reserved domain instead, such as `example.com`. Those can never be registered, so a placeholder that gets run unedited reaches nobody. -- **The automated tests never connect to a tenant.** If a change needs a live Microsoft Graph test, run it in - your own test tenant and describe what you tested in the pull request. +- **The automated tests never connect to a tenant.** If a change needs a live Microsoft Graph test, you don't need + a test tenant: any tenant you're allowed to test in will do, as long as every message and file you send goes + only to accounts you control. Describe what you tested in the pull request. - **Text files are UTF-8 with LF line endings and no byte order mark, and PowerShell files contain only ASCII.** Windows PowerShell 5.1 misreads non-ASCII characters in PowerShell files saved without a byte order mark. `.gitattributes` handles line endings, the test suite checks all three rules, and [AGENTS.md](./AGENTS.md) diff --git a/RELEASING.md b/RELEASING.md index ea940ca..a39ecaf 100644 --- a/RELEASING.md +++ b/RELEASING.md @@ -215,5 +215,5 @@ enforceable: - [ ] The wiki (`Sekers/ScriptMessage.wiki`) describes this release, and its update was pushed after the Release workflow passed. - [ ] `main` was merged back into `develop` with a merge commit. -- [ ] Anything that needs a live Microsoft Graph test was tested separately in a test tenant. The automated tests - never connect to a tenant. +- [ ] Anything that needs a live Microsoft Graph test was tested separately, sending messages and files only to + accounts the tester controls. The automated tests never connect to a tenant.