From 3d9bd5a2ca7dce6e8972a0f3f461ae93266617a0 Mon Sep 17 00:00:00 2001 From: Ling-Sen Peng Date: Wed, 7 Oct 2026 16:10:22 -0700 Subject: [PATCH] Fix setWorkflowTags to send PUT --- .../java/io/orkes/conductor/client/http/TagsResource.java | 2 +- .../io/orkes/conductor/client/http/MetadataClientTests.java | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/conductor-client/src/main/java/io/orkes/conductor/client/http/TagsResource.java b/conductor-client/src/main/java/io/orkes/conductor/client/http/TagsResource.java index ad922383d..18911db7b 100644 --- a/conductor-client/src/main/java/io/orkes/conductor/client/http/TagsResource.java +++ b/conductor-client/src/main/java/io/orkes/conductor/client/http/TagsResource.java @@ -128,7 +128,7 @@ public void setTaskTags(List tagObjects, String taskName) { public void setWorkflowTags(List tagObjects, String workflow) { ConductorClientRequest request = ConductorClientRequest.builder() - .method(Method.GET) + .method(Method.PUT) .path("/metadata/workflow/{workflow}/tags") .addPathParam("workflow", workflow) .body(tagObjects) diff --git a/tests/src/test/java/io/orkes/conductor/client/http/MetadataClientTests.java b/tests/src/test/java/io/orkes/conductor/client/http/MetadataClientTests.java index 1e91169d9..836dfd110 100644 --- a/tests/src/test/java/io/orkes/conductor/client/http/MetadataClientTests.java +++ b/tests/src/test/java/io/orkes/conductor/client/http/MetadataClientTests.java @@ -108,9 +108,11 @@ void tagWorkflow() { } } metadataClient.addWorkflowTag(tagObject, Commons.WORKFLOW_NAME); - metadataClient.setWorkflowTags(List.of(tagObject), Commons.WORKFLOW_NAME); + // A different tag, so the assertion fails unless setWorkflowTags replaces the existing one. + TagObject replacement = new TagObject().key(tagObject.getKey()).value(tagObject.getValue() + "-replaced"); + metadataClient.setWorkflowTags(List.of(replacement), Commons.WORKFLOW_NAME); List tags = metadataClient.getWorkflowTags(Commons.WORKFLOW_NAME); - Assertions.assertIterableEquals(List.of(tagObject), tags); + Assertions.assertIterableEquals(List.of(replacement), tags); } // ==================== Additional CRUD Tests ====================