fix(cli): remove ignored automation dedup key

Author: ysyneu

internal/cli/automation.go

@@ -458,7 +458,6 @@ func buildAutomationFireCmd(use string) *cobra.Command {
 	var (
 		token    string
 		text     string
-		dedupKey string
 		dataJSON string
 	)
 
@@ -468,12 +467,11 @@ func buildAutomationFireCmd(use string) *cobra.Command {
 		Long: `Trigger an Automation run through its HTTP POST trigger.
 
 The trigger authenticates with its one-time token, not the account app key. Pass
---token or set FLASHDUTY_AUTOMATION_TRIGGER_TOKEN. Use --dedup-key to make
-retries idempotent for the same trigger.`,
+--token or set FLASHDUTY_AUTOMATION_TRIGGER_TOKEN.`,
 		Args: requireExactArg("trigger_id"),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			return runCommand(cmd, args, func(ctx *RunContext) error {
-				out, err := runAutomationFire(ctx, ctx.Args[0], token, text, dedupKey, dataJSON)
+				out, err := runAutomationFire(ctx, ctx.Args[0], token, text, dataJSON)
 				if err != nil {
 					return err
 				}
@@ -484,19 +482,15 @@ retries idempotent for the same trigger.`,
 
 	cmd.Flags().StringVar(&token, "token", "", "HTTP POST trigger token; defaults to FLASHDUTY_AUTOMATION_TRIGGER_TOKEN")
 	cmd.Flags().StringVar(&text, "text", "", "Context text passed to this run")
-	cmd.Flags().StringVar(&dedupKey, "dedup-key", "", "Optional idempotency key")
 	cmd.Flags().StringVar(&dataJSON, "data", "", "Full request body as JSON; typed flags override its fields. Accepts inline JSON, or - to read stdin.")
 	return cmd
 }
 
-func runAutomationFire(ctx *RunContext, triggerID, token, text, dedupKey, dataJSON string) (*flashduty.AutomationFireAPITriggerResponse, error) {
+func runAutomationFire(ctx *RunContext, triggerID, token, text, dataJSON string) (*flashduty.AutomationFireAPITriggerResponse, error) {
 	body, err := genAssembleBody(dataJSON, func(body map[string]any) error {
 		if ctx.Cmd.Flags().Changed("text") {
 			body["text"] = text
 		}
-		if ctx.Cmd.Flags().Changed("dedup-key") {
-			body["dedup_key"] = dedupKey
-		}
 		return nil
 	})
 	if err != nil {

internal/cli/automation_test.go

@@ -124,17 +124,15 @@ func TestAutomationFireSendsBearerToken(t *testing.T) {
 	saveAndResetGlobals(t)
 	stub := newGFStub(t)
 	stub.data = map[string]any{
-		"rule_id":      "auto_123",
-		"run_id":       "run_123",
-		"status":       "queued",
-		"trigger_kind": "http_post",
+		"type":        "routine_fire",
+		"session_id":  "sess_123",
+		"session_url": "/safari/session/sess_123",
 	}
 
 	_, err := execCommand(
 		"automation", "fire", "auttrig_123",
 		"--token", "token-123",
 		"--text", "manual test",
-		"--dedup-key", "once",
 		"--json",
 	)
 	if err != nil {
@@ -147,7 +145,20 @@ func TestAutomationFireSendsBearerToken(t *testing.T) {
 		t.Fatalf("[automation-fire] authorization = %q", stub.lastAuthorization)
 	}
 	assertBody(t, stub.lastBody, "text", "manual test")
-	assertBody(t, stub.lastBody, "dedup_key", "once")
+}
+
+func TestAutomationFireDoesNotExposeIgnoredDedupKey(t *testing.T) {
+	saveAndResetGlobals(t)
+	newGFStub(t)
+
+	_, err := execCommand(
+		"automation", "fire", "auttrig_123",
+		"--token", "token-123",
+		"--dedup-key", "once",
+	)
+	if err == nil || !strings.Contains(err.Error(), "unknown flag: --dedup-key") {
+		t.Fatalf("expected dedup-key to be rejected, got %v", err)
+	}
 }
 
 func TestSafariAutomationTriggerFirePathCommand(t *testing.T) {

skills/flashduty/reference/automation.md

@@ -97,11 +97,10 @@ fduty automation delete <rule-id> --force
 fduty automation fire <trigger-id> \
   --token "$FLASHDUTY_AUTOMATION_TRIGGER_TOKEN" \
   --text "manual validation run" \
-  --dedup-key "manual-$(date +%Y%m%d%H%M)" \
   --output-format toon
 ```
 
-`--dedup-key` makes retries idempotent for the same trigger. Do not invent a token. If it is missing, rotate the trigger token through `update` or ask the user to provide it through their secure shell/environment, not in chat.
+The trigger API has no idempotency key: retry only when the failed call is known not to have reached the server. Do not invent a token. If it is missing, rotate the trigger token through `update` or ask the user to provide it through their secure shell/environment, not in chat.
 
 <!-- GENERATED:automation START · 由 fduty __dump-commands 同步 · 勿手改 fence 内 -->
 
@@ -127,7 +126,6 @@ Delete an Automation
 
 ### fire <trigger_id>
 Fire an Automation HTTP POST trigger
-- `--dedup-key` string
 - `--text` string
 - `--token` string