From 773782271cc6014b5ab454e27a619ff71f2b51ac Mon Sep 17 00:00:00 2001 From: Julian Ostarek Date: Fri, 23 Oct 2026 19:40:32 +0200 Subject: [PATCH] Correct which settings apply without `hyper.settings.client` The transport is a `hyper.settings.client` edit too, so on a deployment of hyper.video without it, the transport step fails like the other settings steps. Only the microphone, camera and screen share steps apply, and the participant connects with that deployment's default transport. --- browser/src/participant/frontend/core.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/browser/src/participant/frontend/core.rs b/browser/src/participant/frontend/core.rs index b893262..631a5e9 100644 --- a/browser/src/participant/frontend/core.rs +++ b/browser/src/participant/frontend/core.rs @@ -133,9 +133,10 @@ impl ParticipantInner { /// Applies the participant's launch settings, each on its own. /// - /// A step that fails is logged, and the steps after it still apply. So on a deployment of hyper.video without - /// `hyper.settings.client`, where every settings edit fails, the transport and the microphone and camera state - /// still apply. + /// A step that fails is logged, and the steps after it still apply. On a deployment of hyper.video without + /// `hyper.settings.client`, every settings edit fails, the transport's included. Only the microphone, camera and + /// screen share steps then apply, because they click the web app's buttons. The participant connects with that + /// deployment's default transport. async fn apply_all_settings(&self, in_lobby: bool) { let settings = &self.context.launch_spec.settings; let driver = self.context.driver.as_ref();