From 78d1a5a2d2d561da283cbf83ca4a142501a254fd Mon Sep 17 00:00:00 2001 From: Alex Lay Date: Wed, 23 Sep 2026 16:58:16 +0100 Subject: [PATCH 1/2] Consolidate approved experiments config for new auth styling --- .../ra/approved-experiments/base/deployment.yaml | 9 +++++++++ .../overlays/dev/deployment.yaml | 14 -------------- .../overlays/prod/deployment.yaml | 11 ----------- 3 files changed, 9 insertions(+), 25 deletions(-) diff --git a/components/ra/approved-experiments/base/deployment.yaml b/components/ra/approved-experiments/base/deployment.yaml index 5a7228386..8fe4e7812 100644 --- a/components/ra/approved-experiments/base/deployment.yaml +++ b/components/ra/approved-experiments/base/deployment.yaml @@ -29,6 +29,9 @@ spec: - name: common-views mountPath: "/app/build/common-views" readOnly: true + - name: common-public + mountPath: "/app/build/common-public" + readOnly: true - name: approved-experiments-filters mountPath: /app/filters.json subPath: filters.json @@ -41,6 +44,12 @@ spec: imagePullSecrets: - name: registry-creds volumes: + - name: common-views + configMap: + name: common-pug-views-2026 + - name: common-public + configMap: + name: common-pug-public-2026 - name: approved-experiments-filters configMap: name: approved-experiments-filters diff --git a/components/ra/approved-experiments/overlays/dev/deployment.yaml b/components/ra/approved-experiments/overlays/dev/deployment.yaml index 93e601c5f..bb378a8d2 100644 --- a/components/ra/approved-experiments/overlays/dev/deployment.yaml +++ b/components/ra/approved-experiments/overlays/dev/deployment.yaml @@ -8,17 +8,3 @@ spec: containers: - name: approved-experiments image: ghcr.io/isisbusapps/approved-experiments@sha256:8743e1c4f139fd2203ca263fb2c0c7e60509b4120a97a44bfb0a9823ae9fb7d8 - envFrom: - - secretRef: - name: approved-experiments - volumeMounts: - - name: common-public - mountPath: "/app/build/common-public" - readOnly: true - volumes: - - name: common-views - configMap: - name: common-pug-views-2026 - - name: common-public - configMap: - name: common-pug-public-2026 diff --git a/components/ra/approved-experiments/overlays/prod/deployment.yaml b/components/ra/approved-experiments/overlays/prod/deployment.yaml index 97f0a419e..f63dda430 100644 --- a/components/ra/approved-experiments/overlays/prod/deployment.yaml +++ b/components/ra/approved-experiments/overlays/prod/deployment.yaml @@ -8,14 +8,3 @@ spec: containers: - name: approved-experiments image: ghcr.io/isisbusapps/approved-experiments:1.8.1 - volumeMounts: - - name: common-js - mountPath: "/app/build/common-public/js" - readOnly: true - volumes: - - name: common-views - configMap: - name: common-pug-views - - name: common-js - configMap: - name: common-pug-content-js From 9b6de43bdd10fbde523271d8cd034e5e035f355f Mon Sep 17 00:00:00 2001 From: Alex Lay Date: Wed, 23 Sep 2026 17:34:05 +0100 Subject: [PATCH 2/2] Add note on updating k8s config to the release PR template --- .github/workflows/create-release-pr.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/create-release-pr.yaml b/.github/workflows/create-release-pr.yaml index 1efc1aef7..c2c94f473 100644 --- a/.github/workflows/create-release-pr.yaml +++ b/.github/workflows/create-release-pr.yaml @@ -64,6 +64,7 @@ jobs: ### Review Checklist - [ ] Image built and pushed successfully - [ ] Source changes reviewed and approved + - [ ] Any prod kubernetes config updates applied to this PR --- **Merging this PR will trigger ArgoCD to sync the new image.**"