From 235826d7fa064bebd295dcbb82198c80f7e6f55b Mon Sep 17 00:00:00 2001 From: Tejadhith Sankar Date: Tue, 7 Jul 2026 17:36:58 +0000 Subject: [PATCH 1/3] Update HolisticTraceAnalysis dependency to the traceinsight package --- .github/workflows/end_to_end_tests.yml | 7 +------ .github/workflows/python_tests.yml | 7 +------ USER_GUIDE.md | 9 ++------- pyproject.toml | 2 +- 4 files changed, 5 insertions(+), 20 deletions(-) diff --git a/.github/workflows/end_to_end_tests.yml b/.github/workflows/end_to_end_tests.yml index fcddc117c..7fe4d27f9 100644 --- a/.github/workflows/end_to_end_tests.yml +++ b/.github/workflows/end_to_end_tests.yml @@ -28,12 +28,7 @@ jobs: - name: Install HTA run: | - git clone https://github.com/facebookresearch/HolisticTraceAnalysis.git - cd HolisticTraceAnalysis - git checkout d731cc2e2249976c97129d409a83bd53d93051f6 - git submodule update --init - pip install -r requirements.txt - pip install -e . + pip install traceinsight - name: Test chakra_trace_link Without Arguments run: | diff --git a/.github/workflows/python_tests.yml b/.github/workflows/python_tests.yml index a44a2e77f..602176ac7 100644 --- a/.github/workflows/python_tests.yml +++ b/.github/workflows/python_tests.yml @@ -28,12 +28,7 @@ jobs: - name: Install HTA run: | - git clone https://github.com/facebookresearch/HolisticTraceAnalysis.git - cd HolisticTraceAnalysis - git checkout d731cc2e2249976c97129d409a83bd53d93051f6 - git submodule update --init - pip install -r requirements.txt - pip install -e . + pip install traceinsight - name: Install Dependencies run: | diff --git a/USER_GUIDE.md b/USER_GUIDE.md index 164aaeb61..c2c409bd2 100644 --- a/USER_GUIDE.md +++ b/USER_GUIDE.md @@ -36,15 +36,10 @@ $ pip install . ``` ### Step 4: Install Holistic Trace Analysis -Installing Holistic Trace Analysis is necessary for Trace link. +Installing Holistic Trace Analysis (published on PyPI as `traceinsight`) is necessary for Trace link. ```bash -$ git clone https://github.com/facebookresearch/HolisticTraceAnalysis.git -$ cd HolisticTraceAnalysis -$ git checkout d731cc2e2249976c97129d409a83bd53d93051f6 -$ git submodule update --init -$ pip install -r requirements.txt -$ pip install -e . +$ pip install traceinsight ``` ### Step 5: Uninstalling Chakra diff --git a/pyproject.toml b/pyproject.toml index 99193c03e..412d93a55 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -19,7 +19,7 @@ dependencies = [ "graphviz", "networkx", "pydot", - "HolisticTraceAnalysis @ git+https://github.com/facebookresearch/HolisticTraceAnalysis.git@d731cc2e2249976c97129d409a83bd53d93051f6" + "traceinsight" ] [project.urls] From b1ed8fc1d6d71f1ad1afcf02f9d7731cdc930c3c Mon Sep 17 00:00:00 2001 From: mihncalo Date: Mon, 26 Oct 2026 10:58:19 +0200 Subject: [PATCH 2/3] Addressed comments left on PR --- .github/workflows/end_to_end_tests.yml | 4 ---- .github/workflows/python_tests.yml | 4 ---- USER_GUIDE.md | 9 +-------- pyproject.toml | 3 ++- 4 files changed, 3 insertions(+), 17 deletions(-) diff --git a/.github/workflows/end_to_end_tests.yml b/.github/workflows/end_to_end_tests.yml index 7fe4d27f9..4b8edb2b7 100644 --- a/.github/workflows/end_to_end_tests.yml +++ b/.github/workflows/end_to_end_tests.yml @@ -26,10 +26,6 @@ jobs: git checkout 7b19f586dd8b267333114992833a0d7e0d601630 pip install . - - name: Install HTA - run: | - pip install traceinsight - - name: Test chakra_trace_link Without Arguments run: | chakra_trace_link || [ $? -eq 2 ] diff --git a/.github/workflows/python_tests.yml b/.github/workflows/python_tests.yml index 602176ac7..250cd7e01 100644 --- a/.github/workflows/python_tests.yml +++ b/.github/workflows/python_tests.yml @@ -26,10 +26,6 @@ jobs: git checkout 7b19f586dd8b267333114992833a0d7e0d601630 pip install . - - name: Install HTA - run: | - pip install traceinsight - - name: Install Dependencies run: | pip install -r requirements-dev.txt diff --git a/USER_GUIDE.md b/USER_GUIDE.md index c2c409bd2..15bbb99e2 100644 --- a/USER_GUIDE.md +++ b/USER_GUIDE.md @@ -35,14 +35,7 @@ $ git checkout 7b19f586dd8b267333114992833a0d7e0d601630 $ pip install . ``` -### Step 4: Install Holistic Trace Analysis -Installing Holistic Trace Analysis (published on PyPI as `traceinsight`) is necessary for Trace link. - -```bash -$ pip install traceinsight -``` - -### Step 5: Uninstalling Chakra +### Step 4: Uninstalling Chakra To uninstall Chakra, use the following command within the virtual environment. ```bash diff --git a/pyproject.toml b/pyproject.toml index 412d93a55..f7e626ca2 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -19,7 +19,8 @@ dependencies = [ "graphviz", "networkx", "pydot", - "traceinsight" + "pandas<=2.3.3", + "traceinsight" # This is HTA ] [project.urls] From 2f11f0c7f66ae55a740044f4cf3cf03bdb37ed4b Mon Sep 17 00:00:00 2001 From: mihncalo Date: Mon, 26 Oct 2026 12:57:46 +0200 Subject: [PATCH 3/3] Changed python version in workflows from 3.10.14 to 3.10 --- .github/workflows/end_to_end_tests.yml | 2 +- .github/workflows/python_lint.yml | 2 +- .github/workflows/python_tests.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/end_to_end_tests.yml b/.github/workflows/end_to_end_tests.yml index 4b8edb2b7..a1523240d 100644 --- a/.github/workflows/end_to_end_tests.yml +++ b/.github/workflows/end_to_end_tests.yml @@ -13,7 +13,7 @@ jobs: - name: Setup Python Environment uses: actions/setup-python@v2 with: - python-version: '3.10.14' + python-version: '3.10' - name: Install Chakra run: | diff --git a/.github/workflows/python_lint.yml b/.github/workflows/python_lint.yml index 972bd09c6..f31cacfce 100644 --- a/.github/workflows/python_lint.yml +++ b/.github/workflows/python_lint.yml @@ -13,7 +13,7 @@ jobs: - name: Setup Python Environment uses: actions/setup-python@v2 with: - python-version: '3.10.14' + python-version: '3.10' - name: Install Dependencies run: | diff --git a/.github/workflows/python_tests.yml b/.github/workflows/python_tests.yml index 250cd7e01..dfa17b23c 100644 --- a/.github/workflows/python_tests.yml +++ b/.github/workflows/python_tests.yml @@ -13,7 +13,7 @@ jobs: - name: Setup Python Environment uses: actions/setup-python@v2 with: - python-version: '3.10.14' + python-version: '3.10' - name: Install Chakra run: |