From e6dc0e9313c4bbdd4ad5e96e5716dd147f9dea83 Mon Sep 17 00:00:00 2001 From: Jesper Terkelsen Date: Thu, 3 Sep 2026 12:57:16 +0200 Subject: [PATCH] feat: forward jira-project-blacklist in kotlin deploy workflows deploy-kotlin.yml and deploy-kotlin-v2.yml now pass jira-project-blacklist: ${{ vars.CHANGELOG_JIRA_PROJECT_BLACKLIST }} to changelog-cli-action, so tickets whose JIRA project key is in the list are skipped when commenting on JIRA; other tickets in the same release are still commented on. Reusable workflows can read the vars context, so every service deploying through these workflows inherits the central Actions variable with no per-repo change. Depends on monta-app/changelog-cli-action#97 (the jira-project-blacklist input) and monta-app/changelog-cli#298 (the CLI reading the env var). Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/deploy-kotlin-v2.yml | 1 + .github/workflows/deploy-kotlin.yml | 1 + CLAUDE.md | 3 +++ 3 files changed, 5 insertions(+) diff --git a/.github/workflows/deploy-kotlin-v2.yml b/.github/workflows/deploy-kotlin-v2.yml index da3a519..521d83b 100644 --- a/.github/workflows/deploy-kotlin-v2.yml +++ b/.github/workflows/deploy-kotlin-v2.yml @@ -346,5 +346,6 @@ jobs: deployment-url: ${{ needs.deploy.outputs.deployment-url }} comment-on-prs: ${{ inputs.comment-on-prs }} comment-on-jira: ${{ inputs.comment-on-jira }} + jira-project-blacklist: ${{ vars.CHANGELOG_JIRA_PROJECT_BLACKLIST }} monitoring-urls: ${{ inputs.changelog-monitoring-urls }} release-notify-channel: ${{ inputs.changelog-release-notify-channel }} diff --git a/.github/workflows/deploy-kotlin.yml b/.github/workflows/deploy-kotlin.yml index 0726a88..6e93ad5 100644 --- a/.github/workflows/deploy-kotlin.yml +++ b/.github/workflows/deploy-kotlin.yml @@ -331,5 +331,6 @@ jobs: deployment-url: ${{ needs.deploy.outputs.deployment-url }} comment-on-prs: ${{ inputs.comment-on-prs }} comment-on-jira: ${{ inputs.comment-on-jira }} + jira-project-blacklist: ${{ vars.CHANGELOG_JIRA_PROJECT_BLACKLIST }} monitoring-urls: ${{ inputs.changelog-monitoring-urls }} release-notify-channel: ${{ inputs.changelog-release-notify-channel }} diff --git a/CLAUDE.md b/CLAUDE.md index 7866b13..a04fd70 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -5,6 +5,9 @@ - **Latest SHA**: b076da4 (check for newer commits) - **Changes**: Added opt-in `resource-name`/`resource-kind`/`resource-namespace` inputs to `argocd-wait-sync` +## Recent Changes (2026-09-03) +1. **Changelog JIRA project blacklist**: `deploy-kotlin.yml` and `deploy-kotlin-v2.yml` now forward `jira-project-blacklist: ${{ vars.CHANGELOG_JIRA_PROJECT_BLACKLIST }}` to `changelog-cli-action`. Tickets whose JIRA project key is in the list are skipped when commenting on JIRA; other tickets in the same release are still commented on. The list is maintained centrally as an org- or repo-level Actions variable `CHANGELOG_JIRA_PROJECT_BLACKLIST` - reusable workflows can read the `vars` context, so every service deploying through these workflows picks it up with no per-repo change. Requires changelog-cli-action to expose the `jira-project-blacklist` input (monta-app/changelog-cli-action#97) and a changelog-cli release that reads `CHANGELOG_JIRA_PROJECT_BLACKLIST` (monta-app/changelog-cli#298). + ## Recent Changes (2026-08-28) 1. **`argocd-wait-sync` resource-level tracking**: Added opt-in `resource-name` (+ `resource-kind`, default `Deployment`, and `resource-namespace`) inputs to `.github/actions/argocd-wait-sync`. When `resource-name` is set, completion and fail-fast (Degraded/Missing) are judged on that specific resource in `.status.resources[]` instead of the app's aggregate `.status.health`, so an app that manages multiple independently-owned resources (e.g. a shared/monorepo-style app with several Deployments) won't falsely pass before your resource rolls out, or block forever because an unrelated resource in the same app is Degraded/Progressing. Empty `resource-name` (default) is fully backwards compatible - identical behavior to before. `wait-sync.sh` gains a `TARGET_HEALTHY` variable that is the single source of truth for "is the thing we care about healthy" (the tracked resource when set, otherwise app aggregate health), used by both phases of the state machine. `test-local.sh` gains matching `--resource-name`/`--resource-kind`/`--resource-namespace` flags.