Skip to content

Exceptions thrown during the terminate() event dispatching should not cause the slave to crash #175

Description

@acasademont

During the Google outage today one function that sends some logs to Google PubSub in the Syfmony terminate() event failed, causing the whole slave to go down, even if the response had been correctly generated in the controller. The terminate event is used in Symfony to do some after-request processing, but it should not interfere with the response.

The easy fix would be to catch any exception thrown in the handling of the terminate event and log it.

The better fix would be to execute the terminate event after sending the response promise to the client, if not, a slow terminate event handler would cause the response to also be slowed down, in contrast of what happens in a normal PHP-FPM response.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions