diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2af98ce549..63a9654310 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,11 @@ Each release's page on GitHub has its notes and measurements. See [the 1.0.0 rel
## Unreleased
+- Drama speech accepts dialogue tags `<|speaker:0|>` through `<|speaker:15|>` in requests and reference transcripts. Long-form continuations, history and redraws preserve the active speaker; untagged requests still default to speaker 0. See [dialogue speakers](docs/drama-voices.md#dialogue-speakers).
+
+- speech: Drama requests accept `temperature`, `top_p`, `top_k` (1 through 64) and exact unsigned 64-bit `seed`. Whole replies, streams, references, guidance and long-form segments retain the requested settings; omitted or null fields keep existing defaults. Explicit seeds advance by each segment's attempt number on redraws. See [speech sampling](docs/speech-sampling.md).
+
+- speech: long-form Drama 3 splits preserve complete special tokens, bracketed cues and nested paired direction tags, even when one span exceeds the character target. CJK punctuation supplies sentence and clause boundaries without requiring spaces, and topic-shift markers inside protected spans cannot split them. Existing input, prompt-token, segment and frame limits still apply ([docs](docs/drama-voices.md#long-form-replies)).
- speech: Drama 3's DAC activation planes are bounded by the decode chunk and causal halo rather than the utterance limit. QKV history retains absolute frame indexing and attention tile boundaries. `zig build drama-codec-chunk` builds `oracle/bin/tf-drama-codec-chunk CHECKPOINT`, a GPU byte-equality gate against the original full-plane layout; the trace diagnostic explicitly retains that reference layout.
- speech: `--silence-mid-s S` (CUDA; 0 for off, or 3 to below 10; default 0) ends a Drama 3 synthesis as `silence` when its end of speech comes inside S seconds or more below -40 dBFS after 1 s or more voiced: a reply that fell silent mid-way and stopped there, its last words never spoken, as one 4-bit take did after a 9.0 s hole. Holes that recover are left alone, since a client that shortens pauses never plays them, and a reply the frame cap stops is not judged. Such a draw is redrawn under the silence redraws' rules, a long-form segment in place, and whole replies count the draws it ended in `X-Silence-Mid-Trips`. Replayed at S = 3 over 2272 draws in the engine's frame accounting, it ended 15 of the 2047 that the 10 s rule left alone; all 8 with a text to judge by had lost words, and none of them had spoken in full. With S = 0 replies are as before ([docs](docs/drama-voices.md#holes-that-end-a-reply))
- speech: `--register-redraw-st R` (0 to 24, default 0: off) draws a whole Drama 3 reply once more when a phrase after the first opens R semitones or more above the median of its other phrase openings with `--register-redraw-high F` percent (default 20) of its voiced frames over `--register-high-hz H` (default 210), the thin, high phrase that sounds stitched into a reply. The redraw starts only if t + d fits the silence redraws' budget and `X-Deadline-S`, and the draw with the smaller jump is sent, never one that ended in silence or short; a tie keeps the first. Replies carry `X-Register-Trip` and `X-Register-Redraws`; streams and multi-segment long-form replies are not measured, and a draw with a NaN or infinite sample fails the reply before any measure. The measure ports the numpy one it was calibrated with: on 77 takes it decided every trip the same way at R = 4, F = 20, H = 210 (evidence on that corpus, not exact parity at every threshold; those settings tripped 6 of 51 replies of a day's use), at about 1.2 ms per second of audio. With R = 0 replies are as before ([docs](docs/drama-voices.md#register-redraws))
diff --git a/README.md b/README.md
index d77b9f9f3e..0b89e4ef88 100644
--- a/README.md
+++ b/README.md
@@ -30,6 +30,9 @@ The API listens at `http://127.0.0.1:8080/v1` by default.
It serves OpenAI chat completions, completions and Responses, plus Anthropic Messages.
Use the model ID returned by `/v1/models`, or set one with `--name`.
+Drama speech at `/v1/audio/speech` accepts [request sampling controls](docs/speech-sampling.md)
+for temperature, top-p, top-k and exact 64-bit seeds, including streamed and long-form replies.
+
```sh
curl -fsS http://127.0.0.1:8080/v1/chat/completions \
-H 'Content-Type: application/json' \
diff --git a/docs/drama-voices.md b/docs/drama-voices.md
index e27e7e70e1..9fce2dac51 100644
--- a/docs/drama-voices.md
+++ b/docs/drama-voices.md
@@ -117,12 +117,26 @@ tensorfold serve DRAMA3_DIR --voices voices/ --default-voice NAME
```
`references: [{"text": ..., "vq_codes": [[...], ...]}]` sends references inline, as the reference accepts them. A named voice's references follow the request's own references.
-Refusals carry the reference's messages, in its order.
+Apart from accepting speaker IDs 0 through 15, refusals carry the reference's messages, in its order.
Some refusals are the native server's own:
- Reference audio (`audio_path`, `ref_audio`, `audio`, `data`) is refused: encode it with the tool and send `vq_codes`.
- Unknown reference fields are refused, not dropped.
+## Dialogue speakers
+
+Input and reference transcripts accept canonical `<|speaker:N|>` tags with decimal IDs `0` through `15`. Untagged text defaults to speaker 0. Leading zeros, negative IDs, non-ASCII digits, incomplete tags and IDs above 15 are rejected.
+
+```json
+{"model": "drama-3", "input": "<|speaker:0|> Is the gate open? <|speaker:15|> Yes, come through. <|speaker:0|> Thank you.", "voice": "conversation"}
+```
+
+Use matching tags in the catalog entry's reference transcripts, or in inline `references`, to associate reference audio with the dialogue speakers. The HTTP `speaker` field remains an alias for the catalog name in `voice`; speaker IDs belong in text tags. All existing code, digest, attestation and prompt-budget checks still apply.
+
+Whole replies and PCM streams accept the same dialogue. With long-form enabled, a segment without a leading tag continues the last speaker from the preceding text, including across paragraph shifts. History references, guidance prompts and plain redraws retain that speaker. A new request starts with the usual speaker-0 default.
+
+The public [Drama 3 MLX prompt implementation](https://github.com/Sogni-AI/drama3-mlx/blob/ecc235039ccd5f982f66a6982184f57432354ab4/drama3_mlx/prompt.py) is a behavior reference for the speaker markers. This native change establishes prompt support; voice similarity and acoustic quality still require listening tests with suitable references.
+
## Expressiveness
The model card's documented controls are written in the input text:
@@ -177,7 +191,7 @@ With `--long-form`, each segment may use up to N frames, and a reply may use 600
tensorfold serve DRAMA3_DIR --voices voices/ --default-voice NAME --cfg-gamma 2
```
-On CUDA, `--cfg-gamma G` (0 for off, or 1 to 5; default 0) applies classifier-free guidance to a referenced prompt's semantic head. The main token of each frame is drawn from l_c + (G − 1)(l_c − l_u) instead of l_c: l_c are the logits of the prompt as sent (the voice's references, then the input), and l_u are those of the same turn as a plain prompt, the one the built-in voice gets. So the draw moves away from what the model says without the references. The mix covers all 4097 semantic logits, the end-of-speech logit included, so guidance also moves where a draw ends. It comes before the sampler, which is unchanged and not greedy: a draw seeded per request, at temperature 1, top-p 0.9 and top-k 30, with the repetition-aware redraw (RAS: a main token that repeats one of the last 16 frames' is replaced by a second draw at top-p 0.95). The tower, and with it codebooks 1 to 9, still reads the referenced prompt's hidden row.
+On CUDA, `--cfg-gamma G` (0 for off, or 1 to 5; default 0) applies classifier-free guidance to a referenced prompt's semantic head. The main token of each frame is drawn from l_c + (G − 1)(l_c − l_u) instead of l_c: l_c are the logits of the prompt as sent (the voice's references, then the input), and l_u are those of the same turn as a plain prompt, the one the built-in voice gets. So the draw moves away from what the model says without the references. The mix covers all 4097 semantic logits, the end-of-speech logit included, so guidance also moves where a draw ends. It comes before the native sampler, using the [request sampling controls](speech-sampling.md) (defaults: temperature 1, top-p 0.9 and top-k 30), with the repetition-aware redraw (RAS: a main token that repeats one of the last 16 frames' is replaced by a second draw at top-p 0.95). The tower, and with it codebooks 1 to 9, still reads the referenced prompt's hidden row.
- **The second sequence.** The engine keeps l_u in a second backbone sequence that shares the model's weights: 0.33 GB at context 8192 (the KV caches of the 10 attention layers and the states of the 30 DeltaNet layers). It prefills the plain prompt before the referenced one, and then reads every frame the referenced one reads. That is one more backbone run per frame, and the server's startup line gives the sequence's size.
- **`--cfg-every K`** (default 1) would run the second sequence only every K frames, reading the K frames in one pass, its last logits guiding the draws in between. Only K = 1 is accepted for now: tests check that a catch-up run reads every frame once and in order, but nothing has yet compared its logits with K runs one frame each, so the server refuses K > 1 at startup.
@@ -270,7 +284,7 @@ A reply can fall silent mid-way for less than 10 s and then end, its last senten
tensorfold serve DRAMA3_DIR --voices voices/ --silence-redraws 2 --silence-redraw-plain
```
-`--silence-redraws N` (0 to 8, default 0) draws a whole reply again when it trips, up to N times: when the guard ended it, or, with `--short-reply-ratio`, when it stopped far short of its text. A redraw keeps the request's voice and seeds with the server's salt plus k for the k-th redraw, so it is a different draw that is still deterministic. Salts overlap: with the same prompt, redraw k at salt s is the same draw as the first draw at salt s + k (`TENSORFOLD_SEED_SALT`), so a sweep over salts should leave N between the salts it compares.
+`--silence-redraws N` (0 to 8, default 0) draws a whole reply again when it trips, up to N times: when the guard ended it, or, with `--short-reply-ratio`, when it stopped far short of its text. A redraw keeps the request's voice and sampling controls. Without an explicit seed it uses the server's salt plus k for the k-th redraw; an explicit seed instead advances by k modulo 2^64. See [speech sampling](speech-sampling.md). Salts overlap: with the same prompt, redraw k at salt s is the same draw as the first draw at salt s + k (`TENSORFOLD_SEED_SALT`), so a sweep over salts should leave N between the salts it compares.
- **Deadline.** Each redraw starts only if it should end within the budget: the lower of the request's `X-Deadline-S` (seconds the client waits, counted from when the speech route takes the request, before it reads the body) and `--silence-redraw-budget-s` (default 120). After a draw that tripped (ended `silence`, or a short `stop`, below) at t seconds from receipt and took d seconds, the next one is started only if t + d ≤ budget, since a stalled draw's duration predicts the next one's. Otherwise the last draw is sent as it is, with its own `X-Finish-Reason`. For example, a client that allows 96 s for a 509-character reply gets a redraw after a trip at 17 s (17 + 17 = 34 ≤ 96). After a 50 s stall it gets none (50 + 50 = 100 > 96), so it receives the tripped reply within its deadline instead of a timeout. A redraw that finds the engine busy with another request waits for it only until the latest start that still fits (budget − d after receipt), then sends the tripped draw. The deadline therefore binds every start; only a draw already generating can run past it. `--silence-redraw-budget-s` and `--silence-redraw-plain` need `--silence-redraws` of 1 or more.
- **Plain redraws.** With `--silence-redraw-plain`, every redraw speaks the input without its cues: each `[sighs]`, `[laughs]`, `[small laugh]`, `[pause]` and `[hesitates]` becomes a space, then white space is collapsed to single spaces and trimmed (`done. [pause] Next` is spoken `done. Next`; `word [sighs].` is spoken `word .`). An input without one of those cues is redrawn as it is. A plain redraw never speaks the cues again: if nothing is left without them, or the cue-free text cannot be prompted, there is no redraw, the tripped draw is sent, and the log says why. The cues drove the trips measured: on texts that tripped the guard, a cue-free draw finished 14 of 14, a draw with the cues and a new seed 5 of 14.
@@ -304,22 +318,24 @@ tensorfold serve DRAMA3_DIR --voices voices/ --default-voice NAME --long-form
With `--long-form`, a speech input longer than `--long-form-chars` (default 500 code points) is spoken in segments instead of in one synthesis. Each segment hears the segments before it: the earlier segments' text and generated codes are added as references after the request's references and the voice's, with the latest last. This follows the way Fish's long-form inference keeps earlier segments in context.
-- **Segments.** The input is cut into the fewest segments that fit the limit, with cuts only at sentence ends (`.` `!` `?` `…` followed by white space, keeping closing quotes and brackets, and line breaks).
+- **Segments.** The input is cut into the fewest segments that fit the character target, with cuts at sentence ends (`.` `!` `?` `…` followed by white space; `。` `！` `？` `；` without needing white space), keeping closing quotes and brackets, and at line breaks.
- Among the cuts that give that many segments, the server picks the most balanced lengths, and prefers a cut where the text turns.
- The text turns at a blank line, after a question, or where the next sentence opens a new move: it starts with So, Okay, OK, Now, Right, Anyway, Also, Next, Finally, But or Here's, or with a number and "thing"/"things" (One thing, Two things, 3 things).
- A turn wins over a cut that is up to about 15% of a segment better balanced.
- - Only a sentence longer than the limit is cut inside, at `;` `:` `,`, then at spaces, then anywhere.
+ - Only a sentence longer than the target is cut inside, at `;` `:` `,` before white space or `，` `：` `、`, then at spaces, then between code points.
+ - A complete `<|...|>` token, balanced `[...]` cue or correctly nested `...` span stays whole. Simple tag names start with an ASCII letter and contain letters, digits, `_` or `-`; names match exactly, and attributes are not parsed. Nested spans stay with their outer span; adjacent controls remain separate. An unclosed or crossed delimiter is ordinary text, while complete spans inside or after it still stay whole.
+ - An indivisible span may exceed the character target; other text retains the target. Input, prompt-token, frame and segment-count limits still apply. The splitter preserves the original text and never inserts or reopens tags.
- **History.** `--long-form-history K` (0 to 3, default 1) sets how many earlier segments a segment hears. The oldest is dropped when the prompt would exceed the engine's prompt limit.
- **Joins.**
- **Pause.** At each join, the silence already there is measured: the end of one segment plus the start of the next, in 10 ms frames below -42 dBFS. Only the shortfall to the boundary's target is added, never cutting existing silence. Targets:
- - `.` or `!`: 0.42 s
+ - `.` `!` `。` `！` or `；`: 0.42 s
- `…` or `...`: 0.55 s
- a turn (a question, or a sentence opening a new move): 0.60 s
- a blank line: 0.70 s
- - a cut inside a sentence (at `,` `;` `:` or a space): 0.20 s
+ - a cut inside a sentence (at `,` `;` `:` `，` `：` `、` or a space): 0.20 s
- **Room tone.** The added pause is copied from the earlier segment's quietest 100 ms in its last second, played back and forth. It is digital silence when that segment has no quiet tail.
- **Level.** A segment whose speech level (the median dBFS of its frames at or above -42 dBFS) is more than 1.5 dB from the median of the earlier segments gets one constant gain. The gain brings it to 1.5 dB, is at most 3 dB either way, and never raises a peak past 0.99.
-- **Seeds.** Each segment's seed comes from its own prompt rows, as a single synthesis's does.
+- **Seeds.** Without an explicit request seed, each segment's seed comes from its own prompt rows, as a single synthesis's does. An explicit seed starts each segment's attempt count at zero; its redraws use seed + attempt modulo 2^64. Every segment keeps the same requested temperature, top-p and top-k; see [speech sampling](speech-sampling.md).
- **Limits.**
- More than 12 segments are refused up front.
- A reply may use 6000 frames in all; each segment gets at most what is left.
@@ -337,9 +353,9 @@ tensorfold serve DRAMA3_DIR --voices voices/ --default-voice NAME --long-form --
A client marks a topic shift with `¶` (U+00B6), sent as ` ¶ `. A caller's wrapper writes one for each blank line it collapses. With `--shift-pause-s T` (0 to 3 seconds, default 0: off; needs `--long-form`), the reply pauses for at least T seconds at each mark, and says where those pauses are.
-- **Marks.** A mark counts only after `.` `!` `?` or `…` (closing quotes and brackets may sit between), and only with words on both sides of it. Here a word means a Unicode letter or number (general category L or N, so `次へ`, `Été` and `２` count, while `！！！`, `×` and `€` do not), outside `[…]` and `<…>` controls, between the mark and the last cut and between it and the next mark. A cue may open the text after a mark (`done. ¶ [curious] Should I…`), but a mark followed by punctuation, symbols or cues alone does not count. Several marks in a row count as one. Every other mark is dropped, and the server logs how many. Every mark, with the white space after it, is removed before anything else reads the input. The tokenizer, the long-form history, a plain redraw's text and the short-reply rule's character count never see one.
+- **Marks.** A mark counts only after `.` `!` `?` `…` `。` `！` `？` or `；` (closing quotes and brackets may sit between), and only with words on both sides of it. Here a word means a Unicode letter or number (general category L or N, so `次へ`, `Été` and `２` count, while `！！！`, `×` and `€` do not), outside `[…]` and `<…>` controls, between the mark and the last cut and between it and the next mark. A cue may open the text after a mark (`done. ¶ [curious] Should I…`), but a mark followed by punctuation, symbols or cues alone does not count. Marks inside an indivisible control span do not force a cut. Several marks in a row count as one. Every other mark is dropped, and the server logs how many. Every mark, with the white space after it, is removed before anything else reads the input. The tokenizer, the long-form history, a plain redraw's text and the short-reply rule's character count never see one.
- **Cues that trail a sentence.** Put the mark after the sentence's end and before a cue that trails it: `nights in a row now. ¶ [small laugh] The calendar`. The cue then opens the next segment. Written after the cue (`now. [small laugh] ¶`), the mark follows `]`, not a sentence end, so it is dropped.
-- **Cuts.** Each mark that counts cuts a long-form segment there, even in an input short enough for one segment. The text between marks is split as long-form splits any input, and the segment cap still applies.
+- **Cuts.** Each mark that counts cuts a long-form segment there, even in an input short enough for one segment. The text between marks is split as long-form splits any input, including the indivisible-span exception to the character target.
- **Pauses.** At a mark's join, the silent 10 ms frames around the join (under -42 dBFS, counted on the reply's own grid from its first sample, as a client's pacing counts them) are made to last at least T seconds. Quiet already there counts, and is never cut. The fill is added, then measured in the audio as sent. If the crossfades or the grid leave it short, more room tone goes in its middle until it is long enough. The fill is room tone: the quietest silent 100 ms (but not digital silence, under -90 dBFS) of the earlier segment's last second. Failing that it comes from all audio earlier in the reply, then from the next segment. If none of these has one, it is noise at -65 dBFS, never zeros. Its samples are kept 6 dB under the floor, so every 10 ms of it is silent. The fill fades in from the earlier segment's last samples and out into the next segment's first samples, each over 15 ms at equal power. Both segments are mirrored at their seams, so neither segment's own audio changes.
- **`X-Pause-Spans: s1-e1,s2-e2,…`** lists one span per mark the reply reached, as sample offsets into the audio exactly as sent (start inclusive, end exclusive, ascending). A span runs from the start of the earlier segment's trailing quiet to the end of the next segment's leading quiet, fill included, and always contains the silent frames measured around the join, so it holds at least T seconds of them. With `stream: true` the spans come as a trailer, declared next to `X-Long-Form-Segments`. The header is absent when there are no spans.
- **Redraws.** Redraws work per segment as usual. The spans are measured on each segment's final take, so they always describe the audio delivered. Segments under 200 characters fall outside the short-reply rule, and only the silence guard covers them.
diff --git a/docs/speech-sampling.md b/docs/speech-sampling.md
new file mode 100644
index 0000000000..10f366ac3b
--- /dev/null
+++ b/docs/speech-sampling.md
@@ -0,0 +1,59 @@
+# Speech sampling
+
+`POST /v1/audio/speech` accepts these optional fields for Drama 3. Omission or
+`null` keeps the existing default for that field. They apply to WAV replies,
+whole PCM replies, streamed PCM and catalog voices.
+
+| Field | Accepted JSON value | Default |
+| --- | --- | --- |
+| `temperature` | A finite number at least 0, within the `f32` range. A positive value must remain positive when converted to `f32`. | `1` |
+| `top_p` | A finite number greater than 0 and at most 1, still greater than 0 after conversion to `f32`. | `0.9` |
+| `top_k` | An integer from 1 through 64. | `30` |
+| `seed` | An integer from 0 through 18446744073709551615. | The existing hash of the prompt and `TENSORFOLD_SEED_SALT`. |
+
+Numbers encoded as strings and booleans are refused. `top_k` and `seed` must
+use integer JSON syntax: `30.0` and `1e3` are refused. Seeds are parsed as exact
+64-bit unsigned integers, including values above 9007199254740991; clients
+whose JSON number type loses precision must preserve the integer when encoding
+the request. Invalid fields return HTTP 400 before submission to the engine.
+
+For `temperature` and `top_p`, the JSON parser first produces an `f64` value;
+the bounds above apply to that value and its conversion to `f32`. Extremely
+small floating literals such as `1e-400` and `-1e-400` already become zero in
+that parser, so both request temperature 0; they are refused for `top_p`.
+A positive parsed value such as `1e-100` is refused if it becomes zero only
+when narrowed to `f32`.
+
+```sh
+curl http://127.0.0.1:8080/v1/audio/speech \
+ -H 'Content-Type: application/json' \
+ -d '{"model":"local-model","input":"Hello there.","temperature":0.8,"top_p":0.9,"top_k":30,"seed":42}' \
+ --output speech.wav
+```
+
+The route passes these settings to the existing native sampler, including its
+repetition aware sampling (RAS) behavior. Matching fields and seeds do not
+promise identical audio across backends or checkpoints. The HTTP limit of 64
+candidates is shared with the Metal recipe.
+
+An explicit `seed` is used exactly for the first take. If configured
+[speech redraws](drama-voices.md#silence-redraws) admit another take, its seed is the original
+seed plus the take's attempt number (1, 2, ...), wrapping modulo 2^64. This
+number includes both silence and register redraws. All takes keep the requested
+sampling values, including when controls are stripped or a reference prompt is
+rebuilt. With no seed, the existing prompt hash and server salt plus attempt
+number are unchanged. Streams keep their existing no-redraw behavior.
+
+For a long-form reply, each segment starts its own attempt count at zero: its
+first take uses the explicit seed, and its redraws use seed + attempt modulo
+2^64. Sampling values stay the same across segments, reference carry-over,
+control stripping and guidance. Omitted seeds retain each segment's existing
+prompt hash and server salt plus that segment's attempt number.
+
+Seed selection is deterministic. The final take can still change if timing or
+request deadlines admit a different number of redraws.
+
+The API design references the public
+[Sogni-AI/drama3-mlx generation interface](https://github.com/Sogni-AI/drama3-mlx/blob/ecc235039ccd5f982f66a6982184f57432354ab4/drama3_mlx/model.py#L79).
+TensorFold's parsing and request propagation are an independent implementation;
+this does not change the native sampling algorithms.
diff --git a/zig/src/server/cli_speech.zig b/zig/src/server/cli_speech.zig
index a60cac3545..113c6f1e58 100644
--- a/zig/src/server/cli_speech.zig
+++ b/zig/src/server/cli_speech.zig
@@ -47,7 +47,7 @@ pub fn flag(a: Allocator, out: *cli.Args, name: []const u8, v: []const u8, u: *c
const is = std.mem.eql;
if (is(u8, name, "--voices")) out.voices = v else if (is(u8, name, "--default-voice")) out.default_voice = v else if (is(u8, name, "--long-form")) out.long_form = true else if (is(u8, name, "--long-form-chars")) {
const n = try cli.int(u, a, name, v);
- if (n < 1 or n > 4096) return cli.fail(u, a, "argument --long-form-chars: characters a segment holds, from 1 to 4096: '{s}'", .{v});
+ if (n < 1 or n > 4096) return cli.fail(u, a, "argument --long-form-chars: target characters a segment holds, from 1 to 4096: '{s}'", .{v});
out.long_form_chars = @intCast(n);
out.long_form_set = true;
} else if (is(u8, name, "--long-form-history")) {
diff --git a/zig/src/server/drama_joins.zig b/zig/src/server/drama_joins.zig
index 912eaf2a6e..57ee88ff53 100644
--- a/zig/src/server/drama_joins.zig
+++ b/zig/src/server/drama_joins.zig
@@ -39,16 +39,23 @@ pub fn boundary(left: []const u8, gap: []const u8, right: []const u8) Boundary {
const at = lastStart(left[0..end]);
const cp = std.unicode.utf8Decode(left[at..end]) catch break;
switch (cp) {
- '"', '\'', ')', ']', 0x201d, 0x2019, 0xbb => end = at,
+ '"', '\'', ')', ']', 0x201d, 0x2019, 0xbb, 0x300d, 0x300f, 0x3011, 0xff09 => end = at,
0x2026 => return .ellipsis,
'.' => return if (std.mem.endsWith(u8, left[0..end], "...")) .ellipsis else .sentence,
- '!' => return .sentence,
+ '!', 0x3002, 0xff01, 0xff1b => return .sentence,
else => break,
}
}
return if (std.mem.indexOfAny(u8, gap, "\n\r") != null) .sentence else .clause;
}
+test "CJK punctuation selects sentence, question and clause joins" {
+ for ([_][]const u8{ "\u{4f60}\u{597d}\u{3002}", "\u{4f60}\u{597d}\u{ff01}\u{300d}", "\u{4f60}\u{597d}\u{ff1b}" }) |left|
+ try std.testing.expectEqual(Boundary.sentence, boundary(left, "", "\u{4e16}\u{754c}"));
+ try std.testing.expectEqual(Boundary.topic, boundary("\u{4f60}\u{597d}\u{ff1f}\u{300d}", "", "\u{4e16}\u{754c}"));
+ try std.testing.expectEqual(Boundary.clause, boundary("\u{4f60}\u{597d}\u{ff0c}", "", "\u{4e16}\u{754c}"));
+}
+
/// The start of the last code point of valid UTF-8 `text`.
fn lastStart(text: []const u8) usize {
var at = text.len - 1;
diff --git a/zig/src/server/drama_long.zig b/zig/src/server/drama_long.zig
index 77d0aff1e0..e87207bc51 100644
--- a/zig/src/server/drama_long.zig
+++ b/zig/src/server/drama_long.zig
@@ -1,10 +1,11 @@
//! Drama 3 long-form speech: an input cut at sentence ends into segments, each spoken after hearing those before it.
const std = @import("std");
const drama_prompt = @import("drama_prompt.zig");
+const drama_spans = @import("drama_spans.zig");
const Reference = drama_prompt.Reference;
const Allocator = std.mem.Allocator;
-/// --long-form's segments of at most `chars`, each hearing `history` before it; --shift-pause-s: seconds at each `¶`.
+/// --long-form's character target; indivisible controls may exceed it. `history` sets earlier segments heard.
pub const Options = struct { chars: u32 = 500, history: u8 = 1, shift_pause_s: f32 = 0 };
pub const max_history = 3;
@@ -14,13 +15,17 @@ pub const max_frames = 6000;
/// Where text may be cut, coarsest first.
const Level = enum { sentence, clause, space, any };
+const Protection = struct { base: [*]const u8, spans: []const drama_spans.Span };
-/// The input's segments: the fewest that fit `chars`, balanced, ending where the text turns (see `balance`).
+/// Balanced slices targeting `chars`, without cutting controls; an oversized control stays whole in its own slice.
pub fn split(a: Allocator, input: []const u8, chars: u32) Allocator.Error![]const []const u8 {
+ const spans = try drama_spans.collect(a, input);
+ defer a.free(spans);
+ const protection: Protection = .{ .base = input.ptr, .spans = spans };
var out: std.ArrayList([]const u8) = .empty;
var run: std.ArrayList([]const u8) = .empty;
var at: usize = 0;
- while (nextPiece(input, &at, .sentence, chars)) |piece| {
+ while (nextPiece(input, &at, .sentence, chars, protection)) |piece| {
if (count(piece) <= chars) {
try run.append(a, piece);
continue;
@@ -28,7 +33,7 @@ pub fn split(a: Allocator, input: []const u8, chars: u32) Allocator.Error![]cons
try balance(a, &out, run.items, chars);
run.clearRetainingCapacity();
// a sentence over `chars` is cut at ``; : ,``, then spaces, then anywhere, into segments of its own
- try pack(a, &out, piece, .clause, chars);
+ try pack(a, &out, piece, .clause, chars, protection);
}
try balance(a, &out, run.items, chars);
return out.items;
@@ -106,15 +111,17 @@ pub fn gapBetween(left: []const u8, right: []const u8) []const u8 {
return left.ptr[left.len .. @intFromPtr(right.ptr) - @intFromPtr(left.ptr)];
}
-/// Packs `text`'s pieces at `level` greedily into segments of at most `chars`; a longer piece is cut one level finer.
-fn pack(a: Allocator, out: *std.ArrayList([]const u8), text: []const u8, level: Level, chars: u32) Allocator.Error!void {
+/// Packs free text within `chars`; the final level emits an oversized protected atom without splitting it.
+fn pack(a: Allocator, out: *std.ArrayList([]const u8), text: []const u8, level: Level, chars: u32, protection: Protection) Allocator.Error!void {
var current: ?[]const u8 = null;
var at: usize = 0;
- while (nextPiece(text, &at, level, chars)) |piece| {
+ while (nextPiece(text, &at, level, chars, protection)) |piece| {
if (count(piece) > chars) {
if (current) |c| try out.append(a, c);
current = null;
- try pack(a, out, piece, @fromBackingInt(@intCast(@backingInt(level) + 1)), chars);
+ if (level == .any) {
+ try out.append(a, piece);
+ } else try pack(a, out, piece, @fromBackingInt(@intCast(@backingInt(level) + 1)), chars, protection);
} else if (current) |c| {
const joined = c.ptr[0 .. @intFromPtr(piece.ptr) + piece.len - @intFromPtr(c.ptr)];
if (count(joined) <= chars) {
@@ -139,10 +146,11 @@ pub fn turns(left: []const u8, gap: []const u8, right: []const u8) bool {
/// `text` ends in a question mark, closing quotes and brackets aside.
pub fn question(text: []const u8) bool {
- return lastMark(text) == '?';
+ const cp = lastMark(text);
+ return cp == '?' or cp == 0xff1f;
}
-/// `text`, trailing white space, closing quotes and brackets aside, ends in `.` `!` `?` or `…`.
+/// `text`, trailing white space and closing quotes/brackets aside, ends in ASCII or CJK sentence punctuation.
pub fn endsSentence(text: []const u8) bool {
return terminal(lastMark(trim(text)) orelse return false);
}
@@ -200,14 +208,18 @@ fn count(text: []const u8) usize {
return std.unicode.utf8CountCodepoints(text) catch unreachable;
}
-/// Ends a sentence when followed by white space or the end; closing quotes and brackets stay with it.
+/// ASCII or CJK sentence punctuation; ASCII additionally needs white space or the end at the split point.
fn terminal(cp: u21) bool {
- return cp == '.' or cp == '!' or cp == '?' or cp == 0x2026;
+ return cp == '.' or cp == '!' or cp == '?' or cp == 0x2026 or cjkTerminal(cp);
+}
+
+fn cjkTerminal(cp: u21) bool {
+ return cp == 0x3002 or cp == 0xff01 or cp == 0xff1f or cp == 0xff1b;
}
fn closer(cp: u21) bool {
return switch (cp) {
- '"', '\'', ')', ']', 0x201d, 0x2019, 0xbb => true,
+ '"', '\'', ')', ']', 0x201d, 0x2019, 0xbb, 0x300d, 0x300f, 0x3011, 0xff09 => true,
else => false,
};
}
@@ -217,10 +229,10 @@ fn newline(cp: u21) bool {
}
/// The next non-empty piece of `text` from `at.*`, trimmed of white space, with `at.*` moved past it.
-fn nextPiece(text: []const u8, at: *usize, level: Level, chars: u32) ?[]const u8 {
+fn nextPiece(text: []const u8, at: *usize, level: Level, chars: u32, protection: Protection) ?[]const u8 {
while (at.* < text.len) {
const begin = at.*;
- const end = cut(text, begin, level, chars);
+ const end = cut(text, begin, level, chars, protection);
at.* = end;
const piece = trim(text[begin..end]);
if (piece.len > 0) return piece;
@@ -229,25 +241,45 @@ fn nextPiece(text: []const u8, at: *usize, level: Level, chars: u32) ?[]const u8
}
/// Where the piece starting at `begin` ends (its cut point, or the end of `text`).
-fn cut(text: []const u8, begin: usize, level: Level, chars: u32) usize {
+fn cut(text: []const u8, begin: usize, level: Level, chars: u32, protection: Protection) usize {
var it = std.unicode.Utf8View.initUnchecked(text[begin..]).iterator();
var seen: usize = 0;
- while (it.nextCodepoint()) |cp| {
+ const offset = @intFromPtr(text.ptr) - @intFromPtr(protection.base);
+ var atom: usize = 0;
+ while (atom < protection.spans.len and protection.spans[atom].end <= offset + begin) atom += 1;
+ while (it.i < text.len - begin) {
+ const here = begin + it.i;
+ if (atom < protection.spans.len and protection.spans[atom].start == offset + here) {
+ const end = protection.spans[atom].end - offset;
+ const n = count(text[here..end]);
+ if (level == .any and seen > 0 and seen + n > chars) return here;
+ seen += n;
+ it.i = end - begin;
+ atom += 1;
+ if (level == .any and seen >= chars) return end;
+ continue;
+ }
+ const cp = it.nextCodepoint().?;
seen += 1;
switch (level) {
.sentence => {
if (newline(cp)) return begin + it.i;
if (!terminal(cp)) continue;
var after = it;
+ var cjk = cjkTerminal(cp);
while (after.peek(1).len > 0) {
const next = std.unicode.utf8Decode(after.peek(1)) catch unreachable;
if (!terminal(next) and !closer(next)) break;
+ cjk = cjk or cjkTerminal(next);
_ = after.nextCodepoint();
}
it = after;
- if (endsWord(text[begin..], it.i)) return begin + it.i;
+ if (cjk or endsWord(text[begin..], it.i)) return begin + it.i;
+ },
+ .clause => {
+ const cjk = cp == 0xff0c or cp == 0xff1a or cp == 0x3001;
+ if (cjk or ((cp == ';' or cp == ':' or cp == ',') and endsWord(text[begin..], it.i))) return begin + it.i;
},
- .clause => if ((cp == ';' or cp == ':' or cp == ',') and endsWord(text[begin..], it.i)) return begin + it.i,
.space => if (drama_prompt.isWhiteSpace(cp)) return begin + it.i,
.any => if (seen == chars) return begin + it.i,
}
@@ -388,7 +420,7 @@ test "no segment is ever longer than the limit, and there are never more than ne
var greedy: usize = 0;
var current: usize = 0;
var at: usize = 0;
- while (nextPiece(text.items, &at, .sentence, chars)) |piece| {
+ while (nextPiece(text.items, &at, .sentence, chars, .{ .base = text.items.ptr, .spans = &.{} })) |piece| {
const n = count(piece);
if (current > 0 and current + 1 + n <= chars) current += 1 + n else {
greedy += 1;
@@ -408,6 +440,56 @@ test "a sentence longer than the limit is cut at clause marks, then spaces, then
try expectSplit("\u{3042}\u{3044}\u{3046}\u{3048}\u{304a}", 2, &.{ "\u{3042}\u{3044}", "\u{3046}\u{3048}", "\u{304a}" });
}
+test "protected chunks keep a paired direction whole when it exceeds the target" {
+ const input = "One. Two. Three.";
+ for ([_]u32{ 1, 20, input.len - 1, input.len }) |chars| try expectSplit(input, chars, &.{input});
+ try expectSplit("AB" ++ input ++ "CD", 2, &.{ "AB", input, "CD" });
+ try expectSplit("[laughs softly] Hello.", 10, &.{ "[laughs softly]", "Hello." });
+ try expectSplit("[laughs][pause]", 1, &.{ "[laughs]", "[pause]" });
+ try expectSplit("<|speaker:0|> ab", 1, &.{ "<|speaker:0|>", "a", "b" });
+}
+
+test "protected chunks preserve nested spans and recover after malformed openers" {
+ const nested = "One. Two. [pause] Three.";
+ try expectSplit(nested ++ " After.", 10, &.{ nested, "After." });
+ try expectSplit("one. two.", 10, &.{ "one.", "two." });
+ try expectSplit("[open Quiet.", 5, &.{ "[open", "Quiet." });
+ try expectSplit("[outer [inner] tail] End.", 5, &.{ "[outer [inner] tail]", "End." });
+}
+
+test "protected chunks stay in the original input and only indivisible spans may exceed the target" {
+ var arena: std.heap.ArenaAllocator = .init(std.testing.allocator);
+ defer arena.deinit();
+ const a = arena.allocator();
+ const input = "ab\u{4e59}\u{4e19}\u{4e01}\u{3002}cd [laughs softly] ef";
+ const spans = try drama_spans.collect(a, input);
+ for ([_]u32{ 1, 2, 7, 20 }) |chars| {
+ const got = try split(a, input, chars);
+ var end: usize = 0;
+ for (got) |segment| {
+ const start = @intFromPtr(segment.ptr) - @intFromPtr(input.ptr);
+ try std.testing.expect(start >= end and start + segment.len <= input.len);
+ try std.testing.expectEqual(@as(usize, 0), trim(input[end..start]).len);
+ end = start + segment.len;
+ if (count(segment) > chars) {
+ const whole = for (spans) |atom| {
+ if (start == atom.start and end == atom.end) break true;
+ } else false;
+ try std.testing.expect(whole);
+ }
+ }
+ try std.testing.expectEqual(@as(usize, 0), trim(input[end..]).len);
+ }
+}
+
+test "CJK sentence and clause punctuation does not need a following space" {
+ try expectSplit("\u{4f60}\u{597d}\u{3002}\u{4e16}\u{754c}\u{ff01}\u{518d}\u{89c1}\u{ff1f}\u{7ed3}\u{675f}\u{3002}", 6, &.{ "\u{4f60}\u{597d}\u{3002}\u{4e16}\u{754c}\u{ff01}", "\u{518d}\u{89c1}\u{ff1f}\u{7ed3}\u{675f}\u{3002}" });
+ try expectSplit("\u{7532}\u{4e59}\u{ff0c}\u{4e19}\u{4e01}\u{3001}\u{620a}\u{5df1}\u{ff1a}\u{5e9a}\u{8f9b}\u{3002}", 5, &.{ "\u{7532}\u{4e59}\u{ff0c}", "\u{4e19}\u{4e01}\u{3001}", "\u{620a}\u{5df1}\u{ff1a}", "\u{5e9a}\u{8f9b}\u{3002}" });
+ try expectSplit("\u{300c}\u{7532}\u{3002}\u{300d}\u{4e59}\u{ff1b}\u{4e19}\u{ff01}", 4, &.{ "\u{300c}\u{7532}\u{3002}\u{300d}", "\u{4e59}\u{ff1b}\u{4e19}\u{ff01}" });
+ try expectSplit("\u{7532}.\u{ff1f}\u{4e59}\u{3002}", 4, &.{ "\u{7532}.\u{ff1f}", "\u{4e59}\u{3002}" });
+ try std.testing.expect(question("\u{4f60}\u{597d}\u{ff1f}\u{300d}"));
+}
+
test "the segments header lists where each segment after the first starts, and its largest value fits its buffer" {
var buf: [segments_header_max]u8 = undefined;
try std.testing.expectEqualStrings("3;2048,6144", segmentsHeader(&buf, &.{ 0, 2048, 6144 }));
diff --git a/zig/src/server/drama_prompt.zig b/zig/src/server/drama_prompt.zig
index 11c90d577d..762cb2f5cb 100644
--- a/zig/src/server/drama_prompt.zig
+++ b/zig/src/server/drama_prompt.zig
@@ -79,40 +79,11 @@ fn speakerId(digits: []const u8) ?u8 {
return if (n <= max_speaker_id) n else null;
}
-/// Why ``input`` (valid UTF-8) cannot be spoken, in the reference's words, or null when it can.
-/// The order is the reference's: other speakers first, then ``validate_caller_text``.
+/// Why input (valid UTF-8) cannot be spoken; canonical speaker tags 0..15 are accepted.
pub fn problem(a: Allocator, input: []const u8) Allocator.Error!?[]const u8 {
- if (try otherSpeakers(a, &.{input})) |message| return message;
return callerText(a, input, "input");
}
-/// speech_request.py's refusal of well-formed tags naming speakers other than 0 (malformed ones are the builder's).
-pub fn otherSpeakers(a: Allocator, texts: []const []const u8) Allocator.Error!?[]const u8 {
- var others: u16 = 0;
- for (texts) |text| {
- var at: usize = 0;
- while (std.mem.indexOfPos(u8, text, at, "<|speaker:")) |start| {
- if (tagAt(text, start)) |tag| {
- if (speakerId(tag.digits)) |n| if (n != 0) {
- others |= @as(u16, 1) << @intCast(n);
- };
- at = tag.end;
- } else at = start + 1;
- }
- }
- if (others == 0) return null;
- var list: std.ArrayList(u8) = .empty;
- try list.appendSlice(a, error_prefix ++ " only speaker 0 is supported; got speaker tags [");
- var first = true;
- for (1..max_speaker_id + 1) |n| if (others & (@as(u16, 1) << @intCast(n)) != 0) {
- if (!first) try list.appendSlice(a, ", ");
- try list.print(a, "{d}", .{n});
- first = false;
- };
- try list.append(a, ']');
- return list.items;
-}
-
/// prompt.py's ``validate_caller_text(text, location)`` for valid UTF-8 ``text``.
pub fn callerText(a: Allocator, text: []const u8, location: []const u8) Allocator.Error!?[]const u8 {
if (trimStart(text).len == 0) return try std.fmt.allocPrint(a, error_prefix ++ " {s}: text must not be empty", .{location});
@@ -134,6 +105,20 @@ pub fn tagged(a: Allocator, input: []const u8) Allocator.Error![]const u8 {
return std.mem.concat(a, u8, &.{ "<|speaker:0|> ", input });
}
+/// Continues checked text with the last speaker in its checked preceding text; keeps speaker 0 implicit.
+pub fn continued(a: Allocator, input: []const u8, preceding: []const u8) Allocator.Error![]const u8 {
+ if (tagAt(trimStart(input), 0) != null) return input;
+ var speaker: u8 = 0;
+ var at: usize = 0;
+ while (std.mem.indexOfPos(u8, preceding, at, "<|speaker:")) |start| {
+ const tag = tagAt(preceding, start).?;
+ speaker = speakerId(tag.digits).?;
+ at = tag.end;
+ }
+ if (speaker == 0) return input;
+ return std.fmt.allocPrint(a, "<|speaker:{d}|> {s}", .{ speaker, input });
+}
+
/// The prompt's segments for a checked ``input`` (``problem`` returned null), each tokenized on its own.
pub fn segments(a: Allocator, input: []const u8) Allocator.Error![segment_count][]const u8 {
return .{ "<|im_start|>system\n", tts_instruction, message_end, "<|im_start|>user\n", try tagged(a, input), message_end, generation_start };
@@ -205,6 +190,7 @@ test "speaker 0 tags untagged text; a leading tag after white space is kept" {
.{ "\n<|speaker:0|> hi", "\n<|speaker:0|> hi" },
.{ "\u{3000}<|speaker:0|> hi", "\u{3000}<|speaker:0|> hi" },
.{ "a <|speaker:0|> b", "<|speaker:0|> a <|speaker:0|> b" },
+ .{ "a <|speaker:15|> b", "<|speaker:0|> a <|speaker:15|> b" },
.{ "\x1c<|speaker:0|> hi", "<|speaker:0|> \x1c<|speaker:0|> hi" },
.{ "\x1f", "<|speaker:0|> \x1f" },
};
@@ -212,9 +198,14 @@ test "speaker 0 tags untagged text; a leading tag after white space is kept" {
try std.testing.expect(try problem(a, c[0]) == null);
try std.testing.expectEqualStrings(c[1], try tagged(a, c[0]));
}
+ for (0..16) |id| {
+ const text = try std.fmt.allocPrint(a, "\u{3000}<|speaker:{d}|> First. <|speaker:0|> Reply.", .{id});
+ try std.testing.expect(try problem(a, text) == null);
+ try std.testing.expectEqualStrings(text, try tagged(a, text));
+ }
}
-test "input the reference refuses" {
+test "empty input, malformed speaker tags and structural tokens are refused" {
var arena: std.heap.ArenaAllocator = .init(std.testing.allocator);
defer arena.deinit();
const a = arena.allocator();
@@ -223,9 +214,7 @@ test "input the reference refuses" {
const message = (try problem(a, text)) orelse return error.TestUnexpectedResult;
try std.testing.expect(std.mem.startsWith(u8, message, "Drama 3 request: input: speaker tags must be written <|speaker:N|> with N in 0..15 and no leading zero; got "));
}
- try std.testing.expectEqualStrings("Drama 3 request: only speaker 0 is supported; got speaker tags [1, 15]", (try problem(a, "<|speaker:15|> a <|speaker:1|> b <|speaker:1|> c <|speaker:0|> d")).?);
- // other speakers are refused before malformed tags, as speech_request.py checks them first
- try std.testing.expectEqualStrings("Drama 3 request: only speaker 0 is supported; got speaker tags [2]", (try problem(a, "<|speaker:2|> x <|speaker:01|>")).?);
+ try std.testing.expectStringStartsWith((try problem(a, "<|speaker:2|> x <|speaker:01|>")).?, error_prefix ++ " input: speaker tags must be written");
for ([_][]const u8{ "", " ", "\u{3000}\u{2028}\t" }) |blank|
try std.testing.expectEqualStrings("Drama 3 request: input: text must not be empty", (try problem(a, blank)).?);
for (structural_tokens) |token| {
@@ -236,3 +225,14 @@ test "input the reference refuses" {
for ([_][]const u8{ "hi <|audio_separator|> there", "<|fim_prefix|> hi", "<|speaker:0|> current part<|endofturn|>next part" }) |content|
try std.testing.expect(try problem(a, content) == null);
}
+
+test "continued speech inherits the last tag, explicit tags override it, and speaker zero stays implicit" {
+ var arena = std.heap.ArenaAllocator.init(std.testing.allocator);
+ defer arena.deinit();
+ const a = arena.allocator();
+ try std.testing.expectEqualStrings("<|speaker:15|> Next.", try continued(a, "Next.", "<|speaker:15|> First."));
+ try std.testing.expectEqualStrings("<|speaker:2|> Next.", try continued(a, "Next.", "<|speaker:15|> First. <|speaker:2|> Second."));
+ try std.testing.expectEqualStrings("\u{3000}<|speaker:1|> Next.", try continued(a, "\u{3000}<|speaker:1|> Next.", "<|speaker:15|> First."));
+ try std.testing.expectEqualStrings("Next.", try continued(a, "Next.", "First."));
+ try std.testing.expectEqualStrings("Next.", try continued(a, "Next.", "<|speaker:15|> First. <|speaker:0|> Second."));
+}
diff --git a/zig/src/server/drama_shift.zig b/zig/src/server/drama_shift.zig
index 7171ac3a1d..43fda1b30e 100644
--- a/zig/src/server/drama_shift.zig
+++ b/zig/src/server/drama_shift.zig
@@ -2,6 +2,7 @@
const std = @import("std");
const drama_prompt = @import("drama_prompt.zig");
const drama_long = @import("drama_long.zig");
+const drama_spans = @import("drama_spans.zig");
const drama_joins = @import("drama_joins.zig");
const unicode = @import("tokenizer").unicode;
const Allocator = std.mem.Allocator;
@@ -15,6 +16,9 @@ pub const Marked = struct { text: []const u8, cuts: []const usize = &.{}, droppe
/// `input` without its marks and the white space after each; with `honour`, its cuts (`read`'s rule, in the docs).
pub fn read(a: Allocator, input: []const u8, honour: bool) Allocator.Error!Marked {
if (std.mem.indexOf(u8, input, mark) == null) return .{ .text = input };
+ const protected = if (honour) try drama_spans.collect(a, input) else &.{};
+ defer if (honour) a.free(protected);
+ var atom: usize = 0;
var text: std.ArrayList(u8) = .empty;
var cuts: std.ArrayList(usize) = .empty;
var dropped: usize = 0;
@@ -28,6 +32,11 @@ pub fn read(a: Allocator, input: []const u8, honour: bool) Allocator.Error!Marke
at = afterWhiteSpace(input, at + mark.len);
}
if (!honour) continue;
+ while (atom < protected.len and protected[atom].end <= found) atom += 1;
+ if (atom < protected.len and protected[atom].start < found) {
+ dropped += marks;
+ continue;
+ }
// the segments either side: from the cut before, and up to the next mark
const before = text.items[if (cuts.items.len > 0) cuts.items[cuts.items.len - 1] else 0..];
const after = input[at .. std.mem.indexOfPos(u8, input, at, mark) orelse input.len];
@@ -64,7 +73,7 @@ fn hasWords(text: []const u8) bool {
/// A long-form input's segments, and `shifts[i]` (empty without a cut): a mark stands right before segment i.
pub const Segments = struct { segments: []const []const u8, shifts: []const bool = &.{} };
-/// `marked`'s segments of at most `chars`.
+/// `marked`'s segments targeting `chars`, keeping indivisible controls whole.
pub fn split(a: Allocator, marked: Marked, chars: u32) Allocator.Error!Segments {
if (marked.cuts.len == 0) return .{ .segments = try drama_long.split(a, marked.text, chars) };
var segments: std.ArrayList([]const u8) = .empty;
@@ -210,6 +219,15 @@ test "a mark needs words on both sides: punctuation or cues alone are no segment
try expectRead("One. \u{b6} [small laugh] Two.", "One. [small laugh] Two.", &.{5}, 0);
}
+test "topic shifts never cut protected spans, but a following ordinary shift still counts" {
+ try expectRead("One. \u{b6} Two.", "One. Two.", &.{}, 1);
+ try expectRead("[laughs. \u{b6} softly] End.", "[laughs. softly] End.", &.{}, 1);
+ const before = "One. Two. Three. End. ";
+ try expectRead("One. Two. \u{b6} Three. End. \u{b6} Next.", before ++ "Next.", &.{before.len}, 1);
+ try expectRead("One. \u{b6} Two.", "One. Two.", &.{15}, 0);
+ try expectRead("\u{4f60}\u{597d}\u{3002}\u{b6}\u{4e16}\u{754c}\u{3002}", "\u{4f60}\u{597d}\u{3002}\u{4e16}\u{754c}\u{3002}", &.{9}, 0);
+}
+
test "words are Unicode letters and numbers; full-width punctuation and symbols are none" {
// full-width marks, math and currency signs, an emoji, Latin-1's inverted marks
for ([_][]const u8{ "\u{ff01}\u{ff01}\u{ff01}", "\u{d7}", "\u{20ac} \u{2192}", "\u{1f600}", "\u{bf}\u{a1}", "\u{3002}\u{300c}\u{300d}" }) |rest| {
diff --git a/zig/src/server/drama_spans.zig b/zig/src/server/drama_spans.zig
new file mode 100644
index 0000000000..86905d1da6
--- /dev/null
+++ b/zig/src/server/drama_spans.zig
@@ -0,0 +1,128 @@
+//! Indivisible speech text: special tokens, balanced brackets and correctly nested paired tags.
+const std = @import("std");
+const Allocator = std.mem.Allocator;
+
+pub const Span = struct { start: usize, end: usize };
+const Tag = struct { start: usize, end: usize, name: []const u8, closing: bool };
+
+/// Sorted, disjoint byte ranges; adjacent controls remain separate atoms and all bytes stay in the caller's input.
+pub fn collect(a: Allocator, input: []const u8) Allocator.Error![]Span {
+ var atoms: std.ArrayList(Span) = .empty;
+ defer atoms.deinit(a);
+ var brackets: std.ArrayList(usize) = .empty;
+ defer brackets.deinit(a);
+ var i: usize = 0;
+ while (i < input.len) {
+ if (specialEnd(input, i)) |end| {
+ try atoms.append(a, .{ .start = i, .end = end });
+ i = end;
+ continue;
+ }
+ if (input[i] == '[') try brackets.append(a, i) else if (input[i] == ']') {
+ if (brackets.pop()) |start| try atoms.append(a, .{ .start = start, .end = i + 1 });
+ }
+ i += 1;
+ }
+ merge(&atoms);
+
+ var spans: std.ArrayList(Span) = .empty;
+ errdefer spans.deinit(a);
+ try spans.appendSlice(a, atoms.items);
+ var tags: std.ArrayList(Tag) = .empty;
+ defer tags.deinit(a);
+ var atom: usize = 0;
+ i = 0;
+ while (i < input.len) {
+ if (atom < atoms.items.len and i == atoms.items[atom].start) {
+ i = atoms.items[atom].end;
+ atom += 1;
+ continue;
+ }
+ if (tagAt(input, i)) |tag| {
+ if (!tag.closing) {
+ try tags.append(a, tag);
+ } else if (tags.pop()) |open| {
+ if (std.mem.eql(u8, open.name, tag.name)) {
+ try spans.append(a, .{ .start = open.start, .end = tag.end });
+ } else tags.clearRetainingCapacity();
+ }
+ i = tag.end;
+ } else i += 1;
+ }
+ merge(&spans);
+ return spans.toOwnedSlice(a);
+}
+
+fn specialEnd(input: []const u8, start: usize) ?usize {
+ if (!std.mem.startsWith(u8, input[start..], "<|")) return null;
+ var i = start + 2;
+ while (i < input.len and input[i] != '|' and input[i] != '>') : (i += 1) {
+ if (input[i] == '<') return null;
+ }
+ return if (std.mem.startsWith(u8, input[i..], "|>")) i + 2 else null;
+}
+
+fn tagAt(input: []const u8, start: usize) ?Tag {
+ if (input[start] != '<') return null;
+ var i = start + 1;
+ const closing = i < input.len and input[i] == '/';
+ if (closing) i += 1;
+ const first = i;
+ if (i == input.len or !std.ascii.isAlphabetic(input[i])) return null;
+ i += 1;
+ while (i < input.len and (std.ascii.isAlphanumeric(input[i]) or input[i] == '_' or input[i] == '-')) i += 1;
+ if (i == input.len or input[i] != '>') return null;
+ return .{ .start = start, .end = i + 1, .name = input[first..i], .closing = closing };
+}
+
+fn before(_: void, left: Span, right: Span) bool {
+ return left.start < right.start or (left.start == right.start and left.end > right.end);
+}
+
+fn merge(spans: *std.ArrayList(Span)) void {
+ std.mem.sort(Span, spans.items, {}, before);
+ var n: usize = 0;
+ for (spans.items) |span| {
+ if (n > 0 and span.start < spans.items[n - 1].end) {
+ spans.items[n - 1].end = @max(spans.items[n - 1].end, span.end);
+ } else {
+ spans.items[n] = span;
+ n += 1;
+ }
+ }
+ spans.shrinkRetainingCapacity(n);
+}
+
+fn expectSpans(input: []const u8, want: []const []const u8) !void {
+ const spans = try collect(std.testing.allocator, input);
+ defer std.testing.allocator.free(spans);
+ try std.testing.expectEqual(want.len, spans.len);
+ for (spans, want) |span, expected| try std.testing.expectEqualStrings(expected, input[span.start..span.end]);
+ for (spans, 0..) |span, i| {
+ try std.testing.expect(span.start < span.end and span.end <= input.len);
+ if (i > 0) try std.testing.expect(spans[i - 1].end <= span.start);
+ }
+}
+
+test "special tokens and adjacent or nested bracketed cues are indivisible" {
+ try expectSpans("A <|speaker:0|> [soft laugh][pause] B", &.{ "<|speaker:0|>", "[soft laugh]", "[pause]" });
+ try expectSpans("[outer [inner] tail] [next]", &.{ "[outer [inner] tail]", "[next]" });
+ try expectSpans("[<|speaker:0|> [pause]]", &.{"[<|speaker:0|> [pause]]"});
+ try expectSpans("<|a|b|> <|x> <|unterminated", &.{});
+}
+
+test "paired tags nest by exact name and ignore tag-shaped text inside bracketed cues" {
+ const nested = "One. Two. Three.";
+ try expectSpans(nested ++ " Four.", &.{ nested, "Four." });
+ try expectSpans("[literal ] Quiet.", &.{"[literal ] Quiet."});
+ try expectSpans("\u{4f60}\u{597d}\u{3002}", &.{"\u{4f60}\u{597d}\u{3002}"});
+}
+
+test "unclosed and crossed controls do not hide subsequent valid controls" {
+ try expectSpans("[unclosed [pause] Hi.", &.{ "[pause]", "Hi." });
+ try expectSpans("Hi.", &.{"Hi."});
+ try expectSpans("Hi. Bye. End.", &.{"End."});
+ try expectSpans("Hi. Hi. <1>Hi.", &.{});
+ try expectSpans("<|unclosed Hi.", &.{"Hi."});
+ try expectSpans("2 < 3; a > b; [] [unfinished", &.{"[]"});
+}
diff --git a/zig/src/server/drama_voice.zig b/zig/src/server/drama_voice.zig
index f37549b4a7..71c3be3b49 100644
--- a/zig/src/server/drama_voice.zig
+++ b/zig/src/server/drama_voice.zig
@@ -46,16 +46,13 @@ pub fn lower(cx: *Cx, input: []const u8, sent: Value, voice: []const Reference)
return cx.fail(.request, "unknown speech reference field: references.{d}.{s}", .{ i, key });
}
const a = cx.a;
- const texts = try a.alloc([]const u8, 1 + items.len + voice.len);
- texts[0] = input;
- for (items, texts[1..][0..items.len], 0..) |item, *text, i| {
+ const texts = try a.alloc([]const u8, items.len);
+ for (items, texts, 0..) |item, *text, i| {
// descriptor.get("text") or "": a falsy text is an empty transcript
const t = item.get("text") orelse Value.null;
text.* = if (!t.truthy()) "" else if (t == .string) t.string else return cx.fail(.request, prefix ++ " references.{d}.text must be a string", .{i});
if (!std.unicode.utf8ValidateSlice(text.*)) return cx.fail(.request, prefix ++ " references.{d}.text must be valid UTF-8 text", .{i});
}
- for (voice, texts[1 + items.len ..]) |v, *text| text.* = v.text;
- if (try drama_prompt.otherSpeakers(a, texts)) |message| return cx.refuse(message);
const grids = try a.alloc(Grid, items.len);
for (items, grids, 0..) |item, *g, i| {
if (item.field("vq_codes")) |codes| {
@@ -67,7 +64,7 @@ pub fn lower(cx: *Cx, input: []const u8, sent: Value, voice: []const Reference)
const out = try a.alloc(Reference, items.len + voice.len);
for (grids, out[0..items.len], 0..) |g, *reference, i| {
const location = try std.fmt.allocPrint(a, "references.{d}", .{i});
- reference.* = .{ .text = texts[1 + i], .frames = undefined };
+ reference.* = .{ .text = texts[i], .frames = undefined };
if (try drama_prompt.callerText(a, try drama_prompt.tagged(a, reference.text), location)) |message| return cx.refuse(message);
reference.frames = try frames(a, g) orelse return cx.refuse(try codesProblem(a, g, location));
}
@@ -194,7 +191,7 @@ fn fileReference(a: Allocator, doc: Value, problem: *[]const u8) Allocator.Error
const codes = if (g) |x| try frames(a, x) else null;
if (!std.unicode.utf8ValidateSlice(text)) {
problem.* = "text is not UTF-8";
- } else if (try drama_prompt.otherSpeakers(a, &.{text}) orelse try drama_prompt.callerText(a, try drama_prompt.tagged(a, text), "text")) |message| {
+ } else if (try drama_prompt.callerText(a, try drama_prompt.tagged(a, text), "text")) |message| {
problem.* = message;
} else if (codes == null) {
problem.* = "vq_codes is not a [10, frames] grid of codes in [0, 4096)";
diff --git a/zig/src/server/drama_voice_multi_test.zig b/zig/src/server/drama_voice_multi_test.zig
index 780160dfa5..7f89b47434 100644
--- a/zig/src/server/drama_voice_multi_test.zig
+++ b/zig/src/server/drama_voice_multi_test.zig
@@ -19,7 +19,7 @@ fn passages() [3]Reference {
const second = [_]Codes{.{ 20, 21, 22, 23, 24, 25, 26, 27, 28, 29 }};
const own = [_]Codes{ .{ 30, 31, 32, 33, 34, 35, 36, 37, 38, 39 }, .{ 40, 41, 42, 43, 44, 45, 46, 47, 48, 49 }, .{ 7, 7, 7, 7, 7, 7, 7, 7, 7, 7 } };
};
- return .{ .{ .text = "The first passage.", .frames = &S.first }, .{ .text = "A second one, then.", .frames = &S.second }, .{ .text = "And the voice's own.", .frames = &S.own } };
+ return .{ .{ .text = "The first passage.", .frames = &S.first }, .{ .text = "<|speaker:15|> A second one, then.", .frames = &S.second }, .{ .text = "And the voice's own.", .frames = &S.own } };
}
/// The [codebooks, frames] grid as a voice file writes it.
@@ -94,7 +94,7 @@ test "a /2 voice builds the rows a request's references followed by a /1 voice b
try expectRows(try rows(a, input, "null", own), try rows(a, input, "null", try load(a, try several(a, entries[2..]))));
}
-test "a /2 file is refused for an empty list, a reference without its clip's digest, wrong codes or another speaker" {
+test "a /2 file is refused for an empty list, a reference without its clip's digest, wrong codes or a malformed tag" {
var arena: std.heap.ArenaAllocator = .init(std.testing.allocator);
defer arena.deinit();
const a = arena.allocator();
@@ -106,7 +106,7 @@ test "a /2 file is refused for an empty list, a reference without its clip's dig
.{ try several(a, &.{ good, try fields(a, p[1], "") }), "references.1: audio_sha256 is not a clip's sha256 (64 lowercase hex digits)" },
.{ try several(a, &.{ good, try fields(a, p[1], clip[1..] ++ "A") }), "references.1: audio_sha256 is not a clip's sha256 (64 lowercase hex digits)" },
.{ try several(a, &.{ good, wrong }), "references.1: codes_sha256 does not match vq_codes" },
- .{ try several(a, &.{try fields(a, .{ .text = "<|speaker:3|> x", .frames = p[0].frames }, clip)}), "references.0: Drama 3 request: only speaker 0 is supported; got speaker tags [3]" },
+ .{ try several(a, &.{try fields(a, .{ .text = "<|speaker:16|> x", .frames = p[0].frames }, clip)}), "references.0: Drama 3 request: text: speaker tags must be written" },
.{ try std.mem.replaceOwned(u8, a, try several(a, &.{good}), "voice/2", "voice/3"), "format is not drama3-voice/1 or drama3-voice/2" },
.{ try std.mem.replaceOwned(u8, a, try several(a, &.{good}), source, "null"), "source must say whose voice this is" },
};
diff --git a/zig/src/server/drama_voice_test.zig b/zig/src/server/drama_voice_test.zig
index fb71990272..27c8349135 100644
--- a/zig/src/server/drama_voice_test.zig
+++ b/zig/src/server/drama_voice_test.zig
@@ -14,16 +14,26 @@ const Reference = drama_prompt.Reference;
const fixture = @embedFile("drama_voice_fixture.json");
-test "references are refused with the reference's messages, in its order" {
+test "references keep the pinned refusals except the two speaker-only cases this native extension accepts" {
var arena: std.heap.ArenaAllocator = .init(std.testing.allocator);
defer arena.deinit();
const a = arena.allocator();
const doc = (try json.parse(a, fixture)).ok;
const cases = doc.get("refusals").?.array;
try std.testing.expect(cases.len >= 20);
+ var extended: usize = 0;
for (cases) |case| {
var cx: Cx = .{ .a = a };
const got = drama_voice.lower(&cx, case.strField("input").?, case.get("references").?, &.{});
+ const name = case.strField("name").?;
+ if (std.mem.eql(u8, name, "other-speaker") or std.mem.eql(u8, name, "other-speaker-input")) {
+ try std.testing.expectStringStartsWith(case.strField("message").?, "Drama 3 request: only speaker 0");
+ const refs = try got;
+ try std.testing.expectEqual(@as(usize, 1), refs.len);
+ try std.testing.expectEqualStrings(case.get("references").?.array[0].strField("text").?, refs[0].text);
+ extended += 1;
+ continue;
+ }
std.testing.expectError(error.Refused, got) catch |e| {
std.debug.print("{s}: accepted\n", .{case.strField("name").?});
return e;
@@ -33,6 +43,7 @@ test "references are refused with the reference's messages, in its order" {
return e;
};
}
+ try std.testing.expectEqual(@as(usize, 2), extended);
}
test "the server's own refusals: audio it cannot encode, fields it would drop, text that is not UTF-8" {
@@ -72,10 +83,9 @@ test "a request's references come before its voice's; no references and no voice
try std.testing.expectEqualStrings("voice", both[1].text);
try std.testing.expectEqual(@as(usize, 1), (try drama_voice.lower(&cx, "hi", .null, &voice)).len);
for ([_][]const u8{ "null", "[]" }) |none| try std.testing.expectEqual(@as(usize, 0), (try drama_voice.lower(&cx, "<|voice|>", (try json.parse(a, none)).ok, &.{})).len);
- // the voice's transcript counts in the other-speaker check, as an uploaded voice's does
+ // A catalog's nonzero speaker is preserved, as an inline reference's is.
const other = [_]Reference{.{ .text = "<|speaker:4|> voice", .frames = &frames }};
- try std.testing.expectError(error.Refused, drama_voice.lower(&cx, "hi", .null, &other));
- try std.testing.expectEqualStrings("Drama 3 request: only speaker 0 is supported; got speaker tags [4]", cx.message);
+ try std.testing.expectEqualStrings(other[0].text, (try drama_voice.lower(&cx, "hi", .null, &other))[0].text);
}
test "transcripts move a tag behind leading white space in front of it" {
@@ -246,7 +256,7 @@ test "voice files: regular NAME.json files only, names, consent and digests chec
.{ .file = "default.json", .data = try voiceFile(a, "x", owner, true), .problem = "a voice name is" },
.{ .file = "-x.json", .data = try voiceFile(a, "x", owner, true), .problem = "a voice name is" },
.{ .file = "bad.json", .data = try voiceFile(a, "x", owner, false), .problem = "codes_sha256 does not match vq_codes" },
- .{ .file = "tagged.json", .data = try voiceFile(a, "<|speaker:3|> x", owner, true), .problem = "only speaker 0 is supported" },
+ .{ .file = "tagged.json", .data = try voiceFile(a, "<|speaker:16|> x", owner, true), .problem = "speaker tags must be written" },
.{ .file = "plain.json", .data = "nope", .problem = "not JSON" },
.{ .file = "unsourced.json", .data = try voiceFile(a, "x", "", true), .problem = unsourced },
.{ .file = "flat.json", .data = try voiceFile(a, "x", "\"owner\"", true), .problem = unsourced },
diff --git a/zig/src/server/root.zig b/zig/src/server/root.zig
index 5e62886e7c..6eb6e4aa2d 100644
--- a/zig/src/server/root.zig
+++ b/zig/src/server/root.zig
@@ -41,6 +41,7 @@ test {
_ = @import("status_routes.zig");
_ = @import("speech.zig");
_ = @import("speech_stream_test.zig");
+ _ = @import("speech_speakers_test.zig");
_ = @import("drama_prompt.zig");
_ = @import("drama_voice_test.zig");
_ = @import("drama_voice_multi_test.zig");
@@ -56,6 +57,7 @@ test {
_ = @import("drama_cfg.zig");
_ = @import("speech_cfg_test.zig");
_ = @import("speech_long_test.zig");
+ _ = @import("speech_sampling_test.zig");
_ = @import("speech_redraw.zig");
_ = @import("speech_redraw_test.zig");
_ = @import("speech_redraw_off_test.zig");
diff --git a/zig/src/server/speech.zig b/zig/src/server/speech.zig
index 48ad9bafd6..73e55aff87 100644
--- a/zig/src/server/speech.zig
+++ b/zig/src/server/speech.zig
@@ -10,6 +10,7 @@ const openai = @import("openai.zig");
const pyrepr = @import("pyrepr.zig");
const reply_text = @import("reply_text.zig");
const drama_prompt = @import("drama_prompt.zig");
+const speech_sampling = @import("speech_sampling.zig");
const drama_voice = @import("drama_voice.zig");
const drama_shift = @import("drama_shift.zig");
const drama_allow = @import("drama_allow.zig");
@@ -35,7 +36,7 @@ pub const max_input_chars = 4096;
const served_fields = [_][]const u8{ "model", "input", "voice", "speaker", "response_format" };
/// The rest of the speech protocol's fields: synthesis modifiers and audio references this route does not honor.
-const modifier_fields = [_][]const u8{ "speed", "task_type", "language", "instructions", "ref_audio", "ref_text", "x_vector_only_mode", "stream_codec_output", "suppress_bootstrap_silence", "token_count", "duration_tokens", "initial_codec_chunk_frames", "max_new_tokens", "temperature", "top_p", "top_k", "repetition_penalty", "seed", "stage_params" };
+const modifier_fields = [_][]const u8{ "speed", "task_type", "language", "instructions", "ref_audio", "ref_text", "x_vector_only_mode", "stream_codec_output", "suppress_bootstrap_silence", "token_count", "duration_tokens", "initial_codec_chunk_frames", "max_new_tokens", "repetition_penalty", "stage_params" };
pub const Format = enum {
wav,
@@ -50,7 +51,7 @@ pub const Format = enum {
};
/// A synthesis's prompt and sources, or a long-form reply; `dropped`: `¶` marks not honoured; `stripped`: controls cut.
-const Plan = struct { prompt: []const u32, codes: []const drama_prompt.Codes, input: []const u8, references: []const drama_prompt.Reference, format: Format, stream: bool, long: ?speech_long.Long = null, dropped: usize = 0, stripped: ?usize = null };
+const Plan = struct { prompt: []const u32, codes: []const drama_prompt.Codes, input: []const u8, references: []const drama_prompt.Reference, sampling: speech_sampling.Options, format: Format, stream: bool, long: ?speech_long.Long = null, dropped: usize = 0, stripped: ?usize = null };
pub fn post(srv: *Server, c: *Conn, a: Allocator) !void {
const sp = srv.info.speech orelse {
@@ -94,8 +95,8 @@ fn checkFields(cx: *Cx, body: Value) errors.Refused!void {
if (value == .null or (value == .string and std.mem.eql(u8, value.string, "audio"))) continue;
if (value == .string and std.mem.eql(u8, value.string, "sse")) return cx.refuse("stream_format sse is not supported by this model");
return cx.refuse("stream_format must be one of: audio, sse");
- } else if (std.mem.eql(u8, key, "references")) {
- // lowered with the voice, after the input's checks (drama_voice.lower)
+ } else if (std.mem.eql(u8, key, "references") or speech_sampling.isField(key)) {
+ // references and sampling are checked in prepare before submission
} else if (listed(&modifier_fields, key)) {
if (value != .null) return cx.fail(.request, "{s} is not supported by this model", .{key});
} else return cx.fail(.request, "unknown speech request field: {s}", .{key});
@@ -114,6 +115,7 @@ fn responseFormat(cx: *Cx, value: []const u8) errors.Refused!Format {
fn prepare(srv: *Server, cx: *Cx, sp: api.SpeechInfo, raw: Value) errors.Refused!Plan {
if (raw != .object) return cx.refuse("speech request body must be a JSON object");
try checkFields(cx, raw);
+ const sampling = try speech_sampling.parse(cx, raw);
const model = raw.strField("model") orelse return cx.fail(.request, "model is required: send {s}", .{srv.config.served_name});
if (!listed(srv.config.model_ids, model))
return cx.fail(.request, "model {s} is not served here: send {s}", .{ try pyrepr.repr(cx.a, .{ .string = model }), srv.config.served_name });
@@ -135,15 +137,15 @@ fn prepare(srv: *Server, cx: *Cx, sp: api.SpeechInfo, raw: Value) errors.Refused
const voice = raw.strField("voice") orelse raw.strField("speaker") orelse "default";
const references = try drama_voice.lower(cx, input, raw.get("references") orelse .null, try voiceReferences(srv, cx, voice));
if (references.len == 0) if (try drama_prompt.problem(cx.a, input)) |message| return cx.refuse(message);
- if (srv.config.long_form) |options| if (try speech_long.plan(srv, cx, sp, marked, references, options)) |long|
- return .{ .prompt = &.{}, .codes = &.{}, .input = input, .references = references, .format = format, .stream = stream, .long = long, .dropped = marked.dropped, .stripped = stripped };
+ if (srv.config.long_form) |options| if (try speech_long.plan(srv, cx, sp, marked, references, options, sampling)) |long|
+ return .{ .prompt = &.{}, .codes = &.{}, .input = input, .references = references, .sampling = sampling, .format = format, .stream = stream, .long = long, .dropped = marked.dropped, .stripped = stripped };
const rows = drama_prompt.promptRows(cx.a, srv.text, input, references) catch |e| return switch (e) {
error.OutOfMemory => error.OutOfMemory,
error.Template => cx.other("the tokenizer cannot encode this prompt"),
};
if (rows.tokens.len > sp.max_prompt_tokens)
return cx.fail(.request, drama_prompt.error_prefix ++ " a prompt of {d} rows exceeds the maximum allowed length of {d} rows", .{ rows.tokens.len, sp.max_prompt_tokens });
- return .{ .prompt = rows.tokens, .codes = rows.codes, .input = input, .references = references, .format = format, .stream = stream, .dropped = marked.dropped, .stripped = stripped };
+ return .{ .prompt = rows.tokens, .codes = rows.codes, .input = input, .references = references, .sampling = sampling, .format = format, .stream = stream, .dropped = marked.dropped, .stripped = stripped };
}
/// What ``voice`` names: the built-in voice (none), --default-voice's for ``default``, else a --voices file's.
@@ -184,11 +186,11 @@ fn synthesize(srv: *Server, c: *Conn, cx: *Cx, id: []const u8, sp: api.SpeechInf
.codes = rows.codes,
.pcm = audio,
.result = &result,
- .seed = api.seedFor(rows.tokens, speech_redraw.Redraws.salt(srv.config.seed_salt, k)),
+ .seed = plan.sampling.seedFor(rows.tokens, srv.config.seed_salt, k),
.max_frames = sp.max_frames,
- .temperature = drama_prompt.temperature,
- .top_p = drama_prompt.top_p,
- .top_k = drama_prompt.top_k,
+ .temperature = plan.sampling.temperature,
+ .top_p = plan.sampling.top_p,
+ .top_k = plan.sampling.top_k,
.unconditioned = guided.unconditioned,
.cfg_gamma = guided.gamma,
.stream = plan.stream,
@@ -573,7 +575,6 @@ test "fields: unknown ones are refused even when null, modifiers when set" {
.{ "{\"model\": \"m\", \"input\": \"hi\", \"stream\": \"yes\"}", "stream must be a boolean" },
.{ "{\"model\": \"m\", \"input\": \"hi\", \"stream_format\": \"sse\"}", "stream_format sse is not supported by this model" },
.{ "{\"model\": \"m\", \"input\": \"hi\", \"stream_format\": \"mp3\"}", "stream_format must be one of: audio, sse" },
- .{ "{\"model\": \"m\", \"input\": \"hi\", \"temperature\": 0.7}", "temperature is not supported by this model" },
.{ "{\"model\": \"m\", \"input\": \"hi\", \"ref_audio\": \"x.wav\"}", "ref_audio is not supported by this model" },
.{ "{\"model\": \"m\", \"input\": 3}", "input must be a string" },
.{ "{\"model\": null, \"input\": \"hi\"}", "model must be a string" },
diff --git a/zig/src/server/speech_long.zig b/zig/src/server/speech_long.zig
index b174cf8acb..57b7b25167 100644
--- a/zig/src/server/speech_long.zig
+++ b/zig/src/server/speech_long.zig
@@ -4,6 +4,7 @@ const api = @import("engine_api");
const errors = @import("errors.zig");
const speech = @import("speech.zig");
const speech_redraw = @import("speech_redraw.zig");
+const speech_sampling = @import("speech_sampling.zig");
const drama_prompt = @import("drama_prompt.zig");
const drama_long = @import("drama_long.zig");
const drama_joins = @import("drama_joins.zig");
@@ -26,10 +27,16 @@ pub const Long = struct {
references: []const Reference,
history: u8,
shift_pause_s: f32,
+ sampling: speech_sampling.Options,
fn shifted(l: Long, i: usize) bool {
return i < l.shifts.len and l.shifts[i];
}
+
+ fn textFor(l: Long, a: std.mem.Allocator, i: usize, text: []const u8) ![]const u8 {
+ const start = @intFromPtr(l.segments[i].ptr) - @intFromPtr(l.input.ptr);
+ return drama_prompt.continued(a, text, l.input[0..start]);
+ }
};
/// The stream's trailers: the finish reason when cut short, where the segments start, and with shifts on, their pauses.
@@ -37,24 +44,25 @@ const trailer = "X-Finish-Reason, X-Long-Form-Segments";
const shift_trailer = trailer ++ ", X-Pause-Spans";
/// The input's segments, cut at each of `marked`'s cuts, each refused now as a whole input would be; null: one reply.
-pub fn plan(srv: *Server, cx: *Cx, sp: api.SpeechInfo, marked: drama_shift.Marked, references: []const Reference, options: drama_long.Options) errors.Refused!?Long {
+pub fn plan(srv: *Server, cx: *Cx, sp: api.SpeechInfo, marked: drama_shift.Marked, references: []const Reference, options: drama_long.Options, sampling: speech_sampling.Options) errors.Refused!?Long {
const input = marked.text;
if (marked.cuts.len == 0 and (std.unicode.utf8CountCodepoints(input) catch unreachable) <= options.chars) return null;
const split = try drama_shift.split(cx.a, marked, options.chars);
const segments = split.segments;
if (segments.len <= 1) return null;
if (segments.len > drama_long.max_segments)
- return cx.fail(.request, drama_prompt.error_prefix ++ " a long-form input in {d} segments of at most {d} characters exceeds the maximum of {d} segments", .{ segments.len, options.chars, drama_long.max_segments });
- for (segments) |segment| {
+ return cx.fail(.request, drama_prompt.error_prefix ++ " a long-form input in {d} segments targeting {d} characters exceeds the maximum of {d} segments", .{ segments.len, options.chars, drama_long.max_segments });
+ const long: Long = .{ .input = input, .segments = segments, .shifts = split.shifts, .references = references, .history = options.history, .shift_pause_s = options.shift_pause_s, .sampling = sampling };
+ for (segments, 0..) |segment, i| {
if (try drama_prompt.problem(cx.a, segment)) |message| return cx.refuse(message);
- const rows = drama_prompt.promptRows(cx.a, srv.text, segment, references) catch |e| return switch (e) {
+ const rows = drama_prompt.promptRows(cx.a, srv.text, try long.textFor(cx.a, i, segment), references) catch |e| return switch (e) {
error.OutOfMemory => error.OutOfMemory,
error.Template => cx.other("the tokenizer cannot encode this prompt"),
};
if (rows.tokens.len > sp.max_prompt_tokens)
return cx.fail(.request, drama_prompt.error_prefix ++ " a prompt of {d} rows exceeds the maximum allowed length of {d} rows", .{ rows.tokens.len, sp.max_prompt_tokens });
}
- return .{ .input = input, .segments = segments, .shifts = split.shifts, .references = references, .history = options.history, .shift_pause_s = options.shift_pause_s };
+ return long;
}
/// Speaks every segment into one reply: a WAV or PCM body, or a PCM stream from the first segment's first audio.
@@ -138,7 +146,7 @@ const Reply = struct {
fn speak(r: *Reply, i: usize) bool {
const fl: usize = r.sp.frame_length;
const room = @min(r.sp.max_frames, drama_long.max_frames - r.frames);
- var text = r.long.segments[i];
+ var text = r.long.textFor(r.cx.a, i, r.long.segments[i]) catch return r.end(.other, "out of memory");
var rows = r.prompt(text) catch |e| return r.end(.other, if (e == error.OutOfMemory) "out of memory" else "the tokenizer cannot encode this prompt");
// only the first segment streams as it is made: a later one's level and pause need all of it
const live = r.stream and i == 0;
@@ -156,11 +164,11 @@ const Reply = struct {
.generated = r.generated[r.frames..][0..room],
.pcm = r.scratch[0 .. room * fl],
.result = &result,
- .seed = api.seedFor(rows.tokens, speech_redraw.Redraws.salt(r.srv.config.seed_salt, k)),
+ .seed = r.long.sampling.seedFor(rows.tokens, r.srv.config.seed_salt, k),
.max_frames = @intCast(room),
- .temperature = drama_prompt.temperature,
- .top_p = drama_prompt.top_p,
- .top_k = drama_prompt.top_k,
+ .temperature = r.long.sampling.temperature,
+ .top_p = r.long.sampling.top_p,
+ .top_k = r.long.sampling.top_k,
.unconditioned = guided.unconditioned,
.cfg_gamma = guided.gamma,
.stream = live,
@@ -193,7 +201,7 @@ const Reply = struct {
// a stream has sent audio before its guard can trip, so only a whole reply is redrawn
if (r.stream or r.redraws.policy.max == 0) break this;
const cause = r.redraws.trip(this.reason, this.samples, r.sp.sample_rate, text) orelse break this;
- if (next == null) next = r.redrawText(i, rows) orelse break this;
+ if (next == null) next = r.redrawText(i, text, rows) orelse break this;
start_by = r.redraws.again(r.srv.io, r.id, started, cause) orelse break this;
text = next.?.text;
rows = next.?.rows;
@@ -210,9 +218,9 @@ const Reply = struct {
}
/// What redraws of segment `i` speak: its `rows`, or its plain text's (--silence-redraw-plain); null if neither.
- fn redrawText(r: *Reply, i: usize, rows: drama_prompt.Rows) ?speech_redraw.Spoken {
+ fn redrawText(r: *Reply, i: usize, spoken: []const u8, rows: drama_prompt.Rows) ?speech_redraw.Spoken {
const segment = r.long.segments[i];
- if (!r.redraws.policy.plain) return .{ .text = segment, .rows = rows };
+ if (!r.redraws.policy.plain) return .{ .text = spoken, .rows = rows };
const why_not = why: {
const a = r.cx.a;
// the whole input's controls, so one a cut crosses goes whole and only the input's own note head counts
@@ -222,8 +230,9 @@ const Reply = struct {
break :spans found;
};
const start = @intFromPtr(segment.ptr) - @intFromPtr(r.long.input.ptr);
- const text = (speech_redraw.heard(a, r.long.input, spans, start, start + segment.len) catch break :why "out of memory") orelse return .{ .text = segment, .rows = rows };
- if (speech_redraw.problem(a, text)) |message| break :why message;
+ const plain = (speech_redraw.heard(a, r.long.input, spans, start, start + segment.len) catch break :why "out of memory") orelse return .{ .text = spoken, .rows = rows };
+ if (speech_redraw.problem(a, plain)) |message| break :why message;
+ const text = r.long.textFor(a, i, plain) catch break :why "out of memory";
const cue_free = r.prompt(text) catch break :why "the tokenizer cannot encode the segment without its cues";
if (cue_free.tokens.len > r.sp.max_prompt_tokens) break :why "the segment without its cues does not fit the prompt";
log.line("speech {s} long-form segment {d}: redraws speak it without its {s}", .{ r.id, i + 1, @tagName(r.redraws.policy.plain_scope) });
diff --git a/zig/src/server/speech_long_test.zig b/zig/src/server/speech_long_test.zig
index e0d850b491..de6e3fef62 100644
--- a/zig/src/server/speech_long_test.zig
+++ b/zig/src/server/speech_long_test.zig
@@ -8,6 +8,7 @@ const harness = @import("speech_stream_test.zig");
const Served = harness.Served;
const gpa = std.testing.allocator;
+pub const Sampling = struct { temperature: f32, top_p: f32, top_k: u32 };
/// 1 kHz audio in 10-sample frames: a codec frame is one 10 ms join frame, and a sentence's pause is 420 samples.
const rate = 1000;
const frame = 10;
@@ -26,6 +27,7 @@ pub const Turns = struct {
prompts: std.ArrayList([]const u32) = .empty,
codes: std.ArrayList([]const drama_prompt.Codes) = .empty,
seeds: std.ArrayList(u64) = .empty,
+ sampling: std.ArrayList(Sampling) = .empty,
limits: std.ArrayList(u32) = .empty,
generated: std.ArrayList(usize) = .empty,
streamed: std.ArrayList(bool) = .empty,
@@ -54,6 +56,7 @@ pub const Turns = struct {
t.prompts.append(a, a.dupe(u32, request.prompt) catch unreachable) catch unreachable;
t.codes.append(a, a.dupe(drama_prompt.Codes, request.codes) catch unreachable) catch unreachable;
t.seeds.append(a, request.seed) catch unreachable;
+ t.sampling.append(a, .{ .temperature = request.temperature, .top_p = request.top_p, .top_k = request.top_k }) catch unreachable;
t.limits.append(a, request.max_frames) catch unreachable;
t.generated.append(a, request.generated.len) catch unreachable;
t.streamed.append(a, request.stream) catch unreachable;
@@ -110,9 +113,10 @@ pub fn body(a: std.mem.Allocator, input: []const u8, stream: bool) ![]const u8 {
fn serve(t: *Turns, cfg: server.Config, request: []const u8) !struct { s: *Served, head: []const u8 } {
const s = try gpa.create(Served);
try s.startWith(t.engine(), cfg, "HTTP/1.1", request, 2000);
- const head = try s.readHead();
+ const head_len = (try s.readHead()).len;
+ _ = try s.readRest(); // drain before joining: a whole reply can outgrow the socket's buffers
s.route.join();
- return .{ .s = s, .head = head };
+ return .{ .s = s, .head = s.got.items[0..head_len] };
}
pub fn done(s: *Served) void {
@@ -338,7 +342,7 @@ test "more than 12 segments are refused before any synthesis" {
const r = try serve(&t, config(.{ .chars = 20 }), try body(a, try sentences(a, 13), false));
defer done(r.s);
try std.testing.expect(std.mem.indexOf(u8, r.head, " 400 ") != null);
- try std.testing.expect(std.mem.indexOf(u8, try r.s.readRest(), "Drama 3 request: a long-form input in 13 segments of at most 20 characters exceeds the maximum of 12 segments") != null);
+ try std.testing.expect(std.mem.indexOf(u8, try r.s.readRest(), "Drama 3 request: a long-form input in 13 segments targeting 20 characters exceeds the maximum of 12 segments") != null);
try std.testing.expectEqual(@as(usize, 0), t.seen);
}
@@ -383,3 +387,51 @@ test "a failure after the first segment ends a stream incomplete and a whole rep
}
}
}
+
+test "protected controls reach whole and streamed speech requests without a split inside them" {
+ var arena: std.heap.ArenaAllocator = .init(gpa);
+ defer arena.deinit();
+ const a = arena.allocator();
+ var text: harness.Bytes = .{};
+ const cases = [_]struct { input: []const u8, first: []const u8, second: []const u8, chars: u32 }{
+ .{ .input = "One. Two. Three. After.", .first = "One. Two. Three.", .second = "After.", .chars = 20 },
+ .{ .input = "[laughs softly] Hello.", .first = "[laughs softly]", .second = "Hello.", .chars = 10 },
+ .{ .input = "One. \u{b6} Two. After.", .first = "One. Two.", .second = "After.", .chars = 20 },
+ };
+ for (cases) |case| for ([_]bool{ false, true }) |stream| {
+ var t: Turns = .{ .turns = &.{ .{ .frames = 3 }, .{ .frames = 4 } } };
+ defer t.deinit();
+ const options: drama_long.Options = .{ .chars = case.chars, .history = 0, .shift_pause_s = 0.5 };
+ const r = try serve(&t, config(options), try body(a, case.input, stream));
+ defer done(r.s);
+ try std.testing.expect(std.mem.indexOf(u8, r.head, "HTTP/1.1 200") != null);
+ const rest = try r.s.readRest();
+ try std.testing.expect(rest.len > 0);
+ try std.testing.expectEqual(@as(usize, 2), t.seen);
+ for ([_][]const u8{ case.first, case.second }, t.prompts.items) |segment, prompt|
+ try std.testing.expectEqualSlices(u32, try drama_prompt.encode(a, text.text(), segment), prompt);
+ try std.testing.expectEqualSlices(bool, &.{ stream, false }, t.streamed.items);
+ const metadata = if (stream) rest else r.s.got.items[0..r.head.len];
+ try std.testing.expect(std.mem.indexOf(u8, metadata, "X-Long-Form-Segments: 2;") != null);
+ try std.testing.expect(std.mem.indexOf(u8, metadata, "X-Pause-Spans:") == null);
+ if (stream) try std.testing.expect(std.mem.endsWith(u8, rest, "\r\n\r\n"));
+ };
+}
+
+test "an indivisible span above the character target still obeys the engine prompt ceiling" {
+ var arena: std.heap.ArenaAllocator = .init(gpa);
+ defer arena.deinit();
+ const a = arena.allocator();
+ var text: harness.Bytes = .{};
+ const span = "One. Two. Three.";
+ const ceiling: u32 = @intCast((try drama_prompt.encode(a, text.text(), span)).len - 1);
+ for ([_][]const u8{ span, span ++ " After." }) |input| {
+ var t: Turns = .{ .turns = &.{}, .max_prompt = ceiling };
+ defer t.deinit();
+ const r = try serve(&t, config(.{ .chars = 1 }), try body(a, input, false));
+ defer done(r.s);
+ try std.testing.expect(std.mem.indexOf(u8, r.head, "HTTP/1.1 400") != null);
+ try std.testing.expect(std.mem.indexOf(u8, try r.s.readRest(), "exceeds the maximum allowed length") != null);
+ try std.testing.expectEqual(@as(usize, 0), t.seen);
+ }
+}
diff --git a/zig/src/server/speech_mid_test.zig b/zig/src/server/speech_mid_test.zig
index 6ce2c3771e..88f19a7ccf 100644
--- a/zig/src/server/speech_mid_test.zig
+++ b/zig/src/server/speech_mid_test.zig
@@ -25,8 +25,8 @@ fn serve(t: *Turns, cfg: server.Config, deadline: ?[]const u8, request: []const
const first = if (deadline) |d| try std.fmt.bufPrint(&line, "POST /v1/audio/speech HTTP/1.1\r\nX-Deadline-S: {s}", .{d}) else "POST /v1/audio/speech HTTP/1.1";
try s.open(t.engine(), cfg, first, request, 2000);
_ = try s.readHead();
- s.route.join();
_ = try s.readRest();
+ s.route.join();
// read whole first: reading more can move the bytes a head slice points into
const all = s.got.items;
return .{ .s = s, .head = all[0 .. std.mem.indexOf(u8, all, "\r\n\r\n").? + 4], .all = all };
diff --git a/zig/src/server/speech_redraw_test.zig b/zig/src/server/speech_redraw_test.zig
index fbb5e1fe15..c661c97268 100644
--- a/zig/src/server/speech_redraw_test.zig
+++ b/zig/src/server/speech_redraw_test.zig
@@ -24,9 +24,10 @@ fn serve(t: *Turns, cfg: server.Config, deadline: ?[]const u8, request: []const
const s = try gpa.create(harness.Served);
const first = if (deadline) |d| try std.fmt.bufPrint(&line, "POST /v1/audio/speech HTTP/1.1\r\nX-Deadline-S: {s}", .{d}) else "POST /v1/audio/speech HTTP/1.1";
try s.open(t.engine(), cfg, first, request, 2000);
- const head = try s.readHead();
+ const head_len = (try s.readHead()).len;
+ _ = try s.readRest(); // drain before joining: a whole reply can outgrow the socket's buffers
s.route.join();
- return .{ .s = s, .head = head };
+ return .{ .s = s, .head = s.got.items[0..head_len] };
}
fn has(haystack: []const u8, needle: []const u8) bool {
@@ -423,7 +424,7 @@ test "long-form controls: a later segment that opens like a director's note keep
try std.testing.expectEqualSlices(u32, want, try redrawnSecond(a, "Sentence 00 is ok, and it is long enough.\\nDirection: d\\nLine: Sentence 01 [pause] ok.", 45));
}
-test "long-form controls: a bracket span that a segment cut crosses is dropped whole, from both segments" {
+test "long-form controls: a bracket cue stays in one segment and is dropped whole on redraw" {
var arena: std.heap.ArenaAllocator = .init(gpa);
defer arena.deinit();
const a = arena.allocator();
@@ -431,7 +432,8 @@ test "long-form controls: a bracket span that a segment cut crosses is dropped w
const input = "Sentence 00 is ok. [warmly. then] Sentence 01 ok.";
const segments = try drama_long.split(a, input, 30);
try std.testing.expectEqual(@as(usize, 2), segments.len);
- try std.testing.expect(std.mem.endsWith(u8, segments[0], "[warmly.") and std.mem.startsWith(u8, segments[1], "then]"));
+ try std.testing.expectEqualStrings("Sentence 00 is ok.", segments[0]);
+ try std.testing.expectEqualStrings("[warmly. then] Sentence 01 ok.", segments[1]);
const want = try drama_prompt.encode(a, text.text(), "Sentence 01 ok.");
try std.testing.expectEqualSlices(u32, want, try redrawnSecond(a, input, 30));
}
diff --git a/zig/src/server/speech_register_test.zig b/zig/src/server/speech_register_test.zig
index d0bebe25d6..031a0113d7 100644
--- a/zig/src/server/speech_register_test.zig
+++ b/zig/src/server/speech_register_test.zig
@@ -26,6 +26,7 @@ const Draws = struct {
refused: u8 = 0,
prompts: [4][]const u32 = undefined,
seeds: [4]u64 = undefined,
+ sampling: [4]scripted.Sampling = undefined,
fn engine(d: *Draws) api.Engine {
return .{ .ctx = d, .vtable = &.{ .info = info, .submit = submit, .cancel = cancel, .status = status, .memory = memory, .submit_speech = speech } };
@@ -45,6 +46,7 @@ const Draws = struct {
d.refused = 0;
d.prompts[d.seen] = d.a.dupe(u32, request.prompt) catch unreachable;
d.seeds[d.seen] = request.seed;
+ d.sampling[d.seen] = .{ .temperature = request.temperature, .top_p = request.top_p, .top_k = request.top_k };
d.seen += 1;
@memcpy(request.pcm[0..draw.pcm.len], draw.pcm);
if (request.stream) sink.event(sink.ctx, id, &.{ .audio = draw.pcm.len });
@@ -86,8 +88,9 @@ fn serve(d: *Draws, cfg: server.Config, deadline: ?[]const u8, request: []const
try s.open(d.engine(), cfg, first, request, 2000);
// the body's read may move the bytes the head lies in
const head = try d.a.dupe(u8, try s.readHead());
+ const rest = try s.readRest(); // drain before joining: the 16 kHz replies outgrow the socket's buffers
s.route.join();
- return .{ .s = s, .head = head, .body = try s.readRest() };
+ return .{ .s = s, .head = head, .body = rest };
}
fn config(register: speech_register.Policy, silence: speech_redraw.Policy) server.Config {
@@ -116,6 +119,25 @@ test "a jump trips one redraw at the next salt; the calmer redraw is sent, marke
try std.testing.expectEqualSlices(u32, d.prompts[0], d.prompts[1]);
}
+test "speech sampling: silence then register redraws retain settings and increment the exact seed" {
+ var arena: std.heap.ArenaAllocator = .init(gpa);
+ defer arena.deinit();
+ const a = arena.allocator();
+ const calm = try reply(a, 178);
+ var d: Draws = .{ .a = a, .draws = &.{ .{ .pcm = calm, .reason = .silence }, .{ .pcm = try reply(a, 240) }, .{ .pcm = calm } } };
+ const request = "{\"model\":\"m\",\"input\":\"One. Two.\",\"response_format\":\"pcm\",\"temperature\":0.5,\"top_p\":0.75,\"top_k\":8,\"seed\":9007199254740993}";
+ const r = try serve(&d, config(on, .{ .max = 1 }), null, request);
+ defer scripted.done(r.s);
+ try harness.expectHeader(r.head, "HTTP/1.1 200");
+ try harness.expectHeader(r.head, "X-Silence-Redraws: 1");
+ try harness.expectHeader(r.head, "X-Register-Redraws: 1");
+ try std.testing.expectEqual(@as(usize, 3), d.seen);
+ for (0..d.seen) |k| {
+ try std.testing.expectEqual(@as(u64, 9007199254740993) + k, d.seeds[k]);
+ try std.testing.expectEqualDeep(scripted.Sampling{ .temperature = 0.5, .top_p = 0.75, .top_k = 8 }, d.sampling[k]);
+ }
+}
+
test "an untripped reply is drawn once and sent byte for byte as with the guard off, marked Trip 0 and Redraws 0" {
var arena: std.heap.ArenaAllocator = .init(gpa);
defer arena.deinit();
diff --git a/zig/src/server/speech_sampling.zig b/zig/src/server/speech_sampling.zig
new file mode 100644
index 0000000000..46c6afff6c
--- /dev/null
+++ b/zig/src/server/speech_sampling.zig
@@ -0,0 +1,57 @@
+//! Request-local Drama sampling, checked before a speech request reaches the engine.
+const std = @import("std");
+const api = @import("engine_api");
+const Value = @import("json.zig").Value;
+const errors = @import("errors.zig");
+const defaults = @import("drama_prompt.zig");
+
+pub const Options = struct {
+ temperature: f32 = defaults.temperature,
+ top_p: f32 = defaults.top_p,
+ top_k: u32 = defaults.top_k,
+ seed: ?u64 = null,
+
+ pub fn seedFor(o: Options, prompt: []const u32, salt: i64, attempt: usize) u64 {
+ if (o.seed) |seed| return seed +% @as(u64, @intCast(attempt));
+ return api.seedFor(prompt, salt +% @as(i64, @intCast(attempt)));
+ }
+};
+
+pub fn isField(key: []const u8) bool {
+ for ([_][]const u8{ "temperature", "top_p", "top_k", "seed" }) |name|
+ if (std.mem.eql(u8, key, name)) return true;
+ return false;
+}
+
+pub fn parse(cx: *errors.Cx, body: Value) errors.Refused!Options {
+ var out: Options = .{};
+ if (body.field("temperature")) |value|
+ out.temperature = try number(cx, value, std.math.floatMax(f32), "temperature must be a finite nonnegative f32 number");
+ if (body.field("top_p")) |value| {
+ out.top_p = try number(cx, value, 1, "top_p must be a finite f32 number greater than 0 and at most 1");
+ if (out.top_p == 0) return cx.refuse("top_p must be greater than 0");
+ }
+ if (body.field("top_k")) |value| {
+ const message = "top_k must be an integer from 1 through 64";
+ if (value != .int) return cx.refuse(message);
+ const n = std.fmt.parseInt(u32, value.int, 10) catch return cx.refuse(message);
+ if (n == 0 or n > 64) return cx.refuse(message);
+ out.top_k = n;
+ }
+ if (body.field("seed")) |value| {
+ const message = "seed must be an integer from 0 through 18446744073709551615";
+ if (value != .int) return cx.refuse(message);
+ out.seed = std.fmt.parseInt(u64, value.int, 10) catch return cx.refuse(message);
+ }
+ return out;
+}
+
+/// Check the parsed f64 range before narrowing, then reject positive values that would become zero.
+fn number(cx: *errors.Cx, value: Value, max: f64, message: []const u8) errors.Refused!f32 {
+ if (value != .int and value != .float) return cx.refuse(message);
+ const n = value.float64() orelse return cx.refuse(message);
+ if (!std.math.isFinite(n) or n < 0 or n > max) return cx.refuse(message);
+ const narrowed: f32 = @floatCast(n);
+ if (n > 0 and narrowed == 0) return cx.refuse(message);
+ return narrowed;
+}
diff --git a/zig/src/server/speech_sampling_test.zig b/zig/src/server/speech_sampling_test.zig
new file mode 100644
index 0000000000..7fc6d40613
--- /dev/null
+++ b/zig/src/server/speech_sampling_test.zig
@@ -0,0 +1,167 @@
+//! Speech sampling controls through the HTTP route, including long-form retries and carried reference prompts.
+const std = @import("std");
+const api = @import("engine_api");
+const server = @import("root.zig");
+const harness = @import("speech_stream_test.zig");
+const scripted = @import("speech_long_test.zig");
+const drama_prompt = @import("drama_prompt.zig");
+const gpa = std.testing.allocator;
+const config: server.Config = .{ .served_name = "m", .model_ids = &.{"m"}, .seed_salt = 17 };
+const defaults: scripted.Sampling = .{ .temperature = 1, .top_p = 0.9, .top_k = 30 };
+
+fn exchange(turns: *scripted.Turns, cfg: server.Config, body: []const u8) ![]u8 {
+ var s: harness.Served = undefined;
+ try s.startWith(turns.engine(), cfg, "HTTP/1.1", body, 2000);
+ defer s.deinit();
+ defer s.route.join();
+ _ = try s.readHead();
+ _ = try s.readRest();
+ return gpa.dupe(u8, s.got.items);
+}
+
+fn expectDraw(turns: *const scripted.Turns, index: usize, sampling: scripted.Sampling, seed: u64) !void {
+ try std.testing.expectEqualDeep(sampling, turns.sampling.items[index]);
+ try std.testing.expectEqual(seed, turns.seeds.items[index]);
+}
+
+test "speech sampling: omitted and null controls retain default parameters and PCM" {
+ const bodies = [_][]const u8{
+ "{\"model\":\"m\",\"input\":\"hi\",\"response_format\":\"pcm\"}",
+ "{\"model\":\"m\",\"input\":\"hi\",\"response_format\":\"pcm\",\"temperature\":null,\"top_p\":null,\"top_k\":null,\"seed\":null}",
+ };
+ var first: ?[]u8 = null;
+ defer if (first) |pcm| gpa.free(pcm);
+ for (bodies) |body| {
+ var turns: scripted.Turns = .{ .turns = &.{.{ .frames = 5 }} };
+ defer turns.deinit();
+ const reply = try exchange(&turns, config, body);
+ defer gpa.free(reply);
+ try harness.expectHeader(reply, "HTTP/1.1 200");
+ try std.testing.expectEqual(@as(usize, 1), turns.seen);
+ try expectDraw(&turns, 0, defaults, api.seedFor(turns.prompts.items[0], config.seed_salt));
+ const pcm = reply[(std.mem.indexOf(u8, reply, "\r\n\r\n").? + 4)..];
+ if (first) |before| try std.testing.expectEqualSlices(u8, before, pcm) else first = try gpa.dupe(u8, pcm);
+ }
+}
+
+test "speech sampling: custom parameters and exact integer seeds reach whole and streamed requests" {
+ const cases = [_]struct { fields: []const u8, sampling: scripted.Sampling, seed: ?u64 }{
+ .{ .fields = "\"temperature\":1.25,\"top_p\":0.8,\"top_k\":64,\"seed\":9007199254740993", .sampling = .{ .temperature = 1.25, .top_p = 0.8, .top_k = 64 }, .seed = 9007199254740993 },
+ .{ .fields = "\"temperature\":0,\"top_p\":1,\"top_k\":1,\"seed\":0", .sampling = .{ .temperature = 0, .top_p = 1, .top_k = 1 }, .seed = 0 },
+ .{ .fields = "\"seed\":18446744073709551615", .sampling = defaults, .seed = std.math.maxInt(u64) },
+ .{ .fields = "\"temperature\":0.5", .sampling = .{ .temperature = 0.5, .top_p = 0.9, .top_k = 30 }, .seed = null },
+ .{ .fields = "\"temperature\":1e-400", .sampling = .{ .temperature = 0, .top_p = 0.9, .top_k = 30 }, .seed = null },
+ .{ .fields = "\"temperature\":-1e-400", .sampling = .{ .temperature = -0.0, .top_p = 0.9, .top_k = 30 }, .seed = null },
+ .{ .fields = "\"temperature\":3.4028234663852886e38,\"top_p\":1e-45", .sampling = .{ .temperature = std.math.floatMax(f32), .top_p = 1e-45, .top_k = 30 }, .seed = null },
+ };
+ for (cases) |case| for ([_]bool{ false, true }) |stream| {
+ const body = try std.fmt.allocPrint(gpa, "{{\"model\":\"m\",\"input\":\"hi\",\"response_format\":\"pcm\",\"stream\":{s},{s}}}", .{ if (stream) "true" else "false", case.fields });
+ defer gpa.free(body);
+ var turns: scripted.Turns = .{ .turns = &.{.{ .frames = 5 }} };
+ defer turns.deinit();
+ const reply = try exchange(&turns, config, body);
+ defer gpa.free(reply);
+ try harness.expectHeader(reply, "HTTP/1.1 200");
+ if (stream) try harness.expectHeader(reply, "Transfer-Encoding: chunked");
+ try std.testing.expectEqual(@as(usize, 1), turns.seen);
+ try expectDraw(&turns, 0, case.sampling, case.seed orelse api.seedFor(turns.prompts.items[0], config.seed_salt));
+ };
+}
+
+test "speech sampling: invalid controls fail before any engine submission" {
+ const fields = [_][]const u8{
+ "\"top_p\":1e-400", "\"top_p\":-1e-400",
+ "\"temperature\":true", "\"temperature\":\"1\"",
+ "\"temperature\":[]", "\"temperature\":{}",
+ "\"temperature\":-1", "\"temperature\":NaN",
+ "\"temperature\":Infinity", "\"temperature\":1e39",
+ "\"temperature\":1e-100", "\"top_p\":false",
+ "\"top_p\":\"0.9\"", "\"top_p\":0",
+ "\"top_p\":-0.1", "\"top_p\":1.00000001",
+ "\"top_p\":NaN", "\"top_p\":1e-100",
+ "\"top_p\":Infinity", "\"top_k\":true",
+ "\"top_k\":\"30\"", "\"top_k\":1.5",
+ "\"top_k\":30.0", "\"top_k\":0",
+ "\"top_k\":-1", "\"top_k\":65",
+ "\"top_k\":18446744073709551616", "\"seed\":true",
+ "\"seed\":\"1\"", "\"seed\":1.5",
+ "\"seed\":1.0", "\"seed\":-1",
+ "\"seed\":18446744073709551616", "\"seed\":NaN",
+ };
+ for (fields) |field| {
+ const body = try std.fmt.allocPrint(gpa, "{{\"model\":\"m\",\"input\":\"hi\",{s}}}", .{field});
+ defer gpa.free(body);
+ var turns: scripted.Turns = .{ .turns = &.{.{ .frames = 5 }} };
+ defer turns.deinit();
+ const reply = try exchange(&turns, config, body);
+ defer gpa.free(reply);
+ try harness.expectHeader(reply, "HTTP/1.1 400");
+ try std.testing.expectEqual(@as(usize, 0), turns.seen);
+ }
+}
+
+test "speech sampling: referenced re-prompts keep overrides and wrap explicit retry seeds" {
+ const frames = [_]drama_prompt.Codes{@splat(7)};
+ const refs = [_]drama_prompt.Reference{.{ .text = "A small cloud passes.", .frames = &frames }};
+ const voices = [_]@import("drama_voice.zig").Voice{.{ .name = "tone", .references = &refs, .source = .@"model-invented" }};
+ var cfg = config;
+ cfg.voices = &voices;
+ cfg.cfg = .{ .gamma = 2 };
+ cfg.silence_redraw = .{ .max = 2, .plain = true };
+ var turns: scripted.Turns = .{ .turns = &.{ .{ .frames = 5, .reason = .silence }, .{ .frames = 5, .reason = .silence }, .{ .frames = 5 } } };
+ defer turns.deinit();
+ const reply = try exchange(&turns, cfg, "{\"model\":\"m\",\"input\":\"hi [sighs] [laughs] there\",\"voice\":\"tone\",\"temperature\":0.5,\"top_p\":0.75,\"top_k\":8,\"seed\":18446744073709551615}");
+ defer gpa.free(reply);
+ try harness.expectHeader(reply, "HTTP/1.1 200");
+ try std.testing.expectEqual(@as(usize, 3), turns.seen);
+ for ([_]u64{ std.math.maxInt(u64), 0, 1 }, 0..) |seed, k| {
+ try expectDraw(&turns, k, .{ .temperature = 0.5, .top_p = 0.75, .top_k = 8 }, seed);
+ var reference_frames: usize = 0;
+ for (turns.codes.items[k]) |codes| if (std.meta.eql(frames[0], codes)) {
+ reference_frames += 1;
+ };
+ try std.testing.expectEqual(@as(usize, 1), reference_frames);
+ try std.testing.expectEqual(@as(f32, 2), turns.gammas.items[k]);
+ try std.testing.expect(turns.unconditioned.items[k].len > 0);
+ }
+ try std.testing.expect(!std.mem.eql(u32, turns.prompts.items[0], turns.prompts.items[1]));
+}
+
+test "speech sampling: long-form segment retries preserve overrides, carried prompts and per-segment seeds" {
+ var cfg = config;
+ cfg.long_form = .{ .chars = 20 };
+ cfg.silence_redraw = .{ .max = 1, .plain = true };
+ cfg.cfg = .{ .gamma = 2 };
+ for ([_]bool{ false, true }) |explicit| {
+ const seed_field = if (explicit) ",\"seed\":18446744073709551615" else "";
+ const body = try std.fmt.allocPrint(gpa, "{{\"model\":\"m\",\"input\":\"Sentence 00 is ok. Sentence [sighs] ok. Sentence 02 is ok.\",\"temperature\":0.5,\"top_p\":0.75,\"top_k\":8{s}}}", .{seed_field});
+ defer gpa.free(body);
+ var turns: scripted.Turns = .{ .turns = &.{ .{ .frames = 5 }, .{ .frames = 5, .reason = .silence }, .{ .frames = 5, .busy = 1 }, .{ .frames = 5 } } };
+ defer turns.deinit();
+ const reply = try exchange(&turns, cfg, body);
+ defer gpa.free(reply);
+ try harness.expectHeader(reply, "HTTP/1.1 200");
+ try std.testing.expectEqual(@as(usize, 4), turns.seen);
+ for ([_]usize{ 0, 0, 1, 0 }, 0..) |attempt, k| {
+ const seed = if (explicit) std.math.maxInt(u64) +% @as(u64, @intCast(attempt)) else api.seedFor(turns.prompts.items[k], config.seed_salt + @as(i64, @intCast(attempt)));
+ try expectDraw(&turns, k, .{ .temperature = 0.5, .top_p = 0.75, .top_k = 8 }, seed);
+ try std.testing.expectEqual(@as(f32, if (k == 0) 1 else 2), turns.gammas.items[k]);
+ }
+ try std.testing.expect(!std.mem.eql(u32, turns.prompts.items[1], turns.prompts.items[2]));
+ try std.testing.expect(turns.codes.items[3].len > 0);
+ }
+}
+
+test "speech sampling: a silenced long-form stream keeps controls without redrawing" {
+ var cfg = config;
+ cfg.long_form = .{ .chars = 20 };
+ cfg.silence_redraw = .{ .max = 2 };
+ var turns: scripted.Turns = .{ .turns = &.{ .{ .frames = 5 }, .{ .frames = 5, .reason = .silence } } };
+ defer turns.deinit();
+ const reply = try exchange(&turns, cfg, "{\"model\":\"m\",\"input\":\"Sentence 00 is ok. Sentence 01 is ok. Sentence 02 is ok.\",\"response_format\":\"pcm\",\"stream\":true,\"temperature\":0.5,\"seed\":2}");
+ defer gpa.free(reply);
+ try harness.expectHeader(reply, "HTTP/1.1 200");
+ try harness.expectHeader(reply, "X-Finish-Reason: silence");
+ try std.testing.expectEqual(@as(usize, 2), turns.seen);
+ for (0..2) |k| try expectDraw(&turns, k, .{ .temperature = 0.5, .top_p = 0.9, .top_k = 30 }, 2);
+}
diff --git a/zig/src/server/speech_speakers_test.zig b/zig/src/server/speech_speakers_test.zig
new file mode 100644
index 0000000000..5dd57922fa
--- /dev/null
+++ b/zig/src/server/speech_speakers_test.zig
@@ -0,0 +1,206 @@
+//! Speaker identities through actual HTTP submissions, long-form history, guidance and redraws.
+const std = @import("std");
+const server = @import("root.zig");
+const json = @import("json.zig");
+const prompt = @import("drama_prompt.zig");
+const wire = @import("speech_stream_test.zig");
+const scripted = @import("speech_long_test.zig");
+
+const suffix = "<|im_end|>\n<|im_start|>assistant\n<|voice|>";
+const plain_head = "<|im_start|>system\nconvert the provided text to speech<|im_end|>\n<|im_start|>user\n";
+const reference = "[{\"text\":\" <|speaker:15|> Reference.\",\"vq_codes\":[[7],[1],[2],[3],[4],[5],[6],[7],[8],[9]]}]";
+
+fn request(a: std.mem.Allocator, input: []const u8, stream: bool, referenced: bool) ![]const u8 {
+ return std.fmt.allocPrint(a, "{{\"model\":\"m\",\"input\":{s},\"response_format\":\"pcm\",\"stream\":{}{s}}}", .{
+ try json.quote(a, input, .{}), stream, if (referenced) ",\"references\":" ++ reference else "",
+ });
+}
+
+fn serve(a: std.mem.Allocator, turns: *scripted.Turns, config: server.Config, body: []const u8) ![]const u8 {
+ var s: wire.Served = undefined;
+ try s.startWith(turns.engine(), config, "HTTP/1.1", body, 2000);
+ defer s.deinit();
+ _ = try s.readHead();
+ _ = try s.readRest();
+ s.route.join();
+ return a.dupe(u8, s.got.items);
+}
+
+fn bytes(a: std.mem.Allocator, text: []const u8) ![]const u32 {
+ const out = try a.alloc(u32, text.len);
+ for (text, out) |byte, *token| token.* = byte;
+ return out;
+}
+
+fn userText(a: std.mem.Allocator, tokens: []const u32, text: []const u8) !void {
+ const end = try bytes(a, try std.mem.concat(a, u8, &.{ "<|im_start|>user\n", text, suffix }));
+ try std.testing.expect(std.mem.endsWith(u32, tokens, end));
+}
+
+fn contains(a: std.mem.Allocator, tokens: []const u32, text: []const u8) !void {
+ try std.testing.expect(std.mem.indexOf(u32, tokens, try bytes(a, text)) != null);
+}
+
+test "speakers: every canonical ID reaches the engine without changing dialogue text" {
+ var arena = std.heap.ArenaAllocator.init(std.testing.allocator);
+ defer arena.deinit();
+ const a = arena.allocator();
+ for (0..16) |id| {
+ const input = try std.fmt.allocPrint(a, "\u{3000}<|speaker:{d}|> First. <|speaker:0|> Reply.", .{id});
+ var turns: scripted.Turns = .{ .turns = &.{.{ .frames = 2 }} };
+ defer turns.deinit();
+ const got = try serve(a, &turns, scripted.config(null), try request(a, input, false, false));
+ try std.testing.expect(std.mem.startsWith(u8, got, "HTTP/1.1 200 "));
+ try std.testing.expectEqual(@as(usize, 1), turns.seen);
+ try std.testing.expectEqualSlices(u32, try bytes(a, try std.mem.concat(a, u8, &.{ plain_head, input, suffix })), turns.prompts.items[0]);
+ }
+}
+
+test "speakers: referenced whole and streamed dialogue keeps reference and guidance identities" {
+ var arena = std.heap.ArenaAllocator.init(std.testing.allocator);
+ defer arena.deinit();
+ const a = arena.allocator();
+ const input = "<|speaker:15|> First. <|speaker:1|> Reply. <|speaker:15|> Done.";
+ var config = scripted.config(null);
+ config.cfg = .{ .gamma = 3 };
+ for ([_]bool{ false, true }) |stream| {
+ var turns: scripted.Turns = .{ .turns = &.{.{ .frames = 2 }} };
+ defer turns.deinit();
+ const got = try serve(a, &turns, config, try request(a, input, stream, true));
+ try std.testing.expect(std.mem.startsWith(u8, got, "HTTP/1.1 200 "));
+ try std.testing.expectEqual(@as(usize, 1), turns.seen);
+ try userText(a, turns.prompts.items[0], input);
+ try contains(a, turns.prompts.items[0], "Text: <|speaker:15|> Reference.\nSpeech: ");
+ try std.testing.expectEqualSlices(u32, try bytes(a, plain_head ++ input ++ suffix), turns.unconditioned.items[0]);
+ var found: usize = 0;
+ for (turns.codes.items[0]) |codes| if (codes[0] != 0) {
+ try std.testing.expectEqualSlices(u32, &.{ 7, 1, 2, 3, 4, 5, 6, 7, 8, 9 }, &codes);
+ found += 1;
+ };
+ try std.testing.expectEqual(@as(usize, 1), found);
+ if (stream) try std.testing.expect(std.mem.endsWith(u8, got, "\r\n0\r\n\r\n"));
+ }
+}
+
+test "speakers: long-form continuations carry the active speaker with and without history or streaming" {
+ var arena = std.heap.ArenaAllocator.init(std.testing.allocator);
+ defer arena.deinit();
+ const a = arena.allocator();
+ const input = "<|speaker:15|> First sentence. Second sentence. <|speaker:2|> Third sentence. Fourth sentence.";
+ const spoken = [_][]const u8{
+ "<|speaker:15|> First sentence.", "<|speaker:15|> Second sentence.",
+ "<|speaker:2|> Third sentence.", "<|speaker:2|> Fourth sentence.",
+ };
+ for ([_]u8{ 0, 1 }) |history| for ([_]bool{ false, true }) |stream| {
+ var turns: scripted.Turns = .{ .turns = &.{ .{ .frames = 2 }, .{ .frames = 2 }, .{ .frames = 2 }, .{ .frames = 2 } } };
+ defer turns.deinit();
+ var config = scripted.config(.{ .chars = 30, .history = history });
+ config.cfg = .{ .gamma = 3 };
+ const got = try serve(a, &turns, config, try request(a, input, stream, false));
+ try std.testing.expect(std.mem.startsWith(u8, got, "HTTP/1.1 200 "));
+ try std.testing.expectEqual(@as(usize, 4), turns.seen);
+ for (spoken, 0..) |text, i| {
+ try userText(a, turns.prompts.items[i], text);
+ if (history > 0 and i > 0) {
+ try contains(a, turns.prompts.items[i], try std.mem.concat(a, u8, &.{ "[Reference 1]\nText: ", spoken[i - 1], "\nSpeech: " }));
+ try std.testing.expectEqualSlices(u32, try bytes(a, try std.mem.concat(a, u8, &.{ plain_head, text, suffix })), turns.unconditioned.items[i]);
+ var found: usize = 0;
+ for (turns.codes.items[i]) |codes| if (codes[0] != 0) {
+ const want: prompt.Codes = @splat(@intCast(i * 100 + found));
+ try std.testing.expectEqualSlices(u32, &want, &codes);
+ found += 1;
+ };
+ try std.testing.expectEqual(@as(usize, 2), found);
+ } else try std.testing.expectEqual(@as(usize, 0), turns.unconditioned.items[i].len);
+ }
+ };
+}
+
+test "speakers: paragraph shifts and plain redraws preserve speaker tags in the next segment's history" {
+ var arena = std.heap.ArenaAllocator.init(std.testing.allocator);
+ defer arena.deinit();
+ const a = arena.allocator();
+ const input = "<|speaker:15|> First sentence.\u{b6} [pause] Second sentence.\u{b6} Third sentence.";
+ for ([_]@import("speech_redraw.zig").Scope{ .cues, .controls }) |scope| {
+ var turns: scripted.Turns = .{ .turns = &.{ .{ .frames = 2 }, .{ .frames = 2, .reason = .silence }, .{ .frames = 2 }, .{ .frames = 2 } } };
+ defer turns.deinit();
+ var config = scripted.config(.{ .chars = 80, .history = 1, .shift_pause_s = 0.5 });
+ config.cfg = .{ .gamma = 3 };
+ config.silence_redraw = .{ .max = 1, .plain = true, .plain_scope = scope };
+ const got = try serve(a, &turns, config, try request(a, input, false, false));
+ try std.testing.expect(std.mem.startsWith(u8, got, "HTTP/1.1 200 "));
+ try std.testing.expectEqual(@as(usize, 4), turns.seen);
+ try userText(a, turns.prompts.items[1], "<|speaker:15|> [pause] Second sentence.");
+ try userText(a, turns.prompts.items[2], "<|speaker:15|> Second sentence.");
+ try userText(a, turns.prompts.items[3], "<|speaker:15|> Third sentence.");
+ try contains(a, turns.prompts.items[3], "Text: <|speaker:15|> Second sentence.\nSpeech: ");
+ try std.testing.expectEqualSlices(u32, try bytes(a, plain_head ++ "<|speaker:15|> Second sentence." ++ suffix), turns.unconditioned.items[2]);
+ try std.testing.expect(std.mem.indexOf(u8, got, "X-Pause-Spans: ") != null);
+ }
+}
+
+test "speakers: long-form admission counts the carried speaker tag before submitting any segment" {
+ var arena = std.heap.ArenaAllocator.init(std.testing.allocator);
+ defer arena.deinit();
+ const a = arena.allocator();
+ const continuation = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.";
+ var turns: scripted.Turns = .{
+ .turns = &.{ .{ .frames = 2 }, .{ .frames = 2 } },
+ .max_prompt = plain_head.len + "<|speaker:0|> ".len + continuation.len + suffix.len,
+ };
+ defer turns.deinit();
+ const got = try serve(a, &turns, scripted.config(.{ .chars = 40 }), try request(a, "<|speaker:15|> Hi. " ++ continuation, false, false));
+ try std.testing.expect(std.mem.startsWith(u8, got, "HTTP/1.1 400 "));
+ try std.testing.expect(std.mem.indexOf(u8, got, "rows exceeds the maximum allowed length") != null);
+ try std.testing.expectEqual(@as(usize, 0), turns.seen);
+}
+
+test "speakers: protected hard cuts retain embedded tags and sampling controls through continuation" {
+ var arena = std.heap.ArenaAllocator.init(std.testing.allocator);
+ defer arena.deinit();
+ const a = arena.allocator();
+ const input = "abcdefghijklmnop<|speaker:15|>abcdefghijklmnopqrstuvwxyz";
+ const spoken = [_][]const u8{
+ "<|speaker:0|> abcdefghijklmnop",
+ "<|speaker:15|>abcdef",
+ "<|speaker:15|> ghijklmnopqrstuvwxyz",
+ };
+ for ([_]bool{ false, true }) |stream| {
+ var turns: scripted.Turns = .{ .turns = &.{ .{ .frames = 2 }, .{ .frames = 2 }, .{ .frames = 2 } } };
+ defer turns.deinit();
+ var config = scripted.config(.{ .chars = 20, .history = 1 });
+ config.cfg = .{ .gamma = 2 };
+ const raw = try request(a, input, stream, false);
+ const body = try std.fmt.allocPrint(a, "{s},\"temperature\":0.5,\"top_p\":0.75,\"top_k\":8,\"seed\":9007199254740993}}", .{raw[0 .. raw.len - 1]});
+ const got = try serve(a, &turns, config, body);
+ try std.testing.expect(std.mem.startsWith(u8, got, "HTTP/1.1 200 "));
+ try std.testing.expectEqual(spoken.len, turns.seen);
+ for (spoken, 0..) |text, i| {
+ try userText(a, turns.prompts.items[i], text);
+ try std.testing.expectEqualDeep(scripted.Sampling{ .temperature = 0.5, .top_p = 0.75, .top_k = 8 }, turns.sampling.items[i]);
+ try std.testing.expectEqual(@as(u64, 9007199254740993), turns.seeds.items[i]);
+ if (i > 0) try userText(a, turns.unconditioned.items[i], text);
+ }
+ }
+}
+
+test "speakers: malformed dialogue is refused before submission with or without references" {
+ var arena = std.heap.ArenaAllocator.init(std.testing.allocator);
+ defer arena.deinit();
+ const a = arena.allocator();
+ const bad = [_][]const u8{
+ "<|speaker:15|> Valid. <|speaker:16|> Bad.",
+ "<|speaker:1|> Valid. <|speaker:01|> Bad.",
+ "<|speaker:-1|> Bad.",
+ "<|speaker:\u{661}|> Bad.",
+ "Partial <|speaker:",
+ };
+ for ([_]bool{ false, true }) |referenced| for (bad) |input| {
+ var turns: scripted.Turns = .{ .turns = &.{.{ .frames = 2 }} };
+ defer turns.deinit();
+ const got = try serve(a, &turns, scripted.config(null), try request(a, input, true, referenced));
+ try std.testing.expect(std.mem.startsWith(u8, got, "HTTP/1.1 400 "));
+ try std.testing.expect(std.mem.indexOf(u8, got, "N in 0..15 and no leading zero") != null);
+ try std.testing.expectEqual(@as(usize, 0), turns.seen);
+ };
+}
diff --git a/zig/src/server/speech_stream_test.zig b/zig/src/server/speech_stream_test.zig
index 030dd3b425..8781d28041 100644
--- a/zig/src/server/speech_stream_test.zig
+++ b/zig/src/server/speech_stream_test.zig
@@ -236,7 +236,7 @@ fn pcm(comptime n: usize) [2 * frame * n]u8 {
return bytes;
}
-fn expectHeader(head: []const u8, line: []const u8) !void {
+pub fn expectHeader(head: []const u8, line: []const u8) !void {
try std.testing.expect(std.mem.indexOf(u8, head, line) != null);
}
@@ -265,8 +265,8 @@ test "audio published before the route reads it goes out as one chunk" {
try s.start(&script, "HTTP/1.1", stream_body, 2000);
defer s.deinit();
_ = try s.readHead();
- s.join(&script);
const rest = try s.readRest();
+ s.join(&script);
try std.testing.expect(std.mem.startsWith(u8, rest, "3000\r\n") and std.mem.endsWith(u8, rest, "\r\n0\r\n\r\n"));
try std.testing.expectEqualStrings(&pcm(3), rest["3000\r\n".len .. rest.len - "\r\n0\r\n\r\n".len]);
}
@@ -305,8 +305,8 @@ test "audio cut short by the frame limit or the silence guard ends the stream wi
try s.start(&script, "HTTP/1.1", stream_body, 2000);
defer s.deinit();
try expectHeader(try s.readHead(), "Trailer: X-Finish-Reason\r\n");
- s.join(&script);
const rest = try s.readRest();
+ s.join(&script);
var buf: [64]u8 = undefined;
const end = try std.fmt.bufPrint(&buf, "\r\n0\r\nX-Finish-Reason: {s}\r\n\r\n", .{@tagName(reason)});
try std.testing.expect(std.mem.startsWith(u8, rest, "2000\r\n") and std.mem.endsWith(u8, rest, end));
diff --git a/zig/src/server/voice_cli.zig b/zig/src/server/voice_cli.zig
index d3f3d67617..781a77510b 100644
--- a/zig/src/server/voice_cli.zig
+++ b/zig/src/server/voice_cli.zig
@@ -121,6 +121,13 @@ test "the voice file loads with the codes it was written with, and a transcript
try std.testing.expectEqualStrings("a40ff3d5900fb7698b8c865041347cb49eccedc8f93945f89629ad104aaecce4", doc.strField("audio_sha256").?);
try std.testing.expect(std.mem.indexOf(u8, bytes, "\"Wie spät ist es?\"") != null);
try std.testing.expect(std.mem.endsWith(u8, bytes, "]]}\n"));
- try std.testing.expect(try voiceFile(a, "<|speaker:4|> hi", &codes, "RIFF", .{ .object = encoder }, &problem) == null);
- try std.testing.expectEqualStrings("the voice file would not load: Drama 3 request: only speaker 0 is supported; got speaker tags [4]", problem);
+ for (0..16) |id| {
+ const text = try std.fmt.allocPrint(a, "\u{3000}<|speaker:{d}|> hi", .{id});
+ const tagged = (try voiceFile(a, text, &codes, "RIFF", .{ .object = encoder }, &problem)).?;
+ const ref = (try drama_voice.parseReference(a, tagged, &problem)).?;
+ try std.testing.expectEqualStrings(text, ref.text);
+ try std.testing.expectEqualSlices(drama_prompt.Codes, &codes, ref.frames);
+ }
+ try std.testing.expect(try voiceFile(a, "<|speaker:16|> hi", &codes, "RIFF", .{ .object = encoder }, &problem) == null);
+ try std.testing.expectStringStartsWith(problem, "the voice file would not load: Drama 3 request: text: speaker tags must be written");
}