Add ReactNativeVersion.h to react/utils (#58403)

Summary:
Pull Request resolved: #58403

Changelog: [General][Added] - Added `ReactNativeVersion.h` to public `react/utils` module.

Existing one inside private `cxxreact/bridge` module is now deprecated and still accessible when not opted in to `RN_STRICT_API`.

Reviewed By: javache

Differential Revision: D119163947

Author: j-piasecki

packages/react-native/ReactCommon/cxxreact/CMakeLists.txt

@@ -24,6 +24,7 @@ target_link_libraries(react_cxxreact
         jsinspector
         logger
         react_cxxstableapi
+        react_utils
         reactperflogger
         runtimeexecutor
         react_debug)

packages/react-native/ReactCommon/cxxreact/ReactNativeVersion.h

@@ -1,32 +1,21 @@
-/**
+/*
  * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- * @generated by scripts/releases/set-version.js
  */
 
 #pragma once
 
 #include <react/cxxstableapi/PrivateGuard.h>
 
-#include <cstdint>
-#include <string_view>
-
-#define REACT_NATIVE_VERSION_MAJOR 1000
-#define REACT_NATIVE_VERSION_MINOR 0
-#define REACT_NATIVE_VERSION_PATCH 0
-
-namespace facebook::react {
+#warning "Deprecated: use <React/Utils.h> instead."
 
-struct ReactNativeVersionType {
-  int32_t Major = 1000;
-  int32_t Minor = 0;
-  int32_t Patch = 0;
-  std::string_view Prerelease = "";
-};
+#pragma push_macro("RN_UMBRELLA_CONTEXT")
+#undef RN_UMBRELLA_CONTEXT
+#define RN_UMBRELLA_CONTEXT 1
 
-constexpr ReactNativeVersionType ReactNativeVersion;
+#include <react/utils/ReactNativeVersion.h>
 
-} // namespace facebook::react
+#undef RN_UMBRELLA_CONTEXT
+#pragma pop_macro("RN_UMBRELLA_CONTEXT")

packages/react-native/ReactCommon/react/utils/React/Utils.h

@@ -34,6 +34,7 @@
 #include <react/utils/MoveWrapper.h>
 #include <react/utils/OnScopeExit.h>
 #include <react/utils/PackTraits.h>
+#include <react/utils/ReactNativeVersion.h>
 #include <react/utils/RunLoopObserver.h>
 #include <react/utils/SharedFunction.h>
 #include <react/utils/SimpleThreadSafeCache.h>

packages/react-native/ReactCommon/react/utils/ReactNativeVersion.h

@@ -0,0 +1,32 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @generated by scripts/releases/set-version.js
+ */
+
+#pragma once
+
+#include <react/cxxstableapi/UmbrellaGuard.h>
+
+#include <cstdint>
+#include <string_view>
+
+#define REACT_NATIVE_VERSION_MAJOR 1000
+#define REACT_NATIVE_VERSION_MINOR 0
+#define REACT_NATIVE_VERSION_PATCH 0
+
+namespace facebook::react {
+
+struct ReactNativeVersionType {
+  int32_t Major = 1000;
+  int32_t Minor = 0;
+  int32_t Patch = 0;
+  std::string_view Prerelease = "";
+};
+
+constexpr ReactNativeVersionType ReactNativeVersion;
+
+} // namespace facebook::react

scripts/releases/__tests__/__snapshots__/set-rn-artifacts-version-test.js.snap

@@ -117,7 +117,7 @@ public object ReactNativeVersion {
 "
 `;
 
-exports[`updateReactNativeArtifacts should set nightly version: packages/react-native/ReactCommon/cxxreact/ReactNativeVersion.h 1`] = `
+exports[`updateReactNativeArtifacts should set nightly version: packages/react-native/ReactCommon/react/utils/ReactNativeVersion.h 1`] = `
 "/**
  * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
@@ -129,7 +129,7 @@ exports[`updateReactNativeArtifacts should set nightly version: packages/react-n
 
 #pragma once
 
-#include <react/cxxstableapi/PrivateGuard.h>
+#include <react/cxxstableapi/UmbrellaGuard.h>
 
 #include <cstdint>
 #include <string_view>
@@ -276,7 +276,7 @@ public object ReactNativeVersion {
 "
 `;
 
-exports[`updateReactNativeArtifacts should set release version: packages/react-native/ReactCommon/cxxreact/ReactNativeVersion.h 1`] = `
+exports[`updateReactNativeArtifacts should set release version: packages/react-native/ReactCommon/react/utils/ReactNativeVersion.h 1`] = `
 "/**
  * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
@@ -288,7 +288,7 @@ exports[`updateReactNativeArtifacts should set release version: packages/react-n
 
 #pragma once
 
-#include <react/cxxstableapi/PrivateGuard.h>
+#include <react/cxxstableapi/UmbrellaGuard.h>
 
 #include <cstdint>
 #include <string_view>

scripts/releases/__tests__/__snapshots__/set-version-test.js.snap

@@ -65,7 +65,7 @@ exports[`setVersion updates monorepo for nightly: set-version/packages/react-nat
 
 exports[`setVersion updates monorepo for nightly: set-version/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.kt 1`] = `"[omitted]"`;
 
-exports[`setVersion updates monorepo for nightly: set-version/packages/react-native/ReactCommon/cxxreact/ReactNativeVersion.h 1`] = `"[omitted]"`;
+exports[`setVersion updates monorepo for nightly: set-version/packages/react-native/ReactCommon/react/utils/ReactNativeVersion.h 1`] = `"[omitted]"`;
 
 exports[`setVersion updates monorepo for nightly: set-version/packages/react-native/package.json 1`] = `
 "{
@@ -148,7 +148,7 @@ exports[`setVersion updates monorepo for release-candidate: set-version/packages
 
 exports[`setVersion updates monorepo for release-candidate: set-version/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.kt 1`] = `"[omitted]"`;
 
-exports[`setVersion updates monorepo for release-candidate: set-version/packages/react-native/ReactCommon/cxxreact/ReactNativeVersion.h 1`] = `"[omitted]"`;
+exports[`setVersion updates monorepo for release-candidate: set-version/packages/react-native/ReactCommon/react/utils/ReactNativeVersion.h 1`] = `"[omitted]"`;
 
 exports[`setVersion updates monorepo for release-candidate: set-version/packages/react-native/package.json 1`] = `
 "{
@@ -231,7 +231,7 @@ exports[`setVersion updates monorepo for stable version: set-version/packages/re
 
 exports[`setVersion updates monorepo for stable version: set-version/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.kt 1`] = `"[omitted]"`;
 
-exports[`setVersion updates monorepo for stable version: set-version/packages/react-native/ReactCommon/cxxreact/ReactNativeVersion.h 1`] = `"[omitted]"`;
+exports[`setVersion updates monorepo for stable version: set-version/packages/react-native/ReactCommon/react/utils/ReactNativeVersion.h 1`] = `"[omitted]"`;
 
 exports[`setVersion updates monorepo for stable version: set-version/packages/react-native/package.json 1`] = `
 "{

scripts/releases/set-rn-artifacts-version.js

@@ -104,7 +104,7 @@ function updateSourceFiles(
     fs.writeFile(
       path.join(
         REPO_ROOT,
-        'packages/react-native/ReactCommon/cxxreact/ReactNativeVersion.h',
+        'packages/react-native/ReactCommon/react/utils/ReactNativeVersion.h',
       ),
       require('./templates/ReactNativeVersion.h-template')(templateData),
     ),

scripts/releases/templates/ReactNativeVersion.h-template.js

@@ -23,7 +23,7 @@ module.exports = ({version} /*: {version: Version} */) /*: string */ => `/**
 
 #pragma once
 
-#include <react/cxxstableapi/PrivateGuard.h>
+#include <react/cxxstableapi/UmbrellaGuard.h>
 
 #include <cstdint>
 #include <string_view>