Skip to content

Migrate gRPC schema to miden-protobuf - #2620

Merged
kkovaacs merged 14 commits into
nextfrom
mirko/new-protogen
Sep 17, 2026
Merged

kkovaacs merged 14 commits into
nextfrom
mirko/new-protogen

Conversation

@Mirko-von-Leipzig

@Mirko-von-Leipzig Mirko-von-Leipzig commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Replace the node’s custom protobuf conversion macros and TryFrom implementations with miden-protobuf decoding, verification, and construction traits.

  • Move node-specific domain conversions into miden-node-proto, including TransactionInputs and AuthenticatedTransaction.
  • Consolidate manual response decoding into trait implementations.
  • Verify incoming block signatures and parent linkage before applying block effects.
  • Reject inconsistent account details, duplicate or missing authentication nullifiers, and mismatched account IDs.
  • Preserve field context and error causes in gRPC responses, and enforce request limits before decoding.
  • Update schema annotations and document unchecked construction, caller verification responsibilities, and remaining upstream limitations.

Notably, this also surfaced some problems/gaps in our verification steps. I've added SAFETY comments, some of which indicate fixme's. I plan to address some of these in a separate PR which will come much later given the current workflow. These are existing problems; so the status quo has only improved in this PR imo.

Changelog

changelog = "none"
reason    = "Internal change only."

@Mirko-von-Leipzig
Mirko-von-Leipzig added this pull request to stack #2622 September 14, 2026 13:26
@igamigo
igamigo requested a review from sofiazcoaga September 14, 2026 20:14
Base automatically changed from chore/bump-miden-protocol-0.17.0-rc.4 to next September 15, 2026 13:12
@Mirko-von-Leipzig
Mirko-von-Leipzig marked this pull request as ready for review September 16, 2026 06:13
Comment thread bin/ntx-builder/src/chain_state.rs
Comment thread bin/remote-prover/src/server/prover.rs Outdated
@Mirko-von-Leipzig
Mirko-von-Leipzig removed this pull request from stack #2622 September 16, 2026 10:46

@kkovaacs kkovaacs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@kkovaacs
kkovaacs merged commit 77380ef into next Sep 17, 2026
33 checks passed
@kkovaacs
kkovaacs deleted the mirko/new-protogen branch September 17, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants