Migrate gRPC schema to miden-protobuf - #2620
Merged
Merged
Conversation
Mirko-von-Leipzig
added this pull request to stack #2622
September 14, 2026 13:26
Base automatically changed from
chore/bump-miden-protocol-0.17.0-rc.4
to
next
September 15, 2026 13:12
Mirko-von-Leipzig
force-pushed
the
mirko/new-protogen
branch
from
September 15, 2026 13:53
0771b48 to
5ea089c
Compare
Mirko-von-Leipzig
marked this pull request as ready for review
September 16, 2026 06:13
kkovaacs
reviewed
Sep 16, 2026
Mirko-von-Leipzig
removed this pull request from stack #2622
September 16, 2026 10:46
kkovaacs
approved these changes
Sep 17, 2026
kkovaacs
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the node’s custom protobuf conversion macros and
TryFromimplementations withmiden-protobufdecoding, verification, and construction traits.miden-node-proto, includingTransactionInputsandAuthenticatedTransaction.Notably, this also surfaced some problems/gaps in our verification steps. I've added
SAFETYcomments, some of which indicate fixme's. I plan to address some of these in a separate PR which will come much later given the current workflow. These are existing problems; so the status quo has only improved in this PR imo.Changelog