You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The implementations of these commands are added through this PR.
Code for autocompletion and unit tests, for the respective commands are also added.
To see the documentation of these commands, kindly refer : API Documentation
I've added the test for different cases, like format=nodeId and sshortChannelId as well in 9f6f5fa for the findroute command.
The build will fail right now, since I've modified the EclairClientMocks. I will update the remaining tests once you approve this particular change.
You can individually run the test right now. It's passing for me.
I will update the remaining tests once you approve this particular change.
I'm not sure what particular change you want me to review before finishing the work?
You should simply finish updating the tests and then I'll be able to review it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementations of these commands are added through this PR.
Code for autocompletion and unit tests, for the respective commands are also added.
To see the documentation of these commands, kindly refer : API Documentation