Repository navigation
Read Igor Pro 8 long data-folder names - #30
Merged
paulmueller merged 1 commit intoNov 3, 2026
Merged
Conversation
Record type 101 is a folder start. Its payload is a uint32 byte count followed by that many name bytes, and a type 10 record closes it. Skipping the record dropped the folder and mixed its contents into the parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Igor Pro 8 writes a data-folder start as record type 101 when the name does not fit in the 31-byte type 9 record. The payload is a uint32 byte count followed by exactly that many name bytes. A type 10 record still closes the folder. Type 33 is a 4-byte id after the folder start and stays skipped. In the attached experiment, type 26 is an XOP state marker, not a folder name.
packed.loaddid not know type 101, so those folders never appeared. Their variables and waves were created in the parent. On the experiment attached to #28 that raisesValueError: collision on name K0 in root.This treats type 101 as a folder start. A length that does not match the payload raises
ValueError.The attached
Test.pxpnow loads.USAXScontains 24 sample folders, includingAMC_25_crystalline_04_07_26_10min_0036and the 82-byte name that contains spaces. Each of those folders has its 14 waves. Short type 9 folders are unchanged.coverage run --source=igor2 -m pytest testspassed 20 tests.flake8 --exclude _version.py .passed. The Codecov upload was not run locally.This does not add binary wave version 7. Every wave in the attached file is version 5.