Repository navigation
fix(roleplay): keep the handoff settings within the binding limit - #93
Merged
Merged
Conversation
Cloudflare rejected the release with 129 text bindings against a limit of 128: vars and secrets share the budget, and the two handoff vars pushed it over. ROLEPLAY_HANDOFF_FROM and ROLEPLAY_HANDOFF_TO now live in RUNTIME_FEATURE_FLAGS like the other nonsecret settings, and the roleplay settings read them through runtimeFeatureValue, so a separate var of the same name still takes precedence. The var count pin returns to 65 and now says why it exists.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploying #92 failed at upload: Cloudflare counted 129 text bindings against its limit of 128. Vars and secrets share that budget, and the two new handoff vars pushed the release over.
Change
ROLEPLAY_HANDOFF_FROMandROLEPLAY_HANDOFF_TOmove intoRUNTIME_FEATURE_FLAGS, which already holds the other nonsecret settings for this reason.runtimeFeatureValue, so a separate var of the same name still takes precedence.Verification
wrangler dev.wrangler.jsonc.