Repository navigation
Fix the dependency audits so CI runs the tests again - #94
Merged
Merged
Conversation
npm audit failed on undici 7.29.1, which miniflare pins exactly (wrangler 4.149.0 and the latest 4.152.0 both ship it). An npm override moves it to 7.30.1, which fixes GHSA-4qv8-2p9j-2685, GHSA-f72v-6w45-q472 and GHSA-xjj6-f33q-929c. npm audit now reports 0 vulnerabilities. pip-audit failed on pillow 12.3.0. Both locks move to pillow 13.0.0. None of the APIs Pillow 13 removed or changed are used here. The same audits also flag certifi 2026.4.22 (PYSEC-2026-4320 / GHSA-6q48-6c7w-9gw2) in both locks, and filelock 3.32.4 (CVE-2026-112940, CVE-2026-112913, CVE-2026-112907) in the CI lock, which pip-audit pulls in. certifi moves to 2026.10.19 and filelock to 4.2.1. Every other pin is unchanged.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both CI jobs stopped at their audit step, so the Worker tests and the Python tests never ran on pull requests. This change clears both audits. It touches no source files.
Node audit (undici)
wrangler→miniflare@5.20261006.1-alpha→undici@7.29.1. miniflare pins undici exactly, and the latest wrangler (4.152.0, with miniflare 5.20261019.2-beta) still pins 7.29.1, so bumping wrangler does not help.overridesentry,"undici": "7.30.1", next to the existing@parcel/watcherandsharpoverrides. 7.30.1 fixes GHSA-4qv8-2p9j-2685, GHSA-f72v-6w45-q472 and GHSA-xjj6-f33q-929c.package-lock.jsonchanges only the undici entry.npm audit --audit-level=highnow reports 0 vulnerabilities at every severity.Python audit
requirements.lockandrequirements-ci.lock. This fixes the advisories in the Pillow 13.0.0 security notes, including GHSA-78g4-xqwv-q3g8.requirements-ci.lockonly (CVE-2026-112940, CVE-2026-112913, CVE-2026-112907). It is a dev-tool dependency, pulled in by pip-audit through cachecontrol.uv pip compile --generate-hashesand explicit--upgrade-packagepins. A block-by-block comparison shows that only these packages changed, and the lock headers are unchanged.pip-audit -r requirements.lockandpip-audit -r requirements-ci.lockboth report no known vulnerabilities.Pillow 13 API check
Image handling is in
services/image_quality.py(Image.open,.width/.height,thumbnail,convert("RGB"), JPEG save),tests/test_image_quality.py(Image.frombytes, PNG save) andscripts/generate_favicon(s).py(Image.new,ImageDraw.ellipse, ICO save).get_child_images,Image._show,ImageCmsproduct fields,ExifTags.IFD.Makernote,fromarraymode changes, I-mode PNG saving, orgetcolorwith premultiplied alpha.thumbnail()now appliesreducing_gapto RGBA/LA images, which is a minor resampling difference only.Local results
npm cipasses, andnpm auditreports 0 vulnerabilities.test:worker: 2079/2079.test:deploy: 19/19.wrangler dev --localboots toReady on http://localhost:8799.worker/,routes/,services/,providers/orutils/changed, sotests/outbound_inventory.jsonis unchanged.Follow-up
pnpm-lock.yaml, used by thecloudflare-buildjob, still resolves undici 7.29.0 through wrangler 4.138.0, because pnpm ignores npm'soverrides. That job does not run an audit; this is left for a separate change.