Repository navigation
examples(issue_resolver): rename shared helper to issue_resolver_common and remove GRANDFATHERED_EXAMPLES - #358
Conversation
|
Thanks @mashood-memon, this is the cleanest take on #233 so far. Before merge, please add a one-line note on Once that’s in and CI is green, good to merge, and I will change the assignee on the issue <3 |
15bbf7a to
341d437
Compare
|
Hey @mashood-memon, thanks for addressing the earlier review comments! The core rename and test cleanups look great, but the branch currently has merge conflicts against
Once rebased and CI is green, we will merge this and close #233 and #274. Thank you! |
…on, remove GRANDFATHERED_EXAMPLES (ARPAHLS#233)
…y under Unreleased (ARPAHLS#233)
341d437 to
317afb9
Compare
|
Thanks for the pointers! I have rebased onto current main, moved the changelog entry under ## [Unreleased], updated the catalog page path at docs/skills/dev_tools/issue_resolver.md, and adjusted the helper link depth to ../../../examples/issue_resolver_common.py. All local doc-drift and smoke checks are passing. |
Closes #233
What changed
examples/issue_resolver_github_context.py→examples/issue_resolver_common.pyto match the*_common.pyhelper module conventionexamples/claude_issue_resolver.py,examples/gemini_issue_resolver.py, andexamples/ollama_issue_resolver.pyGRANDFATHERED_EXAMPLESset and TODO comment fromtests/test_registry_docs.py— the existing*_common.pyfilter already excludes helperstests/test_examples_smoke.pyto reference the new filename### Changedentry toCHANGELOG.mdunder[Unreleased]Verification
pytest tests/test_registry_docs.py— 9 passedpytest tests/test_examples_smoke.py— same 5 pre-existing failures (missing optional packages:google,trafilatura,rembg,python-pptx,pillow), no new failures introducedNotes
examples/README.md,docs/usage/agent_loops.md, anddocs/skills/issue_resolver.mddo not referenceissue_resolver_github_context.py— no changes needed there