Repository navigation
chore(types): type ui_schema and version_policy, drop their mypy over… - #417
Merged
rosspeili merged 1 commit intoOct 12, 2026
Merged
Conversation
13 tasks
Contributor
|
Thanks for tackling p1 so cleanly, @UroojFatima-052! The typing fixes look great: One quick thing before we merge: We cut release Once that's rebased, this is ready to merge and you're good to take on phase 2! |
UroojFatima-052
force-pushed
the
chore/issue-415-phase1-mypy
branch
from
October 11, 2026 20:19
c291642 to
de064bb
Compare
Contributor
Author
|
Hey @rosspeili,, Rebased on latest main and moved the entry under [Unreleased] -> ### Changed. I'll start on phase 2 next. |
rosspeili
approved these changes
Oct 12, 2026
rosspeili
left a comment
Contributor
There was a problem hiding this comment.
LGTM @UroojFatima-052, merging as is. Thanks for this clean slice. Will keep #415 open until your last slice, which can close the issue. <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #415
Phase 1: removes
skillware.core.ui_schemaandskillware.version_policyfrom[[tool.mypy.overrides]]and fixes the 4 errors that surfaced. Typing only, no behavior change.Changes
ui_schema.py:84:normalize_fixture_samplesreturnsdict(sample)so the list matches itsList[JsonObject]return type. Fixture samples are JSON objects, so this is a same-content copy.version_policy.py:68, 108:cast(Any, dist.metadata).get(...).PackageMetadatadeclares no.geton Python 3.10 (the configuredpython_version), while the runtime object has it. I kept.getrather than switching to["Name"], since on newer Pythons a missing key there raises instead of returningNone.version_policy.py:77:cast("os.PathLike[str]", dist.locate_file(...)). I avoidedstr(...)so a non-filesystemlocate_fileresult still raises and falls through to the existingexcept, as it does today.pyproject.toml: both modules dropped from the overrides list.CHANGELOG.md: Unreleased entry.Verification
mypy skillware: Success, no issues in 23 filesblack --check/flake8on both files: cleanpytest tests/test_version_policy.py tests/test_card_ui_schema.py: 45 passed