Repository navigation
Correct required English across WoW flavors - #2736
Conversation
- Correct required English spelling and grammar in shared comments, Standard/Forever descriptions, and contributor-tool documentation. - Correct corroborated WoW names while preserving official spellings, accepted variants, identifiers, data relationships, and line endings. - Validate 49 Lua files with Lua 5.1.5 and compare identical stripped bytecode for 38 comment-only files. Preserve executable Python AST and C# text outside documentation and comments. Assisted-by: gpt-6-luna, gpt-6.1-terra, gpt-6.1-sol.
Pending human decisions: one-provider name candidatesThese eight groups cover 13 source locations. The English spelling/context checks below are auxiliary editorial analysis based on ordinary English and the existing source context. They contribute 0 additional WoW providers and do not establish official game names or override contrary evidence. Auxiliary analysis date: 2026-11-06. Each has only one supporting provider; contrary evidence, generic descriptions, and related but different records are not counted as additional support. All source lines remain unchanged. Please review the proposed names and obtain or assess further evidence before applying them. Configured Retail target: 12.1.5.70783; it is not an observed client build.
For the chick, the supported alternative is community wording on Wowhead; the exact NPC tooltip on the same provider supports the original spelling. For the two profession NPCs, both Wowhead URLs are one provider, and the linked Wiki result contradicts the proposed spelling for Leedan Gustaf. The other NPCs mentioned above retain their tooltip spelling. AI Assistance: gpt-6.1-terra and gpt-6.1-sol provided the auxiliary English spelling/context analysis and review. |
There was a problem hiding this comment.
Per-line English audit (1/2)
Scope updated at bc04b28bd60d2feb9dd5d5b08eca64e5dcf3afad: the current diff contains 21 files and 28 changed lines, comprising 12 lines supported by two distinct WoW providers and 16 editorial lines with zero WoW providers. Of the original 82 inline entries, 54 are now explicitly withdrawn, eight are superseded at outdated anchors, and 20 remain current. Eight new comments explain the narrowed corrections at current source lines. All outdated discussions are marked resolved.
The non-English OBJECT locale rows and optional apostrophe, article, punctuation, capitalization, shorthand, and wording edits have been restored to the baseline. Terra and Sol reviewed the reduced source and explanations; this is AI review, not human approval or live-client validation. The eight one-provider candidate groups remain unchanged for human decision.
AI Assistance
gpt-6-luna (max reasoning) implemented the corrections and scope reduction; gpt-6.1-terra performed initial/follow-up review and prepared the scope classification; gpt-6.1-sol performed final review, validation, and PR/comment updates.
| -- }, | ||
| -- Some containers have constant, export, description, lore, model. | ||
| -- Refer to the invidual containers for more info. | ||
| -- Refer to the individual containers for more info. |
There was a problem hiding this comment.
必要修正 / Required · EN3-0002
Change: -- Refer to the invidual containers for more info. → -- Refer to the individual containers for more info.
Reason: English code-comment spelling correction: invidual→individual.
Flavor/context: shared code comment; all flavors
Configured target (not a tested client): N/A; comment-only correction
WoW evidence: 0 providers — English correction only. English spelling/grammar only; surrounding gameplay statements and values are not verified by this correction.
| }), | ||
| -- | ||
| i(239607), -- Charged Cyrstal (QI!) (Reward, required for the Warrant) | ||
| i(239607), -- Charged Crystal (QI!) (Reward, required for the Warrant) |
There was a problem hiding this comment.
必要修正 / Required · EN3-0042
Change: … i(239607), -- Charged Cyrstal (QI!) (Reward, required … → … i(239607), -- Charged Crystal (QI!) (Reward, required …
Reason: Changed “Charged Cyrstal” to “Charged Crystal”. Corrected “Cyrstal” to “Crystal” in the item name; two cited providers support “Charged Crystal”.
Flavor/context: Retail TWW K’aresh;configured12.1.5.70783
Affected records: [{"type": "item", "id": 239607}]
Configured target (not a tested client): 12.1.5.70783 configured Retail target
WoW evidence: 2 distinct providers.
- https://www.wowhead.com/item=239607/charged-crystal
- https://warcraft.wiki.gg/wiki/Charged_Crystal_%28quest%29
Evidence limit: The Wiki does not independently print the itemID; sameK’areshquest/rewardnamecontext supports spelling only.
| -- Unsure | ||
| q(87496, { -- Benefit Packages | ||
| sourceQuests = { 83096 }, -- Welcome to Undermine (TODO: it is up during this quests so should fire inaccurate?) | ||
| sourceQuests = { 83096 }, -- Welcome to Undermine (TODO: it is up during this quest so should fire inaccurate?) |
There was a problem hiding this comment.
必要修正 / Required · EN3-0043
Change: … (TODO: it is up during this quests so should fire inaccurate?) → … (TODO: it is up during this quest so should fire inaccurate?)
Reason: Changed “this quests” to “this quest” to make the noun agree with singular “this”.
Flavor/context: Standard maintained English source; language-only correction
WoW evidence: 0 providers — English correction only. English spelling/grammar only; surrounding gameplay statements and values are not verified by this correction.
There was a problem hiding this comment.
Per-line English audit (2/2)
Scope updated at bc04b28bd60d2feb9dd5d5b08eca64e5dcf3afad: the current diff contains 21 files and 28 changed lines, comprising 12 lines supported by two distinct WoW providers and 16 editorial lines with zero WoW providers. Of the original 82 inline entries, 54 are now explicitly withdrawn, eight are superseded at outdated anchors, and 20 remain current. Eight new comments explain the narrowed corrections at current source lines. All outdated discussions are marked resolved.
The non-English OBJECT locale rows and optional apostrophe, article, punctuation, capitalization, shorthand, and wording edits have been restored to the baseline. Terra and Sol reviewed the reduced source and explanations; this is AI review, not human approval or live-client validation. The eight one-provider candidate groups remain unchanged for human decision.
AI Assistance
gpt-6-luna (max reasoning) implemented the corrections and scope reduction; gpt-6.1-terra performed initial/follow-up review and prepared the scope classification; gpt-6.1-sol performed final review, validation, and PR/comment updates.
| q(43799, { -- Summoned Sheep Exploded | ||
| name = "Summoned Sheep Exploded", | ||
| description = "The next step is pure RNG - when you teleport to your class order hall you have (once a day) chance to trigger a spawn of Volatile Sheep. If it does spawn for you, you will see Cote's dialogue box saying 'Success!' - the sheep will be standing just next to Dalaran portal, all you have to do is to right-click it couple times to make it explode. After you do you'll get another speech box, this time Extemely Volatile Stormheim Sheep bleating '...' - for some reason you can see someone else's sheep dialogue box, so if you see that one in Hall of the guardian without doing previous mob sheeping, means someone just made their sheep explode in the class hall :) As I said this step is pure luck, so it may take some time until you get your sheep to spawn (for me it was around 3 weeks).", | ||
| description = "The next step is pure RNG - when you teleport to your class order hall you have (once a day) chance to trigger a spawn of Volatile Sheep. If it does spawn for you, you will see Cote's dialogue box saying 'Success!' - the sheep will be standing just next to Dalaran portal, all you have to do is to right-click it couple times to make it explode. After you do you'll get another speech box, this time Extremely Volatile Stormheim Sheep bleating '...' - for some reason you can see someone else's sheep dialogue box, so if you see that one in Hall of the guardian without doing previous mob sheeping, means someone just made their sheep explode in the class hall :) As I said this step is pure luck, so it may take some time until you get your sheep to spawn (for me it was around 3 weeks).", |
There was a problem hiding this comment.
必要修正 / Required · EN3-0046
Change: … another speech box, this time Extemely Volatile Stormheim Sheep … → … another speech box, this time Extremely Volatile Stormheim Sheep …
Reason: Changed “Extemely Volatile Stormheim Sheep” to “Extremely Volatile Stormheim Sheep”. Corrected “Extemely” to “Extremely” in the NPC name; two cited providers use “Extremely Volatile Stormheim Sheep”.
Flavor/context: Retail Legion mageartifactdescription;configured12.1.5.70783
Affected records: [{"type": "npc", "id": 111691}]
Configured target (not a tested client): 12.1.5.70783 configured Retail target
WoW evidence: 2 distinct providers.
- https://www.wowhead.com/npc=111691/extremely-volatile-stormheim-sheep
- https://warcraft.wiki.gg/wiki/Extremely_Volatile_Stormheim_Sheep
Evidence limit: NPCname spellingonly; artifactunlockconditions, coordinates and spawnmechanics unchanged and not revalidated.
| n(SPECIAL, sharedData({ | ||
| sharedDescription = "Requires joining another Venthyr player in their Ember Court scenario and interacting with the respective Exalted Guest. You must have your own Ember Court built and the rehearsal court scenario completed before you can pick these quests up.", | ||
| sourceQuest = 59661, -- Ember Court Rehersal | ||
| sourceQuest = 59661, -- Ember Court Rehearsal |
There was a problem hiding this comment.
必要修正 / Required · EN3-0047
Change: … = 59661, -- Ember Court Rehersal → … = 59661, -- Ember Court Rehearsal
Reason: Changed “Ember Court Rehersal” to “Ember Court Rehearsal”. Corrected the quest-name spelling; two cited providers support “Ember Court Rehearsal”.
Flavor/context: Retail; Shadowlands Venthyr; configuredtarget12.1.5.70783
Affected records: [{"type": "quest", "id": 59661}]
Configured target (not a tested client): 12.1.5.70783
WoW evidence: 2 distinct providers.
- https://www.wowhead.com/quest=59661/ember-court-rehearsal
- https://warcraft.wiki.gg/wiki/Ember_Court_Rehearsal
Evidence limit: Wiki contains a separate misspelled scenario subheading Rehersal; quest heading is Rehearsal. Primary Wowhead HTML robot gate; tooltip name retrieved separately.
| traderstender(180, i(238959)), -- Deathwarder's Great Blood Blade | ||
| traderstender(440, iensemble(237224)), -- Ensemble: Attire of the Swift Fox | ||
| traderstender(440, iensemble(237222)), -- Ensemble: Attire of the Woodland Racoon | ||
| traderstender(440, iensemble(237222)), -- Ensemble: Attire of the Woodland Raccoon |
There was a problem hiding this comment.
必要修正 / Required · EN3-0050
Change: … Ensemble: Attire of the Woodland Racoon → … Ensemble: Attire of the Woodland Raccoon
Reason: Changed “Ensemble: Attire of the Woodland Racoon” to “Ensemble: Attire of the Woodland Raccoon”. Corrected the ensemble-name spelling; two cited providers support “Ensemble: Attire of the Woodland Raccoon”.
Flavor/context: Retail; Trading Post11.1.5+; configured Retail target12.1.5.70783
Affected records: [{"type": "item", "id": 237222}]
Configured target (not a tested client): 12.1.5.70783
WoW evidence: 2 distinct providers.
- https://www.wowhead.com/item=237222/ensemble-attire-of-the-woodland-raccoon
- https://warcraft.wiki.gg/wiki/Ensemble%3A_Attire_of_the_Woodland_Raccoon
Evidence limit: Corrects maintained readable comment to current documented ensemble name; does not alter historical PTR names or tradingpost availability.
NORPG
added
area:localization
Restore non-English localization rows and optional English wording changes. Retain spelling corrections, redundant-word repairs, and clear singular/plural agreement fixes. Assisted-by: gpt-6-luna, gpt-6.1-terra, gpt-6.1-sol.
NORPG
left a comment
NORPG
left a comment
There was a problem hiding this comment.
Current-line explanations for narrowed corrections
These eight comments explain only the retained corrections at bc04b28bd60d2feb9dd5d5b08eca64e5dcf3afad. They supersede the eight outdated mixed-edit anchors. The current PR has 28 changed lines across 21 files; the other 20 active explanations remain at their current anchors.
AI Assistance
gpt-6-luna implemented the reduced corrections, gpt-6.1-terra reviewed their scope, and gpt-6.1-sol verified the source and prepared these updated explanations.
| }), | ||
| n(220072, { -- Electrocutioner 6000 | ||
| description = "The main mechanic of this fight comes from Static Arc, this ability does a chain lighting cast on a player and it bounces twice, hitting a total of three players - these get debuffed and cannot be hit by it again twice in a row or the 500% damage increase will kill them.\n\nThe way to deal with it is to have two pre-assigned groups be moving in and out of close proximity to the boss in order to soak every other Static Arc. Doing this will make the mechanic safe. Ideally have the caster damage dealers do this so that the melee can keep up high uptime on the boss. Healers can potentially be assigned for moving in and out as well, but ideally it's important that they can heal freely since the fight has somewhat respectable damage throughout.\n\nLastly, Magnetic Pulse is an ability that must be respected by everyone, if targeted the player must move out to a empty space or pre-assigned spot in order to avoid damaging other players as well. Just be aware that if targeted, the player should not by any means ever be further away from the boss than the groups soaking Static Arc, otherwise you'll get targeted by it instead and potentially killing the players with the debuff that are currently standing near the boss.", | ||
| description = "The main mechanic of this fight comes from Static Arc, this ability does a chain lightning cast on a player and it bounces twice, hitting a total of three players - these get debuffed and cannot be hit by it again twice in a row or the 500% damage increase will kill them.\n\nThe way to deal with it is to have two pre-assigned groups be moving in and out of close proximity to the boss in order to soak every other Static Arc. Doing this will make the mechanic safe. Ideally have the caster damage dealers do this so that the melee can keep up high uptime on the boss. Healers can potentially be assigned for moving in and out as well, but ideally it's important that they can heal freely since the fight has somewhat respectable damage throughout.\n\nLastly, Magnetic Pulse is an ability that must be respected by everyone, if targeted the player must move out to a empty space or pre-assigned spot in order to avoid damaging other players as well. Just be aware that if targeted, the player should not by any means ever be further away from the boss than the groups soaking Static Arc, otherwise you'll get targeted by it instead and potentially killing the players with the debuff that are currently standing near the boss.", |
There was a problem hiding this comment.
必要修正 / Required · EN3-0016
Change: lighting → lightning
Supersedes: The outdated explanation.
Reason: Correct the misspelling lighting to lightning; leave the article unchanged.
Flavor/context: Standard maintained English source; language-only correction
WoW evidence: 0 providers — English correction only. English spelling/grammar only; surrounding gameplay statements and values are not verified by this correction.
| i(1485, { -- Pitchfork | ||
| -- #if AFTER 10.1.7 | ||
| description = "This items only drops from Risen Hillsbrad Farmers, which becomes unavailable to Horde players after completing the Sludge Fields questline due to phasing.\nPhasing can be circumvented with Party Sync, using an Horde alt that haven't reached the quest progress trigger for this phasing, or using an Alliance alt.", | ||
| description = "This item only drops from Risen Hillsbrad Farmers, which becomes unavailable to Horde players after completing the Sludge Fields questline due to phasing.\nPhasing can be circumvented with Party Sync, using an Horde alt that hasn't reached the quest progress trigger for this phasing, or using an Alliance alt.", |
There was a problem hiding this comment.
必要修正 / Required · EN3-0027
Change: This items → This item; haven't reached → hasn't reached
Supersedes: The outdated explanation.
Reason: Correct singular item and singular subject-verb agreement; retain the original article.
Flavor/context: Standard maintained English source; language-only correction
WoW evidence: 0 providers — English correction only. English spelling/grammar only; surrounding gameplay statements and values are not verified by this correction.
|
|
||
| def add_latest_data(build: str) -> None: | ||
| """Adds latest builds to build file and add latest data to raw files""" | ||
| """Adds latest builds to build file and adds latest data to raw files""" |
There was a problem hiding this comment.
必要修正 / Required · EN3-0064
Change: and add latest data → and adds latest data
Supersedes: The outdated explanation.
Reason: Correct subject-verb agreement in add to adds; retain the original articles.
Flavor/context: neutral
WoW evidence: 0 providers — English correction only. English spelling/grammar only; surrounding gameplay statements and values are not verified by this correction.
| """Step 1: Run add_latest_data(build: str) (You have to uncomment) with the build as a string ex. add_latest_data("10.2.5.53441"). """ | ||
| # add_latest_data("") | ||
| """Step 2a: If new SkillLines have has been added they need to be sorted manually. Ex. Language:Furbolg is not a real profession so it has to be added into Exclusion/SkillLines.txt. If its an interesting SkillLine it can be added to Exclusion/SkillLineOther.txt. If its a new profession just let it be""" | ||
| """Step 2a: If new SkillLines have been added they need to be sorted manually. Ex. Language:Furbolg is not a real profession so it has to be added into Exclusion/SkillLines.txt. If its an interesting SkillLine it can be added to Exclusion/SkillLineOther.txt. If its a new profession just let it be""" |
There was a problem hiding this comment.
必要修正 / Required · EN3-0066
Change: have has been added → have been added
Supersedes: The outdated explanation.
Reason: Remove the duplicate auxiliary has; retain the original contractions and punctuation.
Flavor/context: neutral
WoW evidence: 0 providers — English correction only. English spelling/grammar only; surrounding gameplay statements and values are not verified by this correction.
| """Step 3a: Run sort_raw_file_recipes(flavor: str) Choose between Retail or Forever (you have to uncomment it) this will sort raw recipes into respective profession.""" | ||
| # sort_raw_file_recipes("") | ||
| """Step 2b: If new items has been detected. They will be in FastItem.txt please add them to unsorted.""" | ||
| """Step 2b: If new items have been detected. They will be in FastItem.txt please add them to unsorted.""" |
There was a problem hiding this comment.
必要修正 / Required · EN3-0068
Change: items has been detected → items have been detected
Supersedes: The outdated explanation.
Reason: Correct subject-verb agreement from items has to items have; retain original punctuation.
Flavor/context: neutral
WoW evidence: 0 providers — English correction only. English spelling/grammar only; surrounding gameplay statements and values are not verified by this correction.
| """Step 1: Delete questDB.json in DATAS/00 - Item DB folder""" | ||
| """Step 2: Parse Retail with Debug Mode. Change parser config to a PTR patch if you want to account for PTR things.""" | ||
| """Step 3: Run create_missing_files(flavor) and (you have to uncomment it) Choosen between Classic, SoM, SoD, Forever, TBC, WotLK, Cata, MoP, Retail""" | ||
| """Step 3: Run create_missing_files(flavor) and (you have to uncomment it) Choose between Classic, SoM, SoD, Forever, TBC, WotLK, Cata, MoP, Retail""" |
There was a problem hiding this comment.
必要修正 / Required · EN3-0070
Change: Choosen → Choose
Supersedes: The outdated explanation.
Reason: Correct the misspelling Choosen to Choose; retain the original wording and punctuation.
Flavor/context: neutral
WoW evidence: 0 providers — English correction only. English spelling/grammar only; surrounding gameplay statements and values are not verified by this correction.
|
|
||
| def get_name(expansion: str, quest_id: str) -> str: | ||
| """This function try to get the quest name from wowhead. Currently broken""" | ||
| """This function tries to get the quest name from wowhead. Currently broken""" |
There was a problem hiding this comment.
必要修正 / Required · EN3-0071
Change: function try → function tries
Supersedes: The outdated explanation.
Reason: Correct subject-verb agreement from function try to function tries; retain original capitalization and wording.
Flavor/context: neutral
WoW evidence: 0 providers — English correction only. English spelling/grammar only; surrounding gameplay statements and values are not verified by this correction.
|
|
||
| def get_available_expansions(patch: str) -> dict[str, str]: | ||
| """This Function return proper expansion data for the patch""" | ||
| """This Function returns proper expansion data for the patch""" |
There was a problem hiding this comment.
必要修正 / Required · EN3-0072
Change: Function return → Function returns
Supersedes: The outdated explanation.
Reason: Correct subject-verb agreement from Function return to Function returns; retain original capitalization and wording.
Flavor/context: neutral
WoW evidence: 0 providers — English correction only. English spelling/grammar only; surrounding gameplay statements and values are not verified by this correction.
Summary
Data Sources
The following 10 name groups cover the 12 source-supported changed lines. Both linked providers support the documented spelling; context-specific limits are noted below. Sources verify names only, not gameplay, availability, or an observed client build. WoW record comments and descriptions are affected; no IDs were changed.
For Raven Hill Cemetery, the Wiki covers Classic/Retail history and the Wowhead guide corroborates the location spelling in Season of Discovery; neither establishes NPC 771 availability or spawn behavior. The Wiki entry for Hippogryph Harassment corroborates the quest name and Forever context without independently printing the quest ID; the Charged Crystal Wiki entry identifies the related quest reward without independently printing the item ID. The Operation: Mechagon sources establish the dungeon title, not the identity or mechanics of quest 57046. For Ember Court Rehearsal, the Wiki quest title supports the change while a separate scenario subheading retains a different spelling.
Evidence was checked on 2026-11-05–06. No installed ATT version or live client build was observed. The reviewed baseline is
f192fd6c855655e73a141be76f816918a8a82096; the reviewed commit isbc04b28bd60d2feb9dd5d5b08eca64e5dcf3afad.Configured source targets are Retail 12.1.5.70783, Mists 5.5.4.70631, Season of Discovery 1.15.9.70576, and Forever 1.60.1.69893; the Forever Wago extract is 1.60.1.70790. These are configuration or extraction versions, not tested client builds; external sources did not establish a precise build for every observation.
Pending human decisions
Eight one-provider name groups at 13 unchanged source locations are listed directly in the PR conversation, with supporting and contrary evidence, flavor context, and commit-pinned code links. They are held for human decision. Each group also includes an auxiliary English spelling/context check. It contributes 0 additional WoW providers, so every candidate retains 1 supporting provider and remains pending human decision.
Validation and review
bc04b28bd60d2feb9dd5d5b08eca64e5dcf3afad.AI Assistance
AI assistance was used with gpt-6-luna (max reasoning) for implementation and scope reduction, gpt-6.1-terra for initial/follow-up review, scope classification, PR drafting, and auxiliary context analysis, and gpt-6.1-sol for final review, validation, source comparison, auxiliary spelling analysis, and PR/comment updates. The validation and evidence limits are stated above.