Repository navigation
Strip $ suffix from logger names of Scala companion objects - #818
Merged
Merged
Conversation
- Use `this.getClass.getName.stripSuffix("$")` for loggers in Scala objects so log names match class names
- Import `LoggerFactory` explicitly in schedule strategy classes
- Add `log4j2.discardThreshold` to the list of keys not to be printed, since its value (usually `ERROR`) confuses log error scanners
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughLogger initialization now uses class-name strings with a trailing Scala object ChangesLogger Name Normalization
Configuration Redaction Key
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the primary change: removing the $ suffix from logger names in Scala companion objects. |
| Description check | |
The description includes the required Overview, Release Notes, and Related sections. The Release Notes section accurately describes the main change and the description also records the secondary logge… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches: 💡 1
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
🛠️ Fix failing CI checks: 💡
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the logger name,
And trims a little dollar sign.
The config keys get one more guard,
While tidy imports leave the yard.
Then hops away through logs that shine.
Comment @coderabbitai help to get the list of available commands.
|
JaCoCo Coverage Report
Run 38525795884 · Event: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoggerFactoryexplicitly in schedule strategy classeslog4j2.discardThresholdto the list of keys not to be printed, since its value (usuallyERROR) confuses log error scannersOverview
Release Notes
this.getClass.getName.stripSuffix("$")for loggers in Scala objects so log names match class namesRelated
--
Summary by CodeRabbit