Skip to content

feat: support Angular 21 - #10

Merged
fateeand merged 4 commits into
mainfrom
9-widen-angularcommon-and-angularcore-peer-dependencies
Oct 14, 2026
Merged

fateeand merged 4 commits into
mainfrom
9-widen-angularcommon-and-angularcore-peer-dependencies

Conversation

@fateeand

@fateeand fateeand commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Supports Angular 21 alongside Angular 22.

Changes

  • Peer dependencies: @angular/common and @angular/core widened from ^22.1.3 to >=21.0.0 <23.0.0.
  • Build: the workspace now uses Angular 21.0 (and TypeScript 5.9), so the library is built, tested and type-checked with the lowest supported version. Its compiled output can't depend on anything newer, and Angular 22 apps can use a library built with 21.
  • Docs: the README now says "Requires Angular 21 or 22".

Validation

Build, all unit tests, lint, format check and typecheck pass on Angular 21.0.9.

Closes #9

Widens the @angular/common and @angular/core peer range to >=21.0.0 <23.0.0
and adds a CI job that builds a minimal Angular 21.0.x app (TypeScript 5.9)
against the packed library, so the lower bound is verified.
@fateeand fateeand linked an issue Oct 13, 2026 that may be closed by this pull request
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 96.98% 1220/1258
🟢 Branches 95.42% 667/699
🟢 Functions 96.82% 304/314
🟢 Lines 97.36% 1178/1210

Test suite run success

723 tests passing in 23 suites.

Report generated by 🧪jest coverage report action from 80255ce

@lukasmatta lukasmatta left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to also build the library with v21, otherwise it may fail during the runtime.

(in other words we need to downgrade Angular packages to v21 in: https://github.com/AbsaOSS/ui-watchtower/blob/main/package.json)

@fateeand

Copy link
Copy Markdown
Collaborator Author

We need to also build the library with v21, otherwise it may fail during the runtime.

(in other words we need to downgrade Angular packages to v21 in: https://github.com/AbsaOSS/ui-watchtower/blob/main/package.json)

Addressed. The workspace now uses Angular 21.0. That made the separate Angular 21 test app and its CI job redundant, so I removed them.

@fateeand
fateeand merged commit 6ba82de into main Oct 14, 2026
9 checks passed
@fateeand
fateeand deleted the 9-widen-angularcommon-and-angularcore-peer-dependencies branch October 14, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Widen @angular/common and @angular/core peer dependencies

2 participants