Repository navigation
Conversation
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success721 tests passing in 23 suites. Report generated by 🧪jest coverage report action from 91fd57e |
There was a problem hiding this comment.
🔵 Needs a closer look
One or more issues must be addressed before approval.
0 open findings
What changed in this PR
Removes per-event BI event-type overrides so all BI events use {namespace}.bi, updates deduplication and public models, and aligns documentation/tests.
Changes:
- Simplifies
UwtBIEventDetailandUwtBIEvent. - Always emits BI events under the namespace BI type.
- Updates deduplication, tests, and documentation.
| File | Description |
|---|---|
| projects/ngx-ui-watchtower/src/lib/utils/uwt-telemetry-event.util/uwt-telemetry-event.util.ts | Updated as part of this pull request. |
| projects/ngx-ui-watchtower/src/lib/services/uwt-bi-telemetry.service/uwt-bi-telemetry.service.ts | Updated as part of this pull request. |
| projects/ngx-ui-watchtower/src/lib/services/uwt-bi-telemetry.service/uwt-bi-telemetry.service.spec.ts | Updated as part of this pull request. |
| projects/ngx-ui-watchtower/src/lib/models/uwt-bi.models/uwt-bi.models.ts | Updated as part of this pull request. |
| projects/ngx-ui-watchtower/src/lib/config/uwt-bi-telemetry.config/uwt-bi-telemetry.config.ts | Updated as part of this pull request. |
| projects/ngx-ui-watchtower/DESIGN.md | Updated as part of this pull request. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the per-event
eventTypeoverride fromUwtBITelemetryService.track(). Every BI event is now recorded under the single{ns}.bitype, witheventNameas a field.The override existed so dashboards built on older event types could keep working during migration. We don't need that. It also let an event leave the one-type model, and a custom type ending in
.bicouldn't be told apart from a standard BI event.Changes
UwtBIEventDetailno longer haseventType, onlyscenarioIdandfeature. It's now the single interface for these fields; the unexportedUwtBIEventCorrelationit aliased is removed, andUwtBIEventextendsUwtBIEventDetail.{ns}.bi. The event type is no longer part of the duplicate-detection key.unknownkind is now described as "any other event type".{ns}.bi. The delimiter-collision test now usesscenarioIdinstead ofeventType.Breaking change
Callers passing
eventTypeintrack()'s third argument get a TypeScript error and must remove it. Those events are then recorded as{ns}.bi.TODO:
Once released, update the parts of the agentic toolkit skills that describe BI eventType override:
rum-migration.md, the shared API reference and one setup eval.Closes #13