Skip to content

feat: plugin quicktool adapter - #2898

Open
deadlyjack wants to merge 6 commits into
mainfrom
feat/plugin-quicktool
Open

deadlyjack wants to merge 6 commits into
mainfrom
feat/plugin-quicktool

Conversation

@deadlyjack

@deadlyjack deadlyjack commented Sep 14, 2026

Copy link
Copy Markdown
Member
  • allow plugin to adapt quicktool
  • allow plugin to hook save, save event
  • fix icon size in file explorer
  • feat: icon button tooltip

- allow plugin to adapt quicktool
- allow plugin to hook save, save event
- fix icon size in file explorer
@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no new actionable failures remain from the changes since the previous review.

Findings

  1. P1 Clean Cache Hides Changes

Summary

This PR adds a plugin-facing quick-tools adapter, custom-tab save hooks, filesystem-provider-aware restoration, recovery-cache conflict protection, and long-press icon tooltips.

  • Routes quick-tool actions, modifiers, focus, availability, and overlay cancellation through registered adapters.
  • Extends custom tabs with asynchronous save-event handling and integrates them with standard save commands.
  • Improves restored-file loading, cache durability, provider registration, and external-change detection.
  • Adds delegated icon tooltips and adjusts file-browser icon presentation.
  • Adds broad unit coverage for adapters, save events, restoration, overlays, and tooltip interactions.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  P[Plugin custom tab] --> A[Quick-tools adapter]
  Q[Quick-tools UI] --> A
  A --> D[Dispatch text, key, command, or modifier]
  D --> P
  P --> S[Custom save event]
  E[Editor file] --> S
  S --> C{Plugin responds?}
  C -->|Yes| R[Await plugin save result]
  C -->|No, editor tab| F[Verify source and write through provider]
  F --> K[Update saved state and recovery cache]
  R --> U[Emit workspace save update]
  K --> U
Loading

Reviews (6) · Last reviewed commit: "fix: load file from cache or defer loadi..."

Comment thread src/handlers/quickTools.js
@deadlyjack

This comment was marked as outdated.

Comment thread src/handlers/quickTools.js Outdated
Comment thread src/handlers/quickToolsInit.js Outdated
Comment thread src/lib/quickToolsAdapter.js Outdated
Comment thread src/lib/commands.js Outdated
Comment thread docs/file-save-events.md Outdated
@deadlyjack

This comment was marked as outdated.

Comment thread src/lib/acode.js
- improve tooltip bug and visibility
- UI issues
@deadlyjack

This comment was marked as outdated.

Comment thread src/lib/editorFile.js Outdated
Replace the startup wait with generic cache-first restoration and provider registration notifications. Preserve cached documents and keep uncached tabs idle until their filesystem becomes available.
@deadlyjack

Copy link
Copy Markdown
Member Author

@greptile review

Comment thread src/lib/editorFile.js
@deadlyjack

Copy link
Copy Markdown
Member Author

@greptile review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs enhancement New feature or request

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants