Prevent parent addon localization from replacing library strings - #22
Open
aleksandr-kotlyar wants to merge 1 commit into
Open
aleksandr-kotlyar wants to merge 1 commit into
aleksandr-kotlyar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Some addon packaging paths process localization markers inside embedded externals with the parent addon project ID. That injects unrelated strings into LibMagicUtil locale files. Parent projects with multiline keys can then produce invalid Lua and stop loading, as seen in BulkMail2Inbox.
Committing the generated LibMagicUtil locale snapshots removes the ambiguous packaging step while retaining the library translations.
Validation
Related