Repository navigation
feat: Ultra theme names - prefer culture over generic and error handling - #1642
Conversation
|
/review |
There was a problem hiding this comment.
Solid isolation fix. Verified that the 'Ultra' set key matches the 'Ultra' entry in global.culture_styles (globals.gml:193), that the praenomen/nomen/cognomen composites work with the 'complex' preferred method exactly like the existing 'Roman' set, and that no culture selection can leave ChapterMemberNameGeneration without a result (empty selection defaults to space_marine, and the '_name == ""' fallback to imperial_male covers cultures without registered name sets). The per-entry try/catch in the loader loop follows the established pattern for user-editable config (name_loader.json) and fails soft via ERROR_HANDLER, which is available at that point of the boot sequence. Only minor nits below, nothing blocking.
Summary by cubic
Preference for culture-specific name styles: the Ultra culture gets its own composite Roman-style name set, and culture-selected names now override the generic space marine fallback instead of being mixed in with it.
ultraas a composite name set (praenomen + nomen + cognomen) inname_loader.jsonand added it to the game project.space_marinenames only load as a fallback when no culture styles are selected; previouslyspace_marinewas always included.Written for commit a07fdc9. Summary will update on new commits.