Repository navigation
Conversation
|
/review |
There was a problem hiding this comment.
Overall LGTM on the wiring. Verified:
- New name_loader.json entry is correctly structured;
load_as: "Mechanical Cult"exactly matches the existing culture style in global.culture_styles (globals.gml:189) and the visual culture entries (scr_culture_visuals.gml:660), andpreffered_method: "complex"routes through ComplexTitledName as with Roman/Ultra/Knightly. - mechanical_cult.json parses as strict JSON, all names are valid identifiers (no spaces/odd casing/NaN), ASCII-compliant (banned-symbols rule satisfied), no duplicates within either list, format matches sibling files in names/ (2-space indent, no trailing newline).
- The complex-method quirk of the second name being skipped 50% of the time (NameGenerator.gml:140-143) is consistent with all other complex sets.
Data quality concerns (not blockers, but worth addressing):
- 12 entries appear in BOTH first_name and second_name, so full names like "Stronos Stronos" or "Ferrum Ferrum" are generatable (~1% of two-part outputs). Recommend removing these duplicates from one list.
- 236 of 519 second names (45%) are "Cog"+word compounds, and many read as parody ("Cogquaternity", "Cogquintessence", "Cogpostulate", "Coglimit", "Coginfinity"). This heavily skews generated surnames toward one prefix and dilutes the otherwise good themed content. Suggest curating this block down to entries that read as plausible Mechanicus surnames.
Leaving as COMMENT since the name content quality needs maintainer taste, not just correctness.
| "Cogduality", | ||
| "Cogtrinity", | ||
| "Cogquaternity", | ||
| "Cogquintessence" |
There was a problem hiding this comment.
236 of 519 second names (~45%) are "Cog"+word compounds, and many read as parody: "Cogquaternity", "Cogquintessence", "Cogpostulate", "Cogtheorem", "Coglimit", "Coginfinity", "Cogfellowship", "Cogbattlement", "Cogossuary".
This dominates generated surnames (almost half of two-part names) and undercuts the good lore-accurate content elsewhere in the list (Cawl, Feirros, Stronos, Scoria, Forge-, Ferrum-). Suggest trimming this block to entries that pass as plausible Mechanicus surnames, and consider renaming some survivors to non-Cog forms (e.g. "Cogquintessence" -> "Quintessentius").
Summary by cubic
Adds cultural name sets for the Mechanical Cult, so their characters generate with appropriately themed names.
name_loader.jsonusing the existing first/second name composite system.Written for commit 3df544b. Summary will update on new commits.