Skip to content

feat: Flame Cult cultural names - #1647

Merged
OH296 merged 1 commit into
Adeptus-Dominus:mainfrom
OH296:flame_Cult
Oct 21, 2026
Merged

OH296 merged 1 commit into
Adeptus-Dominus:mainfrom
OH296:flame_Cult

Conversation

@OH296

@OH296 OH296 commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by cubic

Adds Flame Cult cultural names to the name generation system, available for character creation where cultural naming is supported. Includes 732 first and second names and registers the Flame Cult name set in the name loader.

Written for commit 76c1de2. Summary will update on new commits.

View guided diff

@github-actions github-actions Bot added Area: JSON Changes to external JSON files or their under-the-hood functionality Size: Big Type: Feature Adds something new labels Oct 21, 2026
@OH296

OH296 commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator Author

/review

@lyra-cactus lyra-cactus Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data-only PR: registers a "Flame Cult" name set (355 first_names + 371 second_names, all unique) and wires it into the complex "first_name"/"second_name" pattern already used by Gladiator/Runic.

Verified:

  • Both JSON files parse; ASCII-only; no trailing-newline regressions in name_loader.json.
  • load_as: "Flame Cult" exactly matches the existing culture entry in global.culture_styles (scripts/globals/globals.gml:188) and the visual set (scripts/scr_culture_visuals/scr_culture_visuals.gml:2004), so ChapterMemberNameGeneration()/get_name_set() will resolve it. With preffered_method: "complex", ComplexTitledName(composite_names) gets the right composite_components keys, so names generate (second_name is included ~50% of the time, same as Gladiator/Runic - consistent behavior).
  • Record count is 726 names (732 was the file's line count); the PR description is slightly off but harmless.

Pre-existing note (not a blocker, this PR extends it): the hardcoded fallback in scripts/NameGenerator/NameGenerator.gml:174-232 does not include flame_cult (nor knightly/roman/mongol/gladiator/runic/ultra). If main/name_loader.json is missing or unparseable, selecting Flame Cult silently falls back to imperial_male names. Worth syncing that array in a follow-up.

Otherwise LGTM; just two content nits inline.

Comment thread datafiles/main/names/flame_cult.json
Comment thread datafiles/main/names/flame_cult.json
@OH296
OH296 merged commit 6bdc847 into Adeptus-Dominus:main Oct 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: JSON Changes to external JSON files or their under-the-hood functionality Size: Big Type: Feature Adds something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant