Repository navigation
feat: Flame Cult cultural names - #1647
Merged
Merged
Conversation
Collaborator
Author
|
/review |
Contributor
There was a problem hiding this comment.
Data-only PR: registers a "Flame Cult" name set (355 first_names + 371 second_names, all unique) and wires it into the complex "first_name"/"second_name" pattern already used by Gladiator/Runic.
Verified:
- Both JSON files parse; ASCII-only; no trailing-newline regressions in name_loader.json.
load_as: "Flame Cult"exactly matches the existing culture entry inglobal.culture_styles(scripts/globals/globals.gml:188) and the visual set (scripts/scr_culture_visuals/scr_culture_visuals.gml:2004), soChapterMemberNameGeneration()/get_name_set()will resolve it. Withpreffered_method: "complex",ComplexTitledName(composite_names)gets the rightcomposite_componentskeys, so names generate (second_name is included ~50% of the time, same as Gladiator/Runic - consistent behavior).- Record count is 726 names (732 was the file's line count); the PR description is slightly off but harmless.
Pre-existing note (not a blocker, this PR extends it): the hardcoded fallback in scripts/NameGenerator/NameGenerator.gml:174-232 does not include flame_cult (nor knightly/roman/mongol/gladiator/runic/ultra). If main/name_loader.json is missing or unparseable, selecting Flame Cult silently falls back to imperial_male names. Worth syncing that array in a follow-up.
Otherwise LGTM; just two content nits inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds Flame Cult cultural names to the name generation system, available for character creation where cultural naming is supported. Includes 732 first and second names and registers the Flame Cult name set in the name loader.
Written for commit 76c1de2. Summary will update on new commits.