Add support for named data type parameters - #321
Open
blinkzz wants to merge 1 commit into
Open
Conversation
git-hulk
reviewed
Sep 9, 2026
git-hulk
left a comment
git-hulk
left a comment
Member
There was a problem hiding this comment.
Looks good, one comment to guard the nil pointer.
| return false | ||
| } | ||
| peekToken, err := p.lexer.peekToken() | ||
| return err == nil && peekToken.Kind == TokenKindSingleEQ |
Member
There was a problem hiding this comment.
Also check that peekToken is nil to avoid the panic:
Suggested change
| return err == nil && peekToken.Kind == TokenKindSingleEQ | |
| return err == nil && peekToken != nil && peekToken.Kind == TokenKindSingleEQ |
Member
|
@blinkzz Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for named data type parameters (for example
Dynamic(max_types = n))This PR introduces new AST type of
TypeWithNamedParamswith corresponding visitor, traversal and formatter integrationMost popular use case for this is a standalone columns generated from nested JSON