Skip to content

Send vanity redirects with Cache-Control: no-store - #229

Merged
willwashburn merged 1 commit into
mainfrom
fix/vanity-redirect-no-store
Oct 18, 2026
Merged

willwashburn merged 1 commit into
mainfrom
fix/vanity-redirect-no-store

Conversation

@willwashburn

@willwashburn willwashburn commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

The router's edge 302 for every vanity alias (/will, /khaliq, /founder, /meet-with-*, /virtual-office) carries Cache-Control: no-store, the same header the Next.js /founder route handler sets. /founder picks a founder calendar at random per request, and an uncached redirect is what keeps each visit an independent draw.

The vanity redirect test asserts the header on every alias.

🤖 Generated with Claude Code


Note

Low Risk
Small behavioral change to redirect response headers only; no routing or destination logic changes.

Overview
Edge vanity alias redirects (/will, /khaliq, /founder, /meet-with-*, /virtual-office) no longer use Response.redirect; they return an explicit 302 with Cache-Control: no-store so intermediaries cannot cache the redirect. That matters especially for /founder, which picks between two calendar URLs at random per request—a cached 302 would lock visitors to one founder.

The vanity redirect integration test now expects cache-control: no-store on every alias in the parameterized case.

Reviewed by Cursor Bugbot for commit 4f4783e. Bugbot is set up for automated code reviews on this repo. Configure here.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Sends the router's edge 302s for vanity aliases (/will, /khaliq, /founder, /meet-with-*, /virtual-office) with Cache-Control: no-store so a cached redirect never pins a visitor to one /founder calendar. The vanity redirect test now asserts the header.

Written for commit 4f4783e. Summary will update on new commits.

View guided diff Turn on auto-fix


Agent Relay sessions

  • claude session 23f84d9c · opened via gh pr create · last active 2026-10-16

The router's edge 302s for /will, /khaliq, /founder and the other vanity
aliases carry Cache-Control: no-store, matching the Next.js /founder
handler. A cached 302 would pin a visitor to one founder's calendar.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T00:14:34.894945Z 4f4783e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f65d8d68-5799-40a8-998b-87ab86785cae
📥 Commits

Reviewing files that changed from the base of the PR and between d3121da and 4f4783e.

📒 Files selected for processing: 2
  • router/index.ts
  • router/test/vanity-redirects.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The /founder vanity redirect now returns a 302 response with Cache-Control: no-store. The edge redirect test checks the response header.

Changes: Vanity redirect cache behavior

Layer / File(s) Summary
Set and verify redirect cache policy
router/index.ts, router/test/vanity-redirects.test.ts
The /founder redirect returns a 302 response with Cache-Control: no-store. The edge redirect test asserts the header.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: khaliqgant

Merge Risk: ⚪ Minimal · up to 4f478

The vanity redirects return with caching disabled, including /founder. No actionable merge risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: adding Cache-Control: no-store to vanity redirects.
Description check Passed The description directly explains the redirect header change, its purpose for /founder, and the corresponding test update.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the redirect’s trail
No stored response can linger there
A 302 points the way ahead
The test confirms the header is set
Then hops away beneath the moon

Comment @coderabbitai help to get the list of available commands.

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

Open in Capy

@github-actions

Copy link
Copy Markdown
Contributor

Preview deployed!

Environment URL
Web https://1a7a53e5-agentrelay-web.agent-workforce.workers.dev

This is a Cloudflare Workers preview version of this PR's build.

@willwashburn
willwashburn merged commit 391f826 into main Oct 18, 2026
5 checks passed
@willwashburn
willwashburn deleted the fix/vanity-redirect-no-store branch October 18, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant