Repository navigation
Send vanity redirects with Cache-Control: no-store - #229
Conversation
The router's edge 302s for /will, /khaliq, /founder and the other vanity aliases carry Cache-Control: no-store, matching the Next.js /founder handler. A cached 302 would pin a visitor to one founder's calendar. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
Preview deployed!
This is a Cloudflare Workers preview version of this PR's build. |
The router's edge 302 for every vanity alias (
/will,/khaliq,/founder,/meet-with-*,/virtual-office) carriesCache-Control: no-store, the same header the Next.js/founderroute handler sets./founderpicks a founder calendar at random per request, and an uncached redirect is what keeps each visit an independent draw.The vanity redirect test asserts the header on every alias.
🤖 Generated with Claude Code
Note
Low Risk
Small behavioral change to redirect response headers only; no routing or destination logic changes.
Overview
Edge vanity alias redirects (
/will,/khaliq,/founder,/meet-with-*,/virtual-office) no longer useResponse.redirect; they return an explicit 302 withCache-Control: no-storeso intermediaries cannot cache the redirect. That matters especially for/founder, which picks between two calendar URLs at random per request—a cached 302 would lock visitors to one founder.The vanity redirect integration test now expects
cache-control: no-storeon every alias in the parameterized case.Reviewed by Cursor Bugbot for commit 4f4783e. Bugbot is set up for automated code reviews on this repo. Configure here.
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Sends the router's edge 302s for vanity aliases (
/will,/khaliq,/founder,/meet-with-*,/virtual-office) withCache-Control: no-storeso a cached redirect never pins a visitor to one/foundercalendar. The vanity redirect test now asserts the header.Written for commit 4f4783e. Summary will update on new commits.
Agent Relay sessions
claudesession23f84d9c· opened viagh pr create· last active 2026-10-16