Repository navigation
fix(ci): pin npm to a Node-compatible version for publishing - #39
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe publish workflow now installs npm 11.6.2 instead of ChangesPublishing npm version
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~7 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The publishing workflow meets the documented Node, npm, and OIDC requirements, with no material merge-blocking risk identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the publish train Comment |
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
The publish job failed with
EBADENGINEbecausenpm@latestresolved to npm 12.2.0, which requires a newer Node version than the workflow's pinned 22.14.0.Pin npm to 11.10.1, which supports Node 22.14.0 and OIDC trusted publishing and includes the dependency-resolution fix from npm/cli#8981. An exact version prevents future npm releases from changing the publish job's engine requirements. Includes the compacted work trajectory.
Failed job: https://github.com/AgentWorkforce/trajectories/actions/runs/36965687439/job/110708930403
Validation:
actionlint -shellcheck=; full actionlint's 14 shell warnings also exist in the unchanged workflow.git diff --checkpassed.Live OIDC publishing has not been exercised; it requires GitHub Actions.
Note
Low Risk
CI-only change to the global npm version in the publish job; no application runtime or auth logic changes.
Overview
Fixes publish workflow failures caused by
npm@latestpulling npm 12.2.0, which does not satisfy the job’s pinned Node 22.14.0 (EBADENGINE).The Update npm for OIDC support step in
publish.ymlnow installsnpm@11.10.1instead of latest, with a short comment that this version keeps OIDC trusted publishing while staying within the Node engine range. The exact pin avoids future npm releases changing engine requirements mid-publish.Also adds compacted agent trajectory artifacts (
.agentworkforce/trajectories/compacted/fix-publish-npm-engine.*) recording the decision to use 11.10.1 over an earlier 11.6.2 pin.Reviewed by Cursor Bugbot for commit 71a40e0. Bugbot is set up for automated code reviews on this repo. Configure here.