Fix WITH using a CSV source to close #1276 - #2557
Open
harsh-thakkar7 wants to merge 1 commit into
Open
harsh-thakkar7 wants to merge 1 commit into
harsh-thakkar7 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix WITH using a CSV source (#1276)
Problem
WITH ... SELECT * FROM CSV('<file>', {headers:true})throws:The CSV source is loaded from file asynchronously (
loadFile), butyy.WithSelect.prototype.executecalledw.select.execute(databaseid, params)without a callback, so the temporary table'sdatawas stillundefinedwhen the outer select joined/read it.Fix
WithSelect.executenow executes each non-recursive CTE with a completion callback: the temporary table is populated once the subquery finishes, and the next CTE / outer select only runs afterwards. Synchronous CTE queries complete during the call, so the sync path is unchanged and existing WITH tests are unaffected (submitted tests + existing CTE tests pass).Tests
Added
test/test1276.jswith 4 cases:SELECT * FROM CSV("./test/test1276.csv", ...)baselineWITH c AS (SELECT * FROM CSV(...)) SELECT * FROM cBecause the bug is triggered by the async path, the tests assert via
alasql.promise(as the original repro usedalasqlwith callbacks/then).Closes #1276