Repository navigation
feat(LayoutPagesController): find layout pages by page layout - #227
Merged
Merged
Conversation
Layout pages are usually referenced by their page layout, because their urlname is derived from a name editors can change. The show endpoint only found pages by id or urlname, so clients had to use the index endpoint with a page_layout_eq filter instead. Unlike show, index does not run load_page, so apps that hook into it to preload ingredient related objects could not do so for layout pages. Falling back to the page layout in the show endpoints of both the public and the admin controller lets clients request e.g. /jsonapi/layout_pages/footer directly. Lookups by id and urlname still take precedence, so existing requests are unaffected.
This was referenced Oct 27, 2026
Closed
Closed
Merged
tvdeyen
added a commit
that referenced
this pull request
Oct 27, 2026
## Release v8.4.0 <!-- Release notes generated using configuration in .github/release.yml at main --> ## What's Changed ### New Features * feat(serializer): lazy-load relationship data by default by @tvdeyen in #203 * feat(PageSerializer): expose robot_index and robot_follow attributes by @mamhoff in #223 * feat(LayoutPagesController): find layout pages by page layout by @mamhoff in #227 ### Bug Fixes * fix(IngredientPictureSerializer): Use picture_url by @tvdeyen in #214 ### Performance Improvements * feat: Cache ingredient serializers by @tvdeyen in #186 * Route element visibility through ElementsRepository by @tvdeyen in #196 * refactor: load elements through core's shared element repository by @tvdeyen in #199 * perf(Elements/Ingredients): Do not serialize timestamps by @mamhoff in #229 ## New Contributors * @github-actions[bot] made their first contribution in #212 **Full Changelog**: v8.2.2...v8.4.0 --- This PR was automatically created by the prepare-release workflow. Once merged, the gem will be automatically published to RubyGems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layout pages are usually referenced by their page layout, because their urlname is derived from a name editors can change. The show endpoint only found pages by id or urlname, so clients had to use the index endpoint with a page_layout_eq filter instead.
Unlike show, index does not run load_page, so apps that hook into it to preload ingredient related objects could not do so for layout pages. Falling back to the page layout in the show endpoints of both the public and the admin controller lets clients request e.g. /jsonapi/layout_pages/footer directly. Lookups by id and urlname still take precedence, so existing requests are unaffected.