Repository navigation
Conversation
✅ Deploy Preview for alchemy-guides canceled.
|
tvdeyen
force-pushed
the
definitions-module
branch
from
October 30, 2026 13:30
9450308 to
4f493d7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tvdeyen
force-pushed
the
definitions-module
branch
from
October 30, 2026 14:29
4f493d7 to
db9b5d6
Compare
tvdeyen
force-pushed
the
definitions-module
branch
3 times, most recently
from
October 30, 2026 21:47
cd55228 to
39fbc03
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4431 +/- ##
=======================================
Coverage 98.41% 98.42%
=======================================
Files 371 373 +2
Lines 9845 9880 +35
=======================================
+ Hits 9689 9724 +35
Misses 156 156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tvdeyen
force-pushed
the
definitions-module
branch
from
October 31, 2026 11:03
39fbc03 to
02cc75d
Compare
Helps to visualize the usage of the page.
The resource table wrapper was sized to the full height of the main content although the resources header sits above it, and the lazy loaded pages tree used a viewport based height that ignored the main content padding and the collapsing margin of its heading. Both made the main content scrollable even when everything fit on screen.
Editors who want to know what a page type offers had to find it in the definitions module themselves. Linking the page type from the page info dialog opens the definitions filtered to and scrolled to that page type.
Global pages are only edited as layout parts and never visited by URL, so mixing them with regular page types made the list harder to scan. Content page types now come first and global page types second, each under its own heading in the sidebar.
tvdeyen
force-pushed
the
definitions-module
branch
2 times, most recently
from
October 31, 2026 13:49
d97e635 to
85ff1c1
Compare
Searching hid every page type without a match, so the overview of all page types disappeared while looking for an element. A dedicated page type filter now narrows the definitions while the sidebar always lists every page type, and the search only highlights page type and element names on top of it. The page info dialog links to the filtered page type directly.
tvdeyen
force-pushed
the
definitions-module
branch
from
October 31, 2026 13:59
85ff1c1 to
332728d
Compare
tvdeyen
changed the title
tvdeyen
marked this pull request as ready for review
October 31, 2026 14:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Page types and elements are defined in YAML by developers, but editors have no way to see in the admin what a page type offers, which elements can be placed on it, or how often those elements are actually used. This adds a read-only Definitions module, available from the main menu for authors and above, that lists every page type with its hint, labels, an optional preview image and its available elements, including nested elements and their ingredients. Each element shows how often it is used on draft versions of that page type next to its total across all page types, so it becomes visible what is really in use before a definition gets changed.
The sidebar always lists all page types, grouped into content pages and global pages. A filter button narrows the definitions to a single page type, while the search box highlights matching page type and element names on top of that and unfolds elements whose nested elements match. The page type in the page info dialog links straight to its filtered definition.
Notable changes
Page definitions accept a new
imageoption inpage_layouts.yml, which is shown as a preview in the module. The usage numbers come from two grouped queries instead of one count per element, because large installations render hundreds of them on this page.While building the layout this also fixes a needless scrollbar on the resource index pages and the pages tree, which were sized taller than the visible area. The ingredient types of the Spree extension get their model name translations in alchemy-solidus itself, see AlchemyCMS/alchemy-solidus#159. New translations are English only for now.
Screenshots
Checklist