Repository navigation
[8.4-stable] fix(preview): Only exchange messages with the preview frame - #4432
Merged
Merged
Conversation
The admin posted to the preview with "*" and accepted messages from any window, so any frame or opener could focus element editors and every page loaded into the preview received the messages. Taking the target origin from the preview's ready message keeps this working when the frontend lives on another origin or redirects, without trusting other senders. (cherry picked from commit 2021581) # Conflicts: # app/assets/builds/alchemy/alchemy_admin.min.js # app/assets/builds/alchemy/alchemy_admin.min.js.map
3 tasks done
tvdeyen
approved these changes
Oct 31, 2026
tvdeyen
enabled auto-merge
October 31, 2026 11:05
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.4-stable #4432 +/- ##
===========================================
Coverage 98.43% 98.43%
===========================================
Files 369 369
Lines 9831 9831
===========================================
Hits 9677 9677
Misses 154 154
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.4-stable:Questions ?
Please refer to the Backport tool documentation