MFT: Fix negative capacity tori - #15746
Merged
Merged
Conversation
The twelve `Torus2` and `TorusW2` volumes of the heat exchanger were defined with a negative delta-phi. ROOT does not normalise this value, resulting in a negative volume capacity. As a consequence, no points were found inside these volumes and neither the pipe bends nor the water contributed any material. The sectors are now defined as the equivalent positive 270°–90° sector. This is the intended quadrant, and the torus ends now match exactly the adjacent `Tube2` and `Tube3` end faces for all six half/disk combinations. The change also makes the geometry exportable to GDML, which Geant4 rejects when a torus has a negative delta-phi. https://its.cern.ch/jira/browse/O2-7153
sawenzel
requested review from
f3sch,
fprino,
mconcas,
mcoquet642 and
shahor02
as code owners
September 1, 2026 13:16
Collaborator
|
Error while checking build/O2/fullCI_slc9 for cf7b078 at 2026-09-01 20:15: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The twelve
Torus2andTorusW2volumes of the heat exchanger were defined with a negative delta-phi. ROOT does not normalise this value, resulting in a negative volume capacity. As a consequence, no points were found inside these volumes and neither the pipe bends nor the water contributed any material.The sectors are now defined as the equivalent positive 270°–90° sector. This is the intended quadrant, and the torus ends now match exactly the adjacent
Tube2andTube3end faces for all six half/disk combinations.The change also makes the geometry exportable to GDML, which Geant4 rejects when a torus has a negative delta-phi.
https://its.cern.ch/jira/browse/O2-7153