Skip to content

MFT: Fix negative capacity tori - #15746

Merged
sawenzel merged 1 commit into
AliceO2Group:devfrom
sawenzel:swenzel/mft-torus-quadrant
Sep 1, 2026
Merged

MFT: Fix negative capacity tori#15746
sawenzel merged 1 commit into
AliceO2Group:devfrom
sawenzel:swenzel/mft-torus-quadrant

Conversation

@sawenzel

@sawenzel sawenzel commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

The twelve Torus2 and TorusW2 volumes of the heat exchanger were defined with a negative delta-phi. ROOT does not normalise this value, resulting in a negative volume capacity. As a consequence, no points were found inside these volumes and neither the pipe bends nor the water contributed any material.

The sectors are now defined as the equivalent positive 270°–90° sector. This is the intended quadrant, and the torus ends now match exactly the adjacent Tube2 and Tube3 end faces for all six half/disk combinations.

The change also makes the geometry exportable to GDML, which Geant4 rejects when a torus has a negative delta-phi.

https://its.cern.ch/jira/browse/O2-7153

The twelve `Torus2` and `TorusW2` volumes of the heat exchanger were defined
with a negative delta-phi. ROOT does not normalise this value, resulting in a
negative volume capacity. As a consequence, no points were found inside these
volumes and neither the pipe bends nor the water contributed any material.

The sectors are now defined as the equivalent positive 270°–90° sector. This is
the intended quadrant, and the torus ends now match exactly the adjacent `Tube2`
and `Tube3` end faces for all six half/disk combinations.

The change also makes the geometry exportable to GDML, which Geant4 rejects when
a torus has a negative delta-phi.

https://its.cern.ch/jira/browse/O2-7153
@sawenzel sawenzel changed the title Give the MFT cooling pipe bends their material back MFT: Fix negative capacity tori Sep 1, 2026
@sawenzel
sawenzel merged commit e25003a into AliceO2Group:dev Sep 1, 2026
7 of 10 checks passed
@sawenzel
sawenzel deleted the swenzel/mft-torus-quadrant branch September 1, 2026 17:46
@alibuild

alibuild commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for cf7b078 at 2026-09-01 20:15:

## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./sim-challenge.log[1535:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./sim-challenge.log[1535:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./sim-challenge.log[1535:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./sim-challenge.log[1535:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./sim-challenge.log[1535:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./sim-challenge.log[1535:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./sim-challenge.log[1535:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./sim-challenge.log[1535:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./sim-challenge.log[1535:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./sim-challenge.log[1535:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./sim-challenge.log[1477:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./sim-challenge.log[1477:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./sim-challenge.log[1477:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./sim-challenge.log[1477:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./sim-challenge.log[1477:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./sim-challenge.log[1477:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./sim-challenge.log[1477:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./sim-challenge.log[1477:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./sim-challenge.log[1477:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./sim-challenge.log[1477:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./sim-challenge.log[1622:TPCDigitizer_1]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./sim-challenge.log[1622:TPCDigitizer_1]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./sim-challenge.log[1622:TPCDigitizer_1]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./sim-challenge.log[1622:TPCDigitizer_1]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./sim-challenge.log[1622:TPCDigitizer_1]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./sim-challenge.log[1622:TPCDigitizer_1]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./sim-challenge.log[1622:TPCDigitizer_1]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./sim-challenge.log[1622:TPCDigitizer_1]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./sim-challenge.log[1622:TPCDigitizer_1]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./sim-challenge.log[1622:TPCDigitizer_1]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./sim-challenge.log[1448:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./sim-challenge.log[1448:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./sim-challenge.log[1448:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./sim-challenge.log[1448:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./sim-challenge.log[1448:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./sim-challenge.log[1448:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./sim-challenge.log[1448:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./sim-challenge.log[1448:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants