Fix out-of-range hit access in the TOF hit merging - #15747
Merged
Conversation
This fixes a crash in TOF ProcessHits when the first step of an event cannot be assigned to a pad. - Geo::getIndex returns -1 when the position does not resolve to a valid sector/plate/strip. - mLastChannelID is -1 at the start of every event, so channel == mLastChannelID holds, the || does not short-circuit, and mHits->back() is called on an empty vector, giving "free(): invalid pointer". - The merging condition now requires a non-empty hit vector and a valid channel, so an off-pad step always starts a new hit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
noferini
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash in TOF ProcessHits when the first step of an event cannot be assigned to a pad.