TRD geometry simplification - #15751
Open
sawenzel wants to merge 7 commits into
Open
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
… time Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…17 gas pipe Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
f3sch
approved these changes
Sep 2, 2026
bazinski
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the geometry simplification series. TRD is the largest contributor of logical volumes in the ALICE geometry, and almost all of them are duplicates.
Gspospcreates a newTGeoVolumeon every call, so two parametrised placements per MCM with compile-time-constant parameters produced 7296 identical tubes per supermodule, each carrying a run-time-shaped water core. The baseline counts confirm it:UTCPandUTCHtogether are 15504 of the 17678 volumes and describe 7 distinct shapes.The first six commits share those volumes, write out the dimensions that the Geant3
-1convention resolved at run time, and build twelve chamber shapes instead of thirty. Each was verified separately againstdev:devdevIdentical means all 11 fields of 912639
TRDHitfrom 200 seeded muon events, plus 200k sampled points agreeing on material, density and medium in the ideal and the aligned geometry. The overlap count stays at 183 and every alignable ROC entry still resolves.The last commit is a fix rather than a cleanup: the −x gas pipe of sector 17 placed the Xe core instead of the steel tube, so it has had no wall since the AliRoot port, and
TRD_Fegoes from 0 % to 4.7 % in a 1.6 cm sphere around it. It moves 98 hits, which is why it is kept separate from the six neutral commits.