[PWGJE] Add Berkeley tree producer - #17666
Merged
Merged
Conversation
|
O2 linter results: ❌ 1 errors, |
github-actions
Bot
changed the title
mhwang285
force-pushed
the
convert-mc
branch
2 times, most recently
from
August 31, 2026 03:13
ee108bc to
6e4f0a0
Compare
mhwang285
added a commit
to mhwang285/O2Physics
that referenced
this pull request
Aug 31, 2026
Please consider the following formatting changes to AliceO2Group#17666
mhwang285
marked this pull request as ready for review
August 31, 2026 17:47
mhwang285
requested review from
alibuild,
fjonasALICE,
jaimenorman,
mhemmer-cern and
nzardosh
as code owners
August 31, 2026 17:47
nzardosh
approved these changes
Sep 1, 2026
| berkeleytree::GenE, | ||
| berkeleytree::GenCharge, | ||
| berkeleytree::GenMcId, | ||
| berkeleytree::PdgId); |
Collaborator
There was a problem hiding this comment.
probably this is fine but not sure if the Id keyword causes any issues later for the merger if it thinks its an index coloumn
Author
There was a problem hiding this comment.
Hmm, I see, do you think it triggers on the letters "Id" being anywhere in the column name? I can't really think of another name to use that wouldn't contain "Id" somewhere in it...
nzardosh
enabled auto-merge (squash)
September 1, 2026 07:46
Author
|
thanks @nzardosh , the required checks say (for me at least) "Security: approval needed, not starting", do you know how we can get these to start? (might be because this is my first O2Physics PR) |
Collaborator
|
They should start running soon :) Btw can you update your username here to your CERN one please? |
Collaborator
Collaborator
|
Error while checking build/O2Physics/code-check for e438805 at 2026-09-01 13:34: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a task to produce BerkeleyTrees for MC events for further analysis in the Berkeley HPC systems. In our testing the resulting compression factor is around 80, so we'd like to merge this in and test on Hyperloop and see if we can produce standard derived data with this task. (O2 linter are unrelated to this task)