[PWGEM,Photon] Fix VDriftManager update call - #17673
Open
mhemmer-cern wants to merge 1 commit into
Open
Conversation
Currently the VDriftManager was called in an extra function `updateCCDB`. This function is called for each collision, which results in a lot of LOG spam. This commit updates `init`, `initCCDB` and `updateCCDB`. In the `init` function we now initialize the VDriftManger just once with the `BasicCCDBManager`. In the `initCCDB` we get the magnetic field from either CCDB or override value and set it for `KFParticle` and the `Propagator`. Here we also call `setMatLUT` if needed. The init CCDB is also only called once now at the beginning with the very first BC. In the `updateCCDB` function we now check if the timestamp is different than before and update the VDrift if it's different. Then we check the run number of the BC and update the magnetic filed with the filed from the current run.
mhemmer-cern
requested review from
alibuild,
amaringarcia,
dsekihat,
hscheid,
jokonig and
reygers
as code owners
August 31, 2026 09:43
|
O2 linter results: ❌ 31 errors, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the VDriftManager was called in an extra function
updateCCDB. This function is called for each collision, which results in a lot of LOG spam.This commit updates
init,initCCDBandupdateCCDB.In the
initfunction we now initialize the VDriftManger just once with theBasicCCDBManager.In the
initCCDBwe get the magnetic field from either CCDB or override value and set it forKFParticleand thePropagator. Here we also callsetMatLUTif needed. The init CCDB is also only called once now at the beginning with the very first BC.In the
updateCCDBfunction we now check if the timestamp is different than before and update the VDrift if it's different. Then we check the run number of the BC and update the magnetic filed with the filed from the current run.