Skip to content

[PWGLF] Add conditional event processing for histograms - #17681

Closed
njacazio wants to merge 1 commit into
masterfrom
njacazio-patch-1
Closed

[PWGLF] Add conditional event processing for histograms#17681
njacazio wants to merge 1 commit into
masterfrom
njacazio-patch-1

Conversation

@njacazio

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwglf label Aug 31, 2026
@github-actions github-actions Bot changed the title Add conditional event processing for histograms [PWGLF] Add conditional event processing for histograms Aug 31, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 30 warnings, 🔕 0 disabled

@vkucera

vkucera commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

@njacazio Please stop using the central repository for pushing your personal branches.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for f6dadda at 2026-08-31 23:42:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 11 errors and 202 warnings.'
Found 11 errors and 202 warnings.
++ [[ 11 -gt 0 ]]
++ cat /sw/BUILD/1610b209a5ee47ff11f596811ed3c3d14ead06ab/O2Physics-code-check/errors.txt
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:79:8: error: constructor does not initialize these fields: nBinspT, hEffpTEta_proton, hEffpTEta_antiproton, hEffpTEta_deuteron, hEffpTEta_antideuteron, ccdb, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:220:5: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:476:38: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:573:38: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:681:11: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:757:97: error: the parameter 'filepath' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:757:115: error: the parameter 'histname' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:764:24: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:769:28: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:774:26: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:779:30: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
++ [[ 202 -gt 0 ]]
++ cat /sw/BUILD/1610b209a5ee47ff11f596811ed3c3d14ead06ab/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:646:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:649:77: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:759:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:822:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:824:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:827:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:829:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:831:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:833:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:836:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:899:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:901:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:903:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:905:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:908:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:910:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:914:87: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:916:87: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:921:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:923:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:928:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:930:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:941:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:943:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:945:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:947:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:950:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:952:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:956:87: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@njacazio
njacazio enabled auto-merge (squash) September 1, 2026 03:30
@njacazio
njacazio disabled auto-merge September 1, 2026 03:34
@njacazio njacazio closed this Sep 1, 2026
@njacazio
njacazio deleted the njacazio-patch-1 branch September 1, 2026 04:22
@njacazio

njacazio commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

Handled in #17690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants