Skip to content

[PWGHF,PWGJE] Add INEL > 0 to event selection utils - #17687

Open
DelloStritto wants to merge 9 commits into
AliceO2Group:masterfrom
DelloStritto:master
Open

[PWGHF,PWGJE] Add INEL > 0 to event selection utils#17687
DelloStritto wants to merge 9 commits into
AliceO2Group:masterfrom
DelloStritto:master

Conversation

@DelloStritto

@DelloStritto DelloStritto commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot changed the title Adding inel0 event selection to HF [PWGHF,PWGJE] Adding inel0 event selection to HF Aug 31, 2026
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 16 errors, ⚠️ 9 warnings, 🔕 29 disabled

@alibuild alibuild mentioned this pull request Aug 31, 2026
Merged
DelloStritto added a commit to DelloStritto/O2Physics that referenced this pull request Aug 31, 2026
@DelloStritto
Merge pull request #18 from alibuild/alibot-cleanup-17687
3e6a97f 
[PWGHF,PWGJE] Please consider the following formatting changes to AliceO2Group#17687
@alibuild

alibuild commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 3e6a97f at 2026-08-31 20:42:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 172 errors and 173 warnings.'
Found 172 errors and 173 warnings.
++ [[ 172 -gt 0 ]]
++ cat /sw/BUILD/d8b355e43300918f49d13d7d75ee19aa487fdcdd/O2Physics-code-check/errors.txt
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:197:78: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:492:50: error: the parameter 'selectedTracksPion' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:1448:16: error: the variable 'trackSoftPion' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference [performance-unnecessary-copy-initialization,-warnings-as-errors]
PWGHF/D2H/TableProducer/dataCreatorHiddenCharmReduced.cxx:93:64: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/D2H/TableProducer/dataCreatorJpsiHadReduced.cxx:107:65: error: variable 'partlyRecoDecayMapMuMu' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGHF/D2H/TableProducer/dataCreatorJpsiHadReduced.cxx:113:65: error: variable 'partlyRecoDecayMapEE' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGHF/D2H/TableProducer/dataCreatorJpsiHadReduced.cxx:1016:12: error: no header providing "TESTBIT" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/D2H/Tasks/taskCd.cxx:269:15: error: member 'cmToMum' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGHF/D2H/Tasks/taskDs.cxx:71:34: error: variable 'metadataInfo' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGHF/D2H/Tasks/taskDs.cxx:141:71: error: variable 'channelsResonant' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGHF/D2H/Tasks/taskNetCharmFluctuations.cxx:136:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGHF/D2H/Tasks/taskPtFlucCharmHadrons.cxx:70:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGHF/TableProducer/candidateCreator2Prong.cxx:426:37: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreator2Prong.cxx:460:26: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreator2Prong.cxx:464:29: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreator3Prong.cxx:147:93: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreator3Prong.cxx:519:37: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreator3Prong.cxx:581:28: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreator3Prong.cxx:585:28: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreator3Prong.cxx:591:29: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreator3Prong.cxx:597:28: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreator3Prong.cxx:601:28: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreator3Prong.cxx:615:27: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreator3Prong.cxx:620:27: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorSigmac0plusplus.cxx:84:70: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:87:8: error: constructor does not initialize these fields: lut [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:663:7: error: uninitialized record type: 'pVecCascAsD' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:663:7: error: uninitialized record type: 'pVecCharmBachAsD' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:728:13: error: variable 'phi' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:728:18: error: variable 'theta' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:975:24: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:982:13: error: variable 'massLam' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:982:22: error: variable 'sigMassLam' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:1010:26: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:1016:13: error: variable 'massCasc' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:1016:23: error: variable 'sigMassCasc' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:1016:36: error: variable 'massCascRej' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:1016:49: error: variable 'sigMassCascRej' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:1034:31: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:1061:33: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:1067:13: error: variable 'massCharmBaryon' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:1067:30: error: variable 'sigMassCharmBaryon' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for af8c481 at 2026-08-31 19:42:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera requested changes Aug 31, 2026
View reviewed changes
Comment thread PWGHF/Utils/utilsEvSelHf.h Outdated
Comment thread PWGHF/Utils/utilsEvSelHf.h Outdated
Comment thread PWGHF/Utils/utilsEvSelHf.h Outdated
@vkucera vkucera changed the title [PWGHF,PWGJE] Adding inel0 event selection to HF [PWGHF,PWGJE] Add INEL > 0 to event selection utils Aug 31, 2026
@github-actions github-actions Bot changed the title [PWGHF,PWGJE] Add INEL > 0 to event selection utils [PWGHF,PWGJE] Add INEL > 0 to event selection utils Aug 31, 2026
nzardosh
nzardosh previously approved these changes Sep 1, 2026
View reviewed changes
vkucera
vkucera previously approved these changes Sep 1, 2026
View reviewed changes
@vkucera
vkucera enabled auto-merge (squash) September 1, 2026 08:48
@vkucera

vkucera commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Thanks @DelloStritto !

nzardosh
nzardosh reviewed Sep 1, 2026
View reviewed changes

@nzardosh nzardosh left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few of these process functions have the table twice. Not sure if it causes an issue but probably better to remove :)

Comment thread PWGHF/D2H/TableProducer/dataCreatorCharmResoToDstarReduced.cxx Outdated
Comment thread PWGHF/D2H/Tasks/taskDs.cxx Outdated
Comment thread PWGHF/D2H/Tasks/taskDs.cxx Outdated
auto-merge was automatically disabled September 1, 2026 09:05

Head branch was pushed to by a user without write access

@alibuild alibuild mentioned this pull request Sep 1, 2026
Merged
DelloStritto and others added 6 commits September 1, 2026 11:11
@DelloStritto
Merge pull request #19 from alibuild/alibot-cleanup-17687
f0757d3 
[PWGHF,PWGJE] Please consider the following formatting changes to AliceO2Group#17687
@DelloStritto @vkucera
Apply suggestion from @vkucera
28fd093 
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
@DelloStritto @vkucera
Apply suggestion from @vkucera
a863136 
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
@DelloStritto @vkucera
Apply suggestion from @vkucera
0d91be7 
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
@DelloStritto
Update taskDs.cxx
6bffa31
@DelloStritto
Update dataCreatorCharmResoToDstarReduced.cxx
bd44858
@vkucera

vkucera commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

a few of these process functions have the table twice. Not sure if it causes an issue but probably better to remove :)

Thanks, didn't see it.

@nzardosh
nzardosh self-requested a review September 1, 2026 09:46
@alibuild

alibuild commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for d722552 at 2026-09-01 13:26:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzardosh nzardosh nzardosh approved these changes
@vkucera vkucera vkucera left review comments
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner
@jaimenorman jaimenorman Awaiting requested review from jaimenorman jaimenorman is a code owner
@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@xinyepeng xinyepeng Awaiting requested review from xinyepeng xinyepeng is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwghf PWG-HF pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DelloStritto @alibuild @vkucera @nzardosh