[PWGLF] Fix code-checker warnings

[njacazio]

No description provided.

[github-actions]

O2 linter results: ❌ 1 errors, ⚠️ 1 warnings, 🔕 0 disabled

[njacazio]

Hi @mpuccio apologies ! I pushed some more fixes, now it should be fine

[mpuccio]

No worries!

[alibuild]

Error while checking build/O2Physics/code-check for 43444b7 at 2026-09-01 09:23:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

[alibuild]

Error while checking build/O2Physics/staging for 42b74bc at 2026-09-01 10:09:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:527:3: error: control reaches end of non-void function [-Werror=return-type]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:622:3: error: control reaches end of non-void function [-Werror=return-type]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:622:3: error: control reaches end of non-void function [-Werror=return-type]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:527:3: error: control reaches end of non-void function [-Werror=return-type]
ninja: build stopped: subcommand failed.

Full log here.

[alibuild]

Error while checking build/O2Physics/o2 for 42b74bc at 2026-09-01 10:27:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:527:3: error: control reaches end of non-void function [-Werror=return-type]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:622:3: error: control reaches end of non-void function [-Werror=return-type]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:622:3: error: control reaches end of non-void function [-Werror=return-type]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:527:3: error: control reaches end of non-void function [-Werror=return-type]
ninja: build stopped: subcommand failed.

Full log here.

[alibuild]

Error while checking build/O2Physics/code-check for 42b74bc at 2026-09-01 10:36:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 20 errors and 222 warnings.'
Found 20 errors and 222 warnings.
++ [[ 20 -gt 0 ]]
++ cat /sw/BUILD/e5a7c232e697b48be460ead7631e3c11d0a68099/O2Physics-code-check/errors.txt
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:44:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:246:35: error: moving a temporary object prevents copy elision [clang-diagnostic-pessimizing-move,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:247:35: error: moving a temporary object prevents copy elision [clang-diagnostic-pessimizing-move,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:249:39: error: moving a temporary object prevents copy elision [clang-diagnostic-pessimizing-move,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:250:39: error: moving a temporary object prevents copy elision [clang-diagnostic-pessimizing-move,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:252:35: error: moving a temporary object prevents copy elision [clang-diagnostic-pessimizing-move,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:253:35: error: moving a temporary object prevents copy elision [clang-diagnostic-pessimizing-move,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:255:39: error: moving a temporary object prevents copy elision [clang-diagnostic-pessimizing-move,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:256:39: error: moving a temporary object prevents copy elision [clang-diagnostic-pessimizing-move,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:462:38: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:527:3: error: non-void function does not return a value in all control paths [clang-diagnostic-return-type,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:557:38: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:622:3: error: non-void function does not return a value in all control paths [clang-diagnostic-return-type,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:664:11: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:740:97: error: the parameter 'filepath' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:740:115: error: the parameter 'histname' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:747:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:752:27: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:757:25: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:762:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
++ [[ 222 -gt 0 ]]
++ cat /sw/BUILD/e5a7c232e697b48be460ead7631e3c11d0a68099/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:451:17: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:457:17: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:466:15: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:472:15: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:480:15: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:486:15: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:499:17: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:505:17: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:515:13: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:521:13: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:546:17: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:552:17: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:561:15: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:567:15: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:575:15: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:581:15: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:594:17: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:600:17: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:610:13: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:616:13: warning: do not use 'else' after 'return' [readability-else-after-return]
[0 more errors; see full log]

Full log here.

[njacazio]

Thanks to @vkucera for suggesting me how to implement the fixes locally!