Skip to content

[Trigger,PWGEM] add QA plots for global muons - #17700

Merged
dsekihat merged 1 commit into
AliceO2Group:masterfrom
dsekihat:swt
Sep 1, 2026
Merged

[Trigger,PWGEM] add QA plots for global muons#17700
dsekihat merged 1 commit into
AliceO2Group:masterfrom
dsekihat:swt

Conversation

@dsekihat

@dsekihat dsekihat commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

[Trigger] add QA plots for global muons

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 7 errors, ⚠️ 45 warnings, 🔕 0 disabled

@alibuild

alibuild commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 551c391 at 2026-09-01 17:27:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 7 errors and 4 warnings.'
Found 7 errors and 4 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/b701bb23ff18e78b6166daff962c537b5e950041/O2Physics-code-check/errors.txt
EventFiltering/PWGEM/globalDimuonFilter.cxx:63:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:192:24: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:234:135: error: no header providing "M_PI" is directly included [misc-include-cleaner,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:415:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:602:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:684:22: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:690:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/b701bb23ff18e78b6166daff962c537b5e950041/O2Physics-code-check/warnings.txt
EventFiltering/PWGEM/globalDimuonFilter.cxx:59:10: warning: inclusion of deprecated C++ header 'stdint.h'; consider using 'cstdint' instead [modernize-deprecated-headers]
EventFiltering/PWGEM/globalDimuonFilter.cxx:190:11: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
EventFiltering/PWGEM/globalDimuonFilter.cxx:191:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
EventFiltering/PWGEM/globalDimuonFilter.cxx:366:9: warning: do not use 'else' after 'return' [readability-else-after-return]
++ [[ 7 -gt 0 ]]
++ exit 1
--

Full log here.

@dsekihat dsekihat changed the title [Trigger] add QA plots for global muons [Trigger,PWGEM] add QA plots for global muons Sep 1, 2026
@dsekihat
dsekihat enabled auto-merge (squash) September 1, 2026 16:51

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@dsekihat
dsekihat merged commit 8f530a6 into AliceO2Group:master Sep 1, 2026
13 of 17 checks passed
@dsekihat
dsekihat deleted the swt branch September 1, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants