Skip to content

[DPG] Use const& and std::move to avoid copies - #17704

Open
vkucera wants to merge 1 commit into
AliceO2Group:masterfrom
vkucera:const-DPG
Open

[DPG] Use const& and std::move to avoid copies#17704
vkucera wants to merge 1 commit into
AliceO2Group:masterfrom
vkucera:const-DPG

Conversation

@vkucera

@vkucera vkucera commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Mostly done automatically by Clang-Tidy.

Mostly done automatically by Clang-Tidy.
@github-actions github-actions Bot added the dpg label Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 280 errors, ⚠️ 175 warnings, 🔕 60 disabled

@github-actions github-actions Bot changed the title Use const& and std::move to avoid copies [DPG] Use const& and std::move to avoid copies Sep 1, 2026
@vkucera
vkucera marked this pull request as ready for review September 1, 2026 15:53
@alibuild

alibuild commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for f675b45 at 2026-09-01 23:50:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 152 errors and 557 warnings.'
Found 152 errors and 557 warnings.
++ [[ 152 -gt 0 ]]
++ cat /sw/BUILD/78bdf915c42202c73024265bb87be40db0365f9e/O2Physics-code-check/errors.txt
DPG/Tasks/AOTEvent/detectorOccupancyQa.cxx:56:8: error: constructor does not initialize these fields: ccdb, nOrbits, minOrbit [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
DPG/Tasks/AOTEvent/detectorOccupancyQa.cxx:165:30: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
DPG/Tasks/AOTEvent/detectorOccupancyQa.cxx:186:20: error: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
DPG/Tasks/AOTEvent/detectorOccupancyQa.cxx:414:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
DPG/Tasks/AOTEvent/detectorOccupancyQa.cxx:415:32: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
DPG/Tasks/AOTEvent/detectorOccupancyQa.cxx:418:21: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
DPG/Tasks/AOTEvent/detectorOccupancyQa.cxx:457:7: error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
DPG/Tasks/AOTEvent/detectorOccupancyQa.cxx:941:31: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
DPG/Tasks/AOTEvent/detectorOccupancyQa.cxx:948:30: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:68:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:114:52: error: conditional operator with identical true and false expressions [bugprone-branch-clone,-warnings-as-errors]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:114:61: error: 'true' and 'false' expressions are equivalent [misc-redundant-expression,-warnings-as-errors]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:116:52: error: conditional operator with identical true and false expressions [bugprone-branch-clone,-warnings-as-errors]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:116:61: error: 'true' and 'false' expressions are equivalent [misc-redundant-expression,-warnings-as-errors]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:535:36: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:538:36: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:937:36: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:941:36: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:1017:26: error: narrowing conversion from 'double' to 'int64_t' (aka 'long') [bugprone-narrowing-conversions,-warnings-as-errors]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:1140:36: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:1143:36: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:1178:27: error: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
DPG/Tasks/AOTEvent/rofOccupancyQa.cxx:47:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
DPG/Tasks/AOTEvent/rofOccupancyQa.cxx:820:36: error: narrowing conversion from 'float' to 'value_type' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
DPG/Tasks/AOTEvent/rofOccupancyQa.cxx:883:42: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
DPG/Tasks/AOTEvent/rofOccupancyQa.cxx:884:39: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/TOF/qaPIDTOFDynamic.cxx:50:8: error: constructor does not initialize these fields: tofResponse, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/TOF/qaPIDTOFEvTime.cxx:251:31: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/TOF/qaPIDTOFEvTime.cxx:439:7: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/TOF/qaPIDTOFEvTime.cxx:440:7: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/TOF/qaPIDTOFEvTime.cxx:441:7: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/TOF/qaPIDTOFEvTime.cxx:442:7: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/TOF/qaPIDTOFEvTime.cxx:443:7: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/TOF/qaPIDTOF.cxx:671:69: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/TOF/qaPIDTOF.cxx:691:73: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
DPG/Tasks/AOTTrack/V0Cascades/perfK0sResolution.cxx:78:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
DPG/Tasks/AOTTrack/V0Cascades/perfK0sResolution.cxx:139:67: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
DPG/Tasks/AOTTrack/qaEfficiency.cxx:97:46: error: variable 'hPtIts' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
DPG/Tasks/AOTTrack/qaEfficiency.cxx:98:46: error: variable 'hPtTpc' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
DPG/Tasks/AOTTrack/qaEfficiency.cxx:99:46: error: variable 'hPtItsTpc' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
DPG/Tasks/AOTTrack/qaEfficiency.cxx:100:46: error: variable 'hPtItsTof' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
DPG/Tasks/AOTTrack/qaEfficiency.cxx:101:46: error: variable 'hPtTpcTof' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants