Skip to content

[PWGLF] Remove cascade wrong hypothesis assignments in strangenesstofpid - #17720

Merged
romainschotter merged 1 commit into
AliceO2Group:masterfrom
romainschotter:fix-strangenesstofpid
Sep 1, 2026
Merged

[PWGLF] Remove cascade wrong hypothesis assignments in strangenesstofpid#17720
romainschotter merged 1 commit into
AliceO2Group:masterfrom
romainschotter:fix-strangenesstofpid

Conversation

@romainschotter

Copy link
Copy Markdown
Collaborator

Removed assignments of -999. for wrong hypotheses in nSigma calculations
--> already assigned by default in the cascTofInfo struct

Removed assignments of -999. for wrong hypotheses in nSigma calculations.
@github-actions github-actions Bot added the pwglf label Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 23 errors, ⚠️ 33 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Remove cascade wrong hypothesis assignments in strangenesstofpid [PWGLF] Remove cascade wrong hypothesis assignments in strangenesstofpid Sep 1, 2026
@romainschotter
romainschotter marked this pull request as ready for review September 1, 2026 21:10
@romainschotter
romainschotter enabled auto-merge (squash) September 1, 2026 21:10

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild

alibuild commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5c96f3e at 2026-09-01 23:32:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 58 errors and 42 warnings.'
Found 58 errors and 42 warnings.
++ [[ 58 -gt 0 ]]
++ cat /sw/BUILD/145d11401cc9018b0e11ee1a729394fece85fe97/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:91:8: error: constructor does not initialize these fields: ccdb, mTOFResponse, nSigmaCalibLoaded, mRunNumber, d_bz, maxSnp, maxStep [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:221:18: error: member 'bcShiftValuePS' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:281:5: error: uninitialized record type: 'mom' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:284:5: error: uninitialized record type: 'startPoint' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:293:11: error: variable 'sna' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:293:16: error: variable 'csa' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:676:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:677:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:678:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:679:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:680:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:681:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:683:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:684:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:685:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:686:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:687:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:688:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:708:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:709:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:710:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:711:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:712:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:713:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:714:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:715:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:716:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:717:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:719:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:720:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:721:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:722:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:723:30: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:724:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:725:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:726:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:727:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:728:30: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:930:11: error: variable 'velocityPositiveEl' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:930:31: error: variable 'velocityPositivePr' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:930:51: error: variable 'velocityPositivePi' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:930:71: error: variable 'lengthPositive' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@romainschotter
romainschotter merged commit d36bf81 into AliceO2Group:master Sep 1, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants