Skip to content

[ALICE3] adjustment in the ACTS to O2 translator - #17751

Open
lhusova wants to merge 1 commit into
AliceO2Group:masterfrom
lhusova:alice3TransDev
Open

[ALICE3] adjustment in the ACTS to O2 translator#17751
lhusova wants to merge 1 commit into
AliceO2Group:masterfrom
lhusova:alice3TransDev

Conversation

@lhusova

@lhusova lhusova commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

adjust the translator to the new ACTS output + clean up

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 3 errors, ⚠️ 92 warnings, 🔕 0 disabled

@github-actions github-actions Bot added the alice3 label Sep 3, 2026
@github-actions github-actions Bot changed the title ALICE3: adjustment in the ACTS to O2 translator [ALICE3] adjustment in the ACTS to O2 translator Sep 3, 2026
@njacazio
njacazio enabled auto-merge (squash) September 3, 2026 12:03
@alibuild

alibuild commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 25bb661 at 2026-09-03 16:23:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 15 errors and 8 warnings.'
Found 15 errors and 8 warnings.
++ [[ 15 -gt 0 ]]
++ cat /sw/BUILD/5b502e7ec2c1c2bf875143756fac446af9d96b0c/O2Physics-code-check/errors.txt
ALICE3/TableProducer/alice3TrackingTranslator.cxx:30:1: error: included header HistogramSpec.h is not used directly [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:49:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:60:9: error: variable 'inputPath' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:105:9: error: function-like macro 'SETADDRESS' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:106:44: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:107:58: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:111:5: error: constructor does not initialize these fields: mTree [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:135:91: error: std::move of the const variable 'filename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:135:112: error: std::move of the const variable 'treename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:212:88: error: std::move of the const variable 'filename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:212:109: error: std::move of the const variable 'treename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:324:87: error: std::move of the const variable 'filename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:324:108: error: std::move of the const variable 'treename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:364:20: error: variable 'file' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:365:22: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/5b502e7ec2c1c2bf875143756fac446af9d96b0c/O2Physics-code-check/warnings.txt
ALICE3/TableProducer/alice3TrackingTranslator.cxx:333:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:334:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:493:34: warning: use 'contains' to check for membership [readability-container-contains]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:498:37: warning: use 'contains' to check for membership [readability-container-contains]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:500:15: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:672:31: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:674:13: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:737:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
++ [[ 15 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants