Skip to content

[PWGCF] NaN fill averted for v22 and v02 in v02 analysis - #17753

Open
MaximVirta wants to merge 2 commits into
AliceO2Group:masterfrom
MaximVirta:V02
Open

[PWGCF] NaN fill averted for v22 and v02 in v02 analysis#17753
MaximVirta wants to merge 2 commits into
AliceO2Group:masterfrom
MaximVirta:V02

Conversation

@MaximVirta

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 6 warnings, 🔕 3 disabled

jaelpark
jaelpark previously approved these changes Sep 3, 2026
@jaelpark
jaelpark enabled auto-merge (squash) September 3, 2026 12:14
@vkucera
vkucera disabled auto-merge September 3, 2026 12:24
@vkucera

vkucera commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

@MaximVirta @jaelpark The PR title is too vague. Please add info about the location.

@MaximVirta MaximVirta changed the title [PWGCF] NaN fill averted [PWGCF] NaN fill averted for v22 and v02 histograms Sep 3, 2026
@alibuild

alibuild commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 2d30a02 at 2026-09-03 14:38:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 56 warnings.'
Found 2 errors and 56 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/c378bd55b907eda1ca85f6ac251a96a4c97738bd/O2Physics-code-check/errors.txt
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:862:47: error: no header providing "std::isnan" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:862:68: error: no header providing "std::isinf" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 56 -gt 0 ]]
++ cat /sw/BUILD/c378bd55b907eda1ca85f6ac251a96a4c97738bd/O2Physics-code-check/warnings.txt
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:509:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:517:29: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:645:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:673:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:688:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:697:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:706:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:715:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:717:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:808:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:813:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:817:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:819:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:821:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:823:52: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:825:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:840:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:842:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:844:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1033:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1035:146: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1037:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1057:102: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1059:102: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1061:102: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1066:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1068:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1072:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1074:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1078:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1080:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1084:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1085:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1087:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1088:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1090:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1091:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1093:36: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@vkucera

vkucera commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

@MaximVirta @jaelpark The PR title is too vague. Please add info about the location.

The title still does not say anything about which file, analysis, or tool is affected by the PR.

@MaximVirta MaximVirta changed the title [PWGCF] NaN fill averted for v22 and v02 histograms [PWGCF] NaN fill averted for v22 and v02 in v02 analysis Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants