Skip to content

[PWGCF] Fix includes - #17788

Merged
ariedel-cern merged 2 commits into
AliceO2Group:masterfrom
vkucera:iwyu-PWGCF
Sep 9, 2026
Merged

[PWGCF] Fix includes#17788
ariedel-cern merged 2 commits into
AliceO2Group:masterfrom
vkucera:iwyu-PWGCF

Conversation

@vkucera

@vkucera vkucera commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwgcf label Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fix includes [PWGCF] Fix includes Sep 5, 2026
@vkucera
vkucera marked this pull request as ready for review September 6, 2026 14:28
@alibuild

alibuild commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 6721bce at 2026-09-07 00:34:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 12 errors and 14 warnings.'
Found 12 errors and 14 warnings.
++ [[ 12 -gt 0 ]]
++ cat /sw/BUILD/ae11db2401906f120843aaeaa0fa79ed4d5ac298/O2Physics-code-check/errors.txt
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:124:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:229:14: error: variable 'objectIter' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:234:41: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:283:22: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:287:24: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:305:22: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:309:24: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:338:22: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:342:24: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:402:5: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:418:5: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:555:5: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
++ [[ 14 -gt 0 ]]
++ cat /sw/BUILD/ae11db2401906f120843aaeaa0fa79ed4d5ac298/O2Physics-code-check/warnings.txt
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:170:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:177:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:178:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:179:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:185:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:219:14: warning: use nullptr [modernize-use-nullptr]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:235:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:240:12: warning: use nullptr [modernize-use-nullptr]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:246:18: warning: use nullptr [modernize-use-nullptr]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:247:23: warning: use nullptr [modernize-use-nullptr]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:248:27: warning: use nullptr [modernize-use-nullptr]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:363:24: warning: use nullptr [modernize-use-nullptr]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:365:29: warning: use nullptr [modernize-use-nullptr]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:638:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
++ [[ 12 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 6721bce at 2026-09-06 20:52:

No log files found

Full log here.

ariedel-cern
ariedel-cern previously approved these changes Sep 7, 2026
abilandz
abilandz previously approved these changes Sep 7, 2026
@vkucera
vkucera dismissed stale reviews from abilandz and ariedel-cern via 2d40c7e September 9, 2026 13:42
@vkucera
vkucera requested a review from ariedel-cern September 9, 2026 13:43
@ariedel-cern
ariedel-cern enabled auto-merge (squash) September 9, 2026 14:31
@ariedel-cern
ariedel-cern merged commit 41b3ae1 into AliceO2Group:master Sep 9, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants