avd improvements - #581
Merged
Merged
Conversation
Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
I feel fairly confident they dont do anything, would be fun to find out why apple uses them Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
turns out AVD works with interchange/compressed buffers internally and only decompressed if we ask it to Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
Names are still wrong tho, mostly seg and the other Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
jannau
approved these changes
Aug 29, 2026
jannau
left a comment
jannau
left a comment
Member
There was a problem hiding this comment.
mostly some cleanup suggestions for upstream, I'll merge this. thanks
| title: Apple AVD (Apple Video Decoder) | ||
|
|
||
| description: | ||
| AVD is a video decode block present on all apple silicon devices. |
Member
There was a problem hiding this comment.
for upstream: the description should be expanded
| - apple,t6000-avd | ||
| - apple,t8112-avd | ||
| - apple,t6020-avd | ||
| - apple,t8122-avd |
Member
There was a problem hiding this comment.
for upstream: please sort alphabetically. We tried sorting be release but it doesn't provide much value and will cause inconsistently ordered lists, needless discussions on upstream submission or both.
|
|
||
| reg: | ||
| items: | ||
| - description: cm3 code |
Member
There was a problem hiding this comment.
I think it's worth writing Cortex-M3 out
|
|
||
| /* not sure what this is? mv data or something? */ | ||
| #define AVD_AV1_REF_BUF_SIZE 0xf000 | ||
| #define AVD_CDFS_SIZE (sizeof(struct avd_av1_cdfs)) |
Member
There was a problem hiding this comment.
nit: the outer parentheses aren't needed. () has the highest operator precedence in C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.